From 4440a3b7265521b29963e35146488c16f70c67ec Mon Sep 17 00:00:00 2001
From: dt <qtc-committer@nokia.com>
Date: Tue, 22 Feb 2011 17:35:34 +0100
Subject: [PATCH] QtVersionNumber: Fix crash
Checking the string for validity is not enough, actually bailing out if
it is invalid is better...
---
src/plugins/qt4projectmanager/qtversionmanager.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/plugins/qt4projectmanager/qtversionmanager.cpp b/src/plugins/qt4projectmanager/qtversionmanager.cpp
index 8cbe5961af3..391e3a6a142 100644
--- a/src/plugins/qt4projectmanager/qtversionmanager.cpp
+++ b/src/plugins/qt4projectmanager/qtversionmanager.cpp
@@ -1938,8 +1938,10 @@ QtVersionNumber::QtVersionNumber(int ma, int mi, int p)
QtVersionNumber::QtVersionNumber(const QString &versionString)
{
- if (!checkVersionString(versionString))
+ if (!checkVersionString(versionString)) {
majorVersion = minorVersion = patchVersion = -1;
+ return;
+ }
QStringList parts = versionString.split(QLatin1Char('.'));
majorVersion = parts.at(0).toInt();
--
GitLab