Commit 4b00a2bf authored by Tobias Hunger's avatar Tobias Hunger
Browse files

BaseFileWizard: Get rid of addWizardPage.

Removing the addWizardPage function makes the code easier to follow.

The old implementation did always name the CustomWizardPage as "Details",
which is just wrong. Getting rid of this makes the page use its title as
the progress text, which is what we want in general anyway.

Change-Id: Iaf44f467c45952ad881154f31f62521f4f562658
Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <>
parent 4a72355b
......@@ -116,24 +116,6 @@ void CustomWizard::setParameters(const CustomWizardParametersPtr &p)
d->m_parameters = p;
// Add a wizard page with an id, visibly warn if something goes wrong.
static inline void addWizardPage(Utils::Wizard *w, QWizardPage *p, int id)
int addedPageId = 0;
if (id == -1) {
addedPageId = w->addPage(p);
} else {
if (w->pageIds().contains(id)) {
qWarning("Page %d already present in custom wizard dialog, defaulting to add.", id);
addedPageId = w->addPage(p);
} else {
w->setPage(id, p);
addedPageId = id;
w->wizardProgress()->item(addedPageId)->setTitle(QCoreApplication::translate("ProjectExplorer::CustomWizard", "Details", "Default short title for custom wizard page to be shown in the progress pane of the wizard."));
Core::BaseFileWizard *CustomWizard::create(QWidget *parent, const Core::WizardDialogParameters &p) const
QTC_ASSERT(!d->m_parameters.isNull(), return 0);
......@@ -142,7 +124,10 @@ Core::BaseFileWizard *CustomWizard::create(QWidget *parent, const Core::WizardDi
Internal::CustomWizardPage *customPage = new Internal::CustomWizardPage(d->m_context, parameters());
addWizardPage(wizard, customPage, parameters()->firstPageId);
if (parameters()->firstPageId >= 0)
wizard->setPage(parameters()->firstPageId, customPage);
foreach (QWizardPage *ep, p.extensionPages())
if (CustomWizardPrivate::verbose)
......@@ -517,8 +502,10 @@ void CustomProjectWizard::initProjectWizardDialog(BaseProjectWizardDialog *w,
if (!pa->fields.isEmpty()) {
Internal::CustomWizardFieldPage *cp = new Internal::CustomWizardFieldPage(ctx, pa);
addWizardPage(w, cp, parameters()->firstPageId);
if (parameters()->firstPageId >= 0)
w->setPage(parameters()->firstPageId, new Internal::CustomWizardFieldPage(ctx, pa));
w->addPage(new Internal::CustomWizardFieldPage(ctx, pa));
foreach (QWizardPage *ep, extensionPages)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment