Commit 4f4b1257 authored by Erik Verbruggen's avatar Erik Verbruggen
Browse files

Project Explorer: replace a QTC_CHECK with Q_ASSERT.



When the check would fail, it would result in a nullptr deref 3 lines
down. As this is a constructor, doing a QTC_ASSERT(..., return) would
leave the object partially initialized, with some fields containing
random garbage.

Change-Id: I823d52d43d90eaf06cb7d7cd64fbee17e5fc889e
Reviewed-by: default avatarDaniel Teske <daniel.teske@digia.com>
parent 9e4d1709
......@@ -43,10 +43,11 @@ namespace ProjectExplorer {
ToolChainConfigWidget::ToolChainConfigWidget(ToolChain *tc) :
m_toolChain(tc), m_errorLabel(0)
{
QTC_CHECK(tc);
Q_ASSERT(tc);
m_nameLineEdit = new QLineEdit(this);
m_nameLineEdit->setText(tc->displayName());
m_mainLayout = new QFormLayout(this);
m_nameLineEdit->setText(tc->displayName());
m_mainLayout->setFieldGrowthPolicy(QFormLayout::ExpandingFieldsGrow); // for the Macs...
m_mainLayout->addRow(tr("Name:"), m_nameLineEdit);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment