From 50d35c74f9eeae82a9494d71d49f5e3b0631a949 Mon Sep 17 00:00:00 2001 From: Tobias Hunger <tobias.hunger@nokia.com> Date: Thu, 1 Sep 2011 14:10:00 +0000 Subject: [PATCH] CVS: Fix comparison of settings Clang did pick this one up. Change-Id: I150a4b4d9a504b1b6d741a0e10db10c63523bcd3 Reviewed-on: http://codereview.qt.nokia.com/4086 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Daniel Teske <daniel.teske@nokia.com> --- src/plugins/cvs/cvssettings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/cvs/cvssettings.cpp b/src/plugins/cvs/cvssettings.cpp index 26f1ca7b3c..beda68459b 100644 --- a/src/plugins/cvs/cvssettings.cpp +++ b/src/plugins/cvs/cvssettings.cpp @@ -94,7 +94,7 @@ void CVSSettings::toSettings(QSettings *settings) const bool CVSSettings::equals(const CVSSettings &s) const { - return promptToSubmit == promptToSubmit + return promptToSubmit == s.promptToSubmit && describeByCommitId == s.describeByCommitId && cvsCommand == s.cvsCommand && cvsRoot == s.cvsRoot -- GitLab