From 5433c8534e529da4720d70e356b2bd191c3d9756 Mon Sep 17 00:00:00 2001 From: con <qtc-committer@nokia.com> Date: Tue, 3 Feb 2009 19:47:06 +0100 Subject: [PATCH] Fixes: - Crash when opening form editor RevBy: - done with dt Details: - There was an addition setCurrentEditor signal with the old editor sent while opening the new editor, coming from adding the new entry into the model for the editor combo box. --- src/plugins/coreplugin/editormanager/stackededitorgroup.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plugins/coreplugin/editormanager/stackededitorgroup.cpp b/src/plugins/coreplugin/editormanager/stackededitorgroup.cpp index 08e63b2773e..cc759c6c7ff 100644 --- a/src/plugins/coreplugin/editormanager/stackededitorgroup.cpp +++ b/src/plugins/coreplugin/editormanager/stackededitorgroup.cpp @@ -217,7 +217,6 @@ void StackedEditorGroup::addEditor(IEditor *editor) void StackedEditorGroup::insertEditor(int index, IEditor *editor) { - EditorGroup::insertEditor(index, editor); if (m_container->indexOf(editor->widget()) != -1) return; @@ -231,6 +230,9 @@ void StackedEditorGroup::insertEditor(int index, IEditor *editor) } connect(editor, SIGNAL(changed()), this, SLOT(checkEditorStatus())); + bool block = m_editorList->blockSignals(true); + EditorGroup::insertEditor(index, editor); + m_editorList->blockSignals(block); emit editorAdded(editor); } -- GitLab