fix mac compile

src/plugins/coreplugin/editormanager/editormanager.cpp

@@ -74,10 +74,11 @@ using namespace Core::Internal;
 
 enum { debugEditorManager=0 };
 
-QString EditorManager::defaultExternalEditor() {
+QString EditorManager::defaultExternalEditor() const
+{
 #ifdef Q_OS_MAC
-    return m_d->m_externalEditor = m_d->m_core->resourcePath()
-                                   +QLatin1String("/runInTerminal.command vi %f %l %c %W %H %x %y");
+    return m_d->m_core->resourcePath()
+            +QLatin1String("/runInTerminal.command vi %f %l %c %W %H %x %y");
 #elif defined(Q_OS_UNIX)
     return QLatin1String("xterm -geom %Wx%H+%x+%y -e vi %f +%l +\"normal %c|\"");
 #elif defined (Q_OS_WIN)

src/plugins/coreplugin/editormanager/editormanager.h

@@ -156,7 +156,7 @@ public:
 
     void setExternalEditor(const QString &);
     QString externalEditor() const;
-    static QString defaultExternalEditor();
+    QString defaultExternalEditor() const;
     QString externalEditorHelpText() const;
 
 signals:

src/plugins/coreplugin/generalsettings.cpp

@@ -99,7 +99,7 @@ void GeneralSettings::resetInterfaceColor()
 
 void GeneralSettings::resetExternalEditor()
 {
-    m_page->externalEditorEdit->setText(EditorManager::defaultExternalEditor());
+    m_page->externalEditorEdit->setText(EditorManager::instance()->defaultExternalEditor());
 }
 
 void GeneralSettings::showHelpForExternalEditor()