From 5b75af80497ea38d5b7bb6907f374c7b7149535f Mon Sep 17 00:00:00 2001
From: Daniel Teske <daniel.teske@digia.com>
Date: Mon, 1 Sep 2014 16:24:24 +0200
Subject: [PATCH] AppOutputPane: Fix wrong assert
This can actually happen and is not a problem
Task-number: QTCREATORBUG-12871
Change-Id: I0bcca39f160362a5c67cfceaefa5dd9d58d69b55
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
---
src/plugins/projectexplorer/appoutputpane.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/plugins/projectexplorer/appoutputpane.cpp b/src/plugins/projectexplorer/appoutputpane.cpp
index 6cf3ea5e147..df9065b3499 100644
--- a/src/plugins/projectexplorer/appoutputpane.cpp
+++ b/src/plugins/projectexplorer/appoutputpane.cpp
@@ -605,7 +605,9 @@ void AppOutputPane::slotRunControlFinished2(RunControl *sender)
{
const int senderIndex = indexOf(sender);
- QTC_ASSERT(senderIndex != -1, return);
+ // This slot is queued, so the stop() call in closeTab might lead to this slot, after closeTab already cleaned up
+ if (senderIndex == -1)
+ return;
// Enable buttons for current
RunControl *current = currentRunControl();
--
GitLab