Commit 60e30300 authored by Robert Loehning's avatar Robert Loehning Committed by hjk
Browse files

Valgrind: Check function early to avoid nullptr deref



Change-Id: I19da2e8f9dd3f6d7af0d412e07a257ba33ecb680
Reviewed-by: default avatarhjk <hjk@qt.io>
parent a49df504
......@@ -121,14 +121,17 @@ bool DataProxyModel::filterAcceptsRow(int source_row, const QModelIndex &source_
const Function *func = source_index.data(DataModel::FunctionRole).value<const Function *>();
if (!func)
return false;
// check if func is located in the specific base directory, if any
if (func && !m_baseDir.isEmpty()) {
if (!m_baseDir.isEmpty()) {
if (!func->location().startsWith(m_baseDir))
return false;
}
// check if the function from this index is a child of (called by) the filter function
if (func && m_function) {
if (m_function) {
bool isValid = false;
foreach (const FunctionCall *call, func->incomingCalls()) {
if (call->caller() == m_function) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment