Locator: Remove unused return value

Change-Id: I3f7d237430591cfa1ddf07a92e74805b0628bcff
Reviewed-by: David Schulz <david.schulz@qt.io>

src/plugins/coreplugin/locator/directoryfilter.cpp

@@ -59,7 +59,7 @@ QByteArray DirectoryFilter::saveState() const
     return value;
 }
 
-bool DirectoryFilter::restoreState(const QByteArray &state)
+void DirectoryFilter::restoreState(const QByteArray &state)
 {
     QMutexLocker locker(&m_lock);
 
@@ -84,7 +84,6 @@ bool DirectoryFilter::restoreState(const QByteArray &state)
     setIncludedByDefault(defaultFilter);
 
     updateFileIterator();
-    return true;
 }
 
 bool DirectoryFilter::openConfigDialog(QWidget *parent, bool &needsRefresh)

src/plugins/coreplugin/locator/directoryfilter.h

@@ -43,7 +43,7 @@ class DirectoryFilter : public BaseFileFilter
 public:
     DirectoryFilter(Id id);
     QByteArray saveState() const;
-    bool restoreState(const QByteArray &state);
+    void restoreState(const QByteArray &state);
     bool openConfigDialog(QWidget *parent, bool &needsRefresh);
     void refresh(QFutureInterface<void> &future);
 

src/plugins/coreplugin/locator/filesystemfilter.cpp

@@ -202,7 +202,7 @@ QByteArray FileSystemFilter::saveState() const
     return value;
 }
 
-bool FileSystemFilter::restoreState(const QByteArray &state)
+void FileSystemFilter::restoreState(const QByteArray &state)
 {
     QDataStream in(state);
     in >> m_includeHidden;
@@ -216,6 +216,4 @@ bool FileSystemFilter::restoreState(const QByteArray &state)
         setShortcutString(shortcut);
         setIncludedByDefault(defaultFilter);
     }
-
-    return true;
 }

src/plugins/coreplugin/locator/filesystemfilter.h

@@ -48,7 +48,7 @@ public:
     QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future, const QString &entry);
     void accept(LocatorFilterEntry selection) const;
     QByteArray saveState() const;
-    bool restoreState(const QByteArray &state);
+    void restoreState(const QByteArray &state);
     bool openConfigDialog(QWidget *parent, bool &needsRefresh);
     void refresh(QFutureInterface<void> &) {}
 

src/plugins/coreplugin/locator/ilocatorfilter.cpp

@@ -66,7 +66,7 @@ QByteArray ILocatorFilter::saveState() const
     return value;
 }
 
-bool ILocatorFilter::restoreState(const QByteArray &state)
+void ILocatorFilter::restoreState(const QByteArray &state)
 {
     QString shortcut;
     bool defaultFilter;
@@ -77,7 +77,6 @@ bool ILocatorFilter::restoreState(const QByteArray &state)
 
     setShortcutString(shortcut);
     setIncludedByDefault(defaultFilter);
-    return true;
 }
 
 bool ILocatorFilter::openConfigDialog(QWidget *parent, bool &needsRefresh)

src/plugins/coreplugin/locator/ilocatorfilter.h

@@ -136,7 +136,7 @@ public:
     virtual QByteArray saveState() const;
 
     /* Used to restore the filter at start up. */
-    virtual bool restoreState(const QByteArray &state);
+    virtual void restoreState(const QByteArray &state);
 
     /* User wants to configure this filter (if supported). Use it to pop up a dialog.
      * needsRefresh is used as a hint to indicate that refresh should be called.

src/plugins/help/remotehelpfilter.cpp

@@ -166,7 +166,7 @@ QByteArray RemoteHelpFilter::saveState() const
     return value;
 }
 
-bool RemoteHelpFilter::restoreState(const QByteArray &state)
+void RemoteHelpFilter::restoreState(const QByteArray &state)
 {
     QDataStream in(state);
 
@@ -181,8 +181,6 @@ bool RemoteHelpFilter::restoreState(const QByteArray &state)
     bool defaultFilter;
     in >> defaultFilter;
     setIncludedByDefault(defaultFilter);
-
-    return true;
 }
 
 bool RemoteHelpFilter::openConfigDialog(QWidget *parent, bool &needsRefresh)

src/plugins/help/remotehelpfilter.h

@@ -47,7 +47,7 @@ public:
     void accept(Core::LocatorFilterEntry selection) const;
     void refresh(QFutureInterface<void> &future);
     QByteArray saveState() const;
-    bool restoreState(const QByteArray &state);
+    void restoreState(const QByteArray &state);
     bool openConfigDialog(QWidget *parent, bool &needsRefresh);
 
     QStringList remoteUrls() const;