From 67e515aec6b490cd57baf5096d957feba2ee292e Mon Sep 17 00:00:00 2001
From: Ulf Hermann <ulf.hermann@theqtcompany.com>
Date: Mon, 8 Dec 2014 10:29:44 +0100
Subject: [PATCH] QmlProfiler: remove useless notesChanged signal from
aggregator
Change-Id: Ifebd60a24b3e07702ca603425b5133e9a23557c5
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
---
src/plugins/qmlprofiler/qml/Overview.qml | 6 +++++-
src/plugins/qmlprofiler/timelinemodelaggregator.cpp | 2 --
src/plugins/qmlprofiler/timelinemodelaggregator.h | 1 -
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/plugins/qmlprofiler/qml/Overview.qml b/src/plugins/qmlprofiler/qml/Overview.qml
index 3fd01825d0b..3e2a3183abb 100644
--- a/src/plugins/qmlprofiler/qml/Overview.qml
+++ b/src/plugins/qmlprofiler/qml/Overview.qml
@@ -113,7 +113,11 @@ Canvas {
offset = -1;
requestPaint();
}
- onNotesChanged: notes.doPaint = true;
+ }
+
+ Connections {
+ target: modelProxy.notes
+ onChanged: notes.doPaint = true
}
Timer {
diff --git a/src/plugins/qmlprofiler/timelinemodelaggregator.cpp b/src/plugins/qmlprofiler/timelinemodelaggregator.cpp
index 99b5fd3aed1..a686bd4e98b 100644
--- a/src/plugins/qmlprofiler/timelinemodelaggregator.cpp
+++ b/src/plugins/qmlprofiler/timelinemodelaggregator.cpp
@@ -59,8 +59,6 @@ TimelineModelAggregator::TimelineModelAggregator(QmlProfilerNotesModel *notes, Q
d->notesModel = notes;
connect(this,SIGNAL(modelsChanged()),this,SIGNAL(heightChanged()));
connect(this,SIGNAL(stateChanged()),this,SIGNAL(heightChanged()));
- connect(notes, SIGNAL(changed(int,int,int)), this, SIGNAL(notesChanged(int,int,int)));
-
}
TimelineModelAggregator::~TimelineModelAggregator()
diff --git a/src/plugins/qmlprofiler/timelinemodelaggregator.h b/src/plugins/qmlprofiler/timelinemodelaggregator.h
index 0be00ed2726..b1961065242 100644
--- a/src/plugins/qmlprofiler/timelinemodelaggregator.h
+++ b/src/plugins/qmlprofiler/timelinemodelaggregator.h
@@ -66,7 +66,6 @@ public:
signals:
void dataAvailable();
void stateChanged();
- void notesChanged(int typeId, int modelIndex, int eventIndex);
void modelsChanged();
void heightChanged();
--
GitLab