diff --git a/src/plugins/cmakeprojectmanager/cmaketarget.cpp b/src/plugins/cmakeprojectmanager/cmaketarget.cpp index 955b152cd3da8426e98ed1d0d9e30604e5a0109b..c38ccd15d4345672749a9a4edcf684a11643735b 100644 --- a/src/plugins/cmakeprojectmanager/cmaketarget.cpp +++ b/src/plugins/cmakeprojectmanager/cmaketarget.cpp @@ -86,11 +86,7 @@ bool CMakeTarget::fromMap(const QVariantMap &map) if (!Target::fromMap(map)) return false; - if (displayName().isEmpty()) - setDisplayName(displayNameForId(id())); - if (icon().isNull()) - setIcon(qApp->style()->standardIcon(QStyle::SP_ComputerIcon)); - + setDisplayName(displayNameForId(id())); return true; } diff --git a/src/plugins/genericprojectmanager/generictarget.cpp b/src/plugins/genericprojectmanager/generictarget.cpp index a2ec7588394ad78b01009197e7503381e81d8675..98eb8a2239b2c69fde5b74c8ada239954db9cee8 100644 --- a/src/plugins/genericprojectmanager/generictarget.cpp +++ b/src/plugins/genericprojectmanager/generictarget.cpp @@ -83,13 +83,9 @@ bool GenericTarget::fromMap(const QVariantMap &map) if (!Target::fromMap(map)) return false; - if (displayName().isEmpty()) - setDisplayName(QApplication::translate("GenericProjectManager::GenericTarget", - GENERIC_DESKTOP_TARGET_DISPLAY_NAME, - "Generic desktop target display name")); - if (icon().isNull()) - setIcon(qApp->style()->standardIcon(QStyle::SP_ComputerIcon)); - + setDisplayName(QApplication::translate("GenericProjectManager::GenericTarget", + GENERIC_DESKTOP_TARGET_DISPLAY_NAME, + "Generic desktop target display name")); return true; } diff --git a/src/plugins/projectexplorer/target.cpp b/src/plugins/projectexplorer/target.cpp index f6a1f8e6d8cce1362e8c4a085e3fbc7dea6b96fe..659c102e12cc0673c1e21fe6025c2b1af493b973 100644 --- a/src/plugins/projectexplorer/target.cpp +++ b/src/plugins/projectexplorer/target.cpp @@ -46,7 +46,6 @@ const char * const ACTIVE_RC_KEY("ProjectExplorer.Target.ActiveRunConfiguration" const char * const RC_KEY_PREFIX("ProjectExplorer.Target.RunConfiguration."); const char * const RC_COUNT_KEY("ProjectExplorer.Target.RunConfigurationCount"); -const char * const ICON_KEY("ProjectExplorer.Target.Icon"); } // namespace // ------------------------------------------------------------------------- @@ -241,8 +240,6 @@ QVariantMap Target::toMap() const for (int i = 0; i < rcs.size(); ++i) map.insert(QString::fromLatin1(RC_KEY_PREFIX) + QString::number(i), rcs.at(i)->toMap()); - map.insert(QLatin1String(ICON_KEY), m_icon); - return map; } @@ -260,8 +257,6 @@ bool Target::fromMap(const QVariantMap &map) if (!ProjectConfiguration::fromMap(map)) return false; - m_icon = map.value(QLatin1String(ICON_KEY)).value<QIcon>(); - bool ok; int bcCount(map.value(QLatin1String(BC_COUNT_KEY), 0).toInt(&ok)); if (!ok || bcCount < 0) diff --git a/src/plugins/projectexplorer/userfileaccessor.cpp b/src/plugins/projectexplorer/userfileaccessor.cpp index 661eab47af64cc44e55d03078ffc15d646003b68..a5ffee005a22414b125891c67f06d5150c9f38a0 100644 --- a/src/plugins/projectexplorer/userfileaccessor.cpp +++ b/src/plugins/projectexplorer/userfileaccessor.cpp @@ -734,12 +734,12 @@ QVariantMap Version1Handler::update(Project *project, const QVariantMap &map) "Qt4 Desktop target display name")) << TargetDescription(QString::fromLatin1("Qt4ProjectManager.Target.S60EmulatorTarget"), QCoreApplication::translate("Qt4ProjectManager::Internal::Qt4Target", - "S60 Emulator", - "Qt4 S60 Emulator target display name")) + "Symbian Emulator", + "Qt4 Symbian Emulator target display name")) << TargetDescription(QString::fromLatin1("Qt4ProjectManager.Target.S60DeviceTarget"), QCoreApplication::translate("Qt4ProjectManager::Internal::Qt4Target", - "S60 Device", - "Qt4 S60 Device target display name")) + "Symbian Device", + "Qt4 Symbian Device target display name")) << TargetDescription(QString::fromLatin1("Qt4ProjectManager.Target.MaemoEmulatorTarget"), QCoreApplication::translate("Qt4ProjectManager::Internal::Qt4Target", "Maemo Emulator", diff --git a/src/plugins/qmlprojectmanager/qmltarget.cpp b/src/plugins/qmlprojectmanager/qmltarget.cpp index c8a2ab5290ddbb5807cb648e9edcd11e87f581fa..11ead390f60d898a102110d19bbcb56585f3c060 100644 --- a/src/plugins/qmlprojectmanager/qmltarget.cpp +++ b/src/plugins/qmlprojectmanager/qmltarget.cpp @@ -73,12 +73,9 @@ bool QmlTarget::fromMap(const QVariantMap &map) if (!Target::fromMap(map)) return false; - if (displayName().isEmpty()) - setDisplayName(QApplication::translate("QmlProjectManager::QmlTarget", - VIEWER_TARGET_DISPLAY_NAME, - "Qml Viewer target display name")); - if (icon().isNull()) - setIcon(qApp->style()->standardIcon(QStyle::SP_ComputerIcon)); + setDisplayName(QApplication::translate("QmlProjectManager::QmlTarget", + VIEWER_TARGET_DISPLAY_NAME, + "Qml Viewer target display name")); return true; } diff --git a/src/plugins/qt4projectmanager/qt-s60/qt-s60.pri b/src/plugins/qt4projectmanager/qt-s60/qt-s60.pri index 85349af71c21c757887f373239623407e301e5c9..8285a9ee5dda60ebda120af76eea5e45684f8f3b 100644 --- a/src/plugins/qt4projectmanager/qt-s60/qt-s60.pri +++ b/src/plugins/qt4projectmanager/qt-s60/qt-s60.pri @@ -1,5 +1,5 @@ !isEmpty(SUPPORT_QT_S60) { - message("Adding experimental support for Qt/S60 applications.") + message("Adding experimental support for Qt Symbian applications.") DEFINES += QTCREATOR_WITH_S60 } SOURCES += $$PWD/s60devices.cpp \ diff --git a/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp b/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp index eba735302b5bcec1d751aaacf4290f9bd51e8add..582576b1fcb5bc6f8613103e84c6fce4ee7036ae 100644 --- a/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp +++ b/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp @@ -346,7 +346,7 @@ void S60DeviceRunConfiguration::updateTarget() if (info.error != Qt4TargetInformation::NoError) { if (info.error == Qt4TargetInformation::ProParserError) { Core::ICore::instance()->messageManager()->printToOutputPane( - tr("Could not parse %1. The QtS60 Device run configuration %2 can not be started.") + tr("Could not parse %1. The Qt Symbian Device run configuration %2 can not be started.") .arg(m_proFilePath).arg(displayName())); } m_targetName.clear(); diff --git a/src/plugins/qt4projectmanager/qt4target.cpp b/src/plugins/qt4projectmanager/qt4target.cpp index 03aac13528b901617413ba93f44f591b8b51f828..497a9d17e901f28be0a4dcda865b0f620bbea458 100644 --- a/src/plugins/qt4projectmanager/qt4target.cpp +++ b/src/plugins/qt4projectmanager/qt4target.cpp @@ -57,9 +57,9 @@ QString displayNameForId(const QString &id) { if (id == QLatin1String(DESKTOP_TARGET_ID)) return QApplication::translate("Qt4ProjectManager::Internal::Qt4Target", "Desktop", "Qt4 Desktop target display name"); if (id == QLatin1String(S60_EMULATOR_TARGET_ID)) - return QApplication::translate("Qt4ProjectManager::Internal::Qt4Target", "S60 Emulator", "Qt4 S60 Emulator target display name"); + return QApplication::translate("Qt4ProjectManager::Internal::Qt4Target", "Symbian Emulator", "Qt4 Symbian Emulator target display name"); if (id == QLatin1String(S60_DEVICE_TARGET_ID)) - return QApplication::translate("Qt4ProjectManager::Internal::Qt4Target", "S60 Device", "Qt4 S60 Device target display name"); + return QApplication::translate("Qt4ProjectManager::Internal::Qt4Target", "Symbian Device", "Qt4 Symbian Device target display name"); if (id == QLatin1String(MAEMO_EMULATOR_TARGET_ID)) return QApplication::translate("Qt4ProjectManager::Internal::Qt4Target", "Maemo Emulator", "Qt4 Maemo Emulator target display name"); if (id == QLatin1String(MAEMO_DEVICE_TARGET_ID)) @@ -382,10 +382,8 @@ bool Qt4Target::fromMap(const QVariantMap &map) if (!Target::fromMap(map)) return false; - if (displayName().isEmpty()) - setDisplayName(displayNameForId(id())); - if (icon().isNull()) - setIcon(iconForId(id())); + setDisplayName(displayNameForId(id())); + updateToolTipAndIcon(); return true; }