From 77959c8bc56e79e534dc1a61558c717f09439ee8 Mon Sep 17 00:00:00 2001 From: Norwegian Rock Cat <qt-info@nokia.com> Date: Tue, 7 Jul 2009 14:58:26 +0200 Subject: [PATCH] Only call setVisible on this item after it has been put in a layout If you call setVisible(true) on the item before it is placed in a hierarchy, it will show as a normal top-level window. On some platforms this isn't really an issue, but with Carbon, the show happens immediately, so you get this flash of a window which is really disturbing. I'm surprised it's not noticed on other platforms. Personally, I'm not sure why we call this at all, but I'm leaving it for the moment. --- src/plugins/coreplugin/mainwindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/coreplugin/mainwindow.cpp b/src/plugins/coreplugin/mainwindow.cpp index 66b84c85f92..3d2909c31f7 100644 --- a/src/plugins/coreplugin/mainwindow.cpp +++ b/src/plugins/coreplugin/mainwindow.cpp @@ -302,9 +302,9 @@ bool MainWindow::init(QString *errorMessage) m_outputMode->setPriority(Constants::P_MODE_OUTPUT); m_outputMode->setWidget(outputModeWidget); OutputPanePlaceHolder *oph = new OutputPanePlaceHolder(m_outputMode); - oph->setVisible(true); oph->setCloseable(false); outputModeWidget->layout()->addWidget(oph); + oph->setVisible(true); outputModeWidget->layout()->addWidget(new Core::FindToolBarPlaceHolder(m_outputMode)); outputModeWidget->setFocusProxy(oph); -- GitLab