ClangStaticAnalyzer: Don't show 'stopped by user' if it wasn't

Task-number: QTCREATORBUG-18581
Change-Id: Ib5d2aded5da14e44f3186a2ed67f119764d6d58d
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>

src/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp

@@ -80,7 +80,11 @@ ClangStaticAnalyzerToolRunner::ClangStaticAnalyzerToolRunner(RunControl *runCont
     RunConfiguration *runConfiguration = runControl->runConfiguration();
     auto tool = ClangStaticAnalyzerTool::instance();
     tool->stopAction()->disconnect();
-    connect(tool->stopAction(), &QAction::triggered, runControl, &RunControl::initiateStop);
+    connect(tool->stopAction(), &QAction::triggered, runControl, [&] {
+        initiateStop();
+        appendMessage(tr("Clang Static Analyzer stopped by user."),
+                      Utils::NormalMessageFormat);
+    });
     tool->handleWorkerStart(this);
 
     ProjectInfo projectInfoBeforeBuild = tool->projectInfoBeforeBuild();
@@ -605,8 +609,6 @@ void ClangStaticAnalyzerToolRunner::stop()
     }
     m_runners.clear();
     m_unitsToProcess.clear();
-    appendMessage(tr("Clang Static Analyzer stopped by user."),
-                  Utils::NormalMessageFormat);
     m_progress.reportFinished();
     ClangStaticAnalyzerTool::instance()->onEngineFinished(m_success);
     reportStopped();