diff --git a/src/plugins/cmakeprojectmanager/cmakeproject.cpp b/src/plugins/cmakeprojectmanager/cmakeproject.cpp index f67c038496e7088df28b234edfda3aa4da12f059..d0faebe6d17c88b28a2edbc393fb29ffc3531a05 100644 --- a/src/plugins/cmakeprojectmanager/cmakeproject.cpp +++ b/src/plugins/cmakeprojectmanager/cmakeproject.cpp @@ -984,10 +984,10 @@ QString CMakeCbpParser::compilerName() const void CMakeBuildTarget::clear() { - executable = QString::null; - makeCommand = QString::null; - makeCleanCommand = QString::null; - workingDirectory = QString::null; - title = QString::null; + executable.clear(); + makeCommand.clear(); + makeCleanCommand.clear(); + workingDirectory.clear(); + title.clear(); } diff --git a/src/plugins/cmakeprojectmanager/cmakeprojectmanager.cpp b/src/plugins/cmakeprojectmanager/cmakeprojectmanager.cpp index f85fa199b603468674223ba40369eb8f75fc5709..474e4256e3c107f86f98fe7fe7c84cdaad151dd0 100644 --- a/src/plugins/cmakeprojectmanager/cmakeprojectmanager.cpp +++ b/src/plugins/cmakeprojectmanager/cmakeprojectmanager.cpp @@ -131,7 +131,7 @@ QString CMakeManager::findCbpFile(const QDir &directory) if (cbpFile.endsWith(QLatin1String(".cbp"))) return directory.path() + QLatin1Char('/') + cbpFile; } - return QString::null; + return QString(); } // This code is duplicated from qtversionmanager diff --git a/src/plugins/debugger/gdb/gdbmi.cpp b/src/plugins/debugger/gdb/gdbmi.cpp index b5a5774a83d121aa323cd7a37c583fa4231ee779..f6b736599a7588ce4e4c701bd0ea1cc63dd0ca65 100644 --- a/src/plugins/debugger/gdb/gdbmi.cpp +++ b/src/plugins/debugger/gdb/gdbmi.cpp @@ -308,33 +308,33 @@ QByteArray GdbMi::toString(bool multiline, int indent) const break; case Const: if (!m_name.isEmpty()) - result += m_name + "="; - result += "\"" + escapeCString(m_data) + "\""; + result += m_name + '='; + result += '"' + escapeCString(m_data) + '"'; break; case Tuple: if (!m_name.isEmpty()) - result += m_name + "="; + result += m_name + '='; if (multiline) { result += "{\n"; dumpChildren(&result, multiline, indent + 1); - result += '\n' + ind(indent) + "}"; + result += '\n' + ind(indent) + '}'; } else { - result += "{"; + result += '{'; dumpChildren(&result, multiline, indent + 1); - result += "}"; + result += '}'; } break; case List: if (!m_name.isEmpty()) - result += m_name + "="; + result += m_name + '='; if (multiline) { result += "[\n"; dumpChildren(&result, multiline, indent + 1); - result += '\n' + ind(indent) + "]"; + result += '\n' + ind(indent) + ']'; } else { - result += "["; + result += '['; dumpChildren(&result, multiline, indent + 1); - result += "]"; + result += ']'; } break; } diff --git a/src/plugins/designer/formwindoweditor.cpp b/src/plugins/designer/formwindoweditor.cpp index 5f3cc0c5665399211590389cb3a42d53f08ef745..48e211312726520f5c6f75c66311c837327d2b97 100644 --- a/src/plugins/designer/formwindoweditor.cpp +++ b/src/plugins/designer/formwindoweditor.cpp @@ -371,7 +371,7 @@ QString FormWindowEditor::contextHelpId() const QString FormWindowEditor::contents() const { if (!m_formWindow) - return QString::null; + return QString(); // Activate once all Qt branches around have integrated 4.5.2 // (Kinetic) /* diff --git a/src/plugins/fakevim/fakevimhandler.cpp b/src/plugins/fakevim/fakevimhandler.cpp index df9cfee218390f824e574e3cdfdd4693b5b61758..d65ca876f4c12e287709bb34230b103a519ed63d 100644 --- a/src/plugins/fakevim/fakevimhandler.cpp +++ b/src/plugins/fakevim/fakevimhandler.cpp @@ -885,7 +885,7 @@ void FakeVimHandler::Private::finishMovement(const QString &dotCommand) if (m_submode == ChangeSubMode) { removeSelectedText(true); if (!dotCommand.isEmpty()) - setDotCommand("c" + dotCommand); + setDotCommand(QLatin1Char('c') + dotCommand); if (m_movetype == MoveLineWise) { insertAutomaticIndentation(true); } @@ -896,7 +896,7 @@ void FakeVimHandler::Private::finishMovement(const QString &dotCommand) } else if (m_submode == DeleteSubMode) { removeSelectedText(); if (!dotCommand.isEmpty()) - setDotCommand("d" + dotCommand); + setDotCommand(QLatin1Char('d') + dotCommand); if (m_movetype == MoveLineWise) handleStartOfLine(); m_submode = NoSubMode; @@ -922,7 +922,7 @@ void FakeVimHandler::Private::finishMovement(const QString &dotCommand) if (m_subsubmode == InvertCaseSubSubMode) { invertCaseSelectedText(); if (!dotCommand.isEmpty()) - setDotCommand("~" + dotCommand); + setDotCommand(QLatin1Char('~') + dotCommand); } else if (m_subsubmode == UpCaseSubSubMode) { upCaseSelectedText(); if (!dotCommand.isEmpty()) @@ -1204,7 +1204,7 @@ EventResult FakeVimHandler::Private::handleCommandMode(int key, int unmodified, // Recognize ZZ and ZQ as aliases for ":x" and ":q!". m_submode = NoSubMode; if (key == 'Z') - handleCommand("x"); + handleCommand(QString(QLatin1Char('x'))); else if (key == 'Q') handleCommand("q!"); } else if (m_subsubmode == FtSubSubMode) { @@ -1251,14 +1251,14 @@ EventResult FakeVimHandler::Private::handleCommandMode(int key, int unmodified, m_movetype = MoveExclusive; moveToStartOfLine(); setTargetColumn(); - finishMovement("0"); + finishMovement(QString(QLatin1Char('0'))); } else { m_mvcount.append(QChar(key)); } } else if (key == '^') { moveToFirstNonBlankOnLine(); m_movetype = MoveExclusive; - finishMovement("^"); + finishMovement(QString(QLatin1Char('^'))); } else if (0 && key == ',') { // FIXME: fakevim uses ',' by itself, so it is incompatible m_subsubmode = FtSubSubMode; @@ -1403,7 +1403,7 @@ EventResult FakeVimHandler::Private::handleCommandMode(int key, int unmodified, } else if (key == 'A') { enterInsertMode(); moveBehindEndOfLine(); - setDotCommand("A"); + setDotCommand(QString(QLatin1Char('A'))); m_lastInsertion.clear(); updateMiniBuffer(); } else if (key == control('a')) { @@ -1433,7 +1433,7 @@ EventResult FakeVimHandler::Private::handleCommandMode(int key, int unmodified, setAnchor(); moveToEndOfLine(); m_submode = ChangeSubMode; - setDotCommand("C"); + setDotCommand(QString(QLatin1Char('C'))); finishMovement(); } else if (key == control('c')) { if (isNoVisualMode()) @@ -1476,7 +1476,7 @@ EventResult FakeVimHandler::Private::handleCommandMode(int key, int unmodified, moveDown(qMax(count() - 1, 0)); m_movetype = MoveInclusive; moveToEndOfLine(); - setDotCommand("D"); + setDotCommand(QString(QLatin1Char('D'))); finishMovement(); } else if ((key == 'D' || key == 'X') && (isVisualCharMode() || isVisualLineMode())) { @@ -1526,7 +1526,7 @@ EventResult FakeVimHandler::Private::handleCommandMode(int key, int unmodified, } else if (key == 'g' || key == 'G') { QString dotCommand = QString("%1G").arg(count()); if (key == 'G' && m_mvcount.isEmpty()) - dotCommand = "G"; + dotCommand = QString(QLatin1Char('G')); if (key == 'g') m_gflag = false; int n = (key == 'g') ? 1 : linesInDocument(); @@ -1557,13 +1557,13 @@ EventResult FakeVimHandler::Private::handleCommandMode(int key, int unmodified, handleStartOfLine(); finishMovement(); } else if (key == 'i' || key == Key_Insert) { - setDotCommand("i"); // setDotCommand("%1i", count()); + setDotCommand(QString(QLatin1Char('i'))); // setDotCommand("%1i", count()); enterInsertMode(); updateMiniBuffer(); if (atEndOfLine()) moveLeft(); } else if (key == 'I') { - setDotCommand("I"); // setDotCommand("%1I", count()); + setDotCommand(QString(QLatin1Char('I'))); // setDotCommand("%1I", count()); enterInsertMode(); if (m_gflag) moveToStartOfLine(); @@ -1597,7 +1597,7 @@ EventResult FakeVimHandler::Private::handleCommandMode(int key, int unmodified, || characterAtCursor() == '\t') moveRight(); removeSelectedText(); - m_tc.insertText(" "); + m_tc.insertText(QString(QLatin1Char(' '))); } } if (!m_gflag) @@ -1685,14 +1685,14 @@ EventResult FakeVimHandler::Private::handleCommandMode(int key, int unmodified, finishMovement(); } else if (key == 'r') { m_submode = ReplaceSubMode; - setDotCommand("r"); + setDotCommand(QString(QLatin1Char('r'))); } else if (key == 'R') { // FIXME: right now we repeat the insertion count() times, // but not the deletion m_lastInsertion.clear(); enterInsertMode(); m_submode = ReplaceSubMode; - setDotCommand("R"); + setDotCommand(QString(QLatin1Char('R'))); updateMiniBuffer(); } else if (key == control('r')) { redo(); diff --git a/src/plugins/git/changeselectiondialog.cpp b/src/plugins/git/changeselectiondialog.cpp index a99fab61aedf382251a1ee485845bbf11ae7f818..d967a7b8b2855854ab221337a3c29a90a13cd481 100644 --- a/src/plugins/git/changeselectiondialog.cpp +++ b/src/plugins/git/changeselectiondialog.cpp @@ -60,7 +60,7 @@ void ChangeSelectionDialog::setRepository(const QString &s) void ChangeSelectionDialog::selectWorkingDirectory() { - static QString location = QString(); + static QString location; location = QFileDialog::getExistingDirectory(this, tr("Select Git repository"), location); diff --git a/src/plugins/locator/basefilefilter.cpp b/src/plugins/locator/basefilefilter.cpp index ed5e02f76ade6a30a36ce76a5f2dea4a661c8ff0..40000c7549b3b617082e29fb02cd40478fefa43f 100644 --- a/src/plugins/locator/basefilefilter.cpp +++ b/src/plugins/locator/basefilefilter.cpp @@ -49,10 +49,11 @@ QList<FilterEntry> BaseFileFilter::matchesFor(const QString &origEntry) QList<FilterEntry> badMatches; QString needle = trimWildcards(origEntry); QStringMatcher matcher(needle, Qt::CaseInsensitive); - const QRegExp regexp("*"+needle+"*", Qt::CaseInsensitive, QRegExp::Wildcard); + const QChar asterisk = QLatin1Char('*'); + const QRegExp regexp(asterisk + needle+ asterisk, Qt::CaseInsensitive, QRegExp::Wildcard); if (!regexp.isValid()) return matches; - bool hasWildcard = (needle.contains('*') || needle.contains('?')); + bool hasWildcard = (needle.contains(asterisk) || needle.contains('?')); QStringList searchListPaths; QStringList searchListNames; if (!m_previousEntry.isEmpty() && !m_forceNewSearchList && needle.contains(m_previousEntry)) { diff --git a/src/plugins/locator/locatorfiltersfilter.cpp b/src/plugins/locator/locatorfiltersfilter.cpp index 7580d6539e18c2e4f43b82ad0d6fc8c681ceb1d4..21e68cf6cd32eb3a7267490bde41a14f96bec662 100644 --- a/src/plugins/locator/locatorfiltersfilter.cpp +++ b/src/plugins/locator/locatorfiltersfilter.cpp @@ -85,7 +85,7 @@ void LocatorFiltersFilter::accept(FilterEntry selection) const { ILocatorFilter *filter = selection.internalData.value<ILocatorFilter*>(); if (filter) - m_locatorWidget->show(filter->shortcutString() + " ", + m_locatorWidget->show(filter->shortcutString() + QLatin1Char(' '), filter->shortcutString().length() + 1); } diff --git a/src/plugins/perforce/perforceplugin.cpp b/src/plugins/perforce/perforceplugin.cpp index 2e24cad6b068e620a8b9447fc0d7cf60115b0fc0..d411972718b4a1ac9818039c0f5694717d05ba53 100644 --- a/src/plugins/perforce/perforceplugin.cpp +++ b/src/plugins/perforce/perforceplugin.cpp @@ -1307,7 +1307,7 @@ QString PerforcePlugin::clientFilePath(const QString &serverFilePath) const PerforceResponse response = runP4Cmd(m_settings.topLevelSymLinkTarget(), args, ShowBusyCursor|RunFullySynchronous|CommandToWindow|StdErrToWindow|ErrorToWindow); if (response.error) - return QString::null; + return QString(); QRegExp r(QLatin1String("\\.\\.\\.\\sclientFile\\s(.+)\n")); r.setMinimal(true); @@ -1325,19 +1325,19 @@ QString PerforcePlugin::pendingChangesData() const PerforceResponse userResponse = runP4Cmd(m_settings.topLevelSymLinkTarget(), args, RunFullySynchronous|CommandToWindow|StdErrToWindow|ErrorToWindow); if (userResponse.error) - return QString::null; + return QString(); QRegExp r(QLatin1String("User\\sname:\\s(\\S+)\\s*\n")); QTC_ASSERT(r.isValid(), return QString()) r.setMinimal(true); - const QString user = r.indexIn(userResponse.stdOut) != -1 ? r.cap(1).trimmed() : QString::null; + const QString user = r.indexIn(userResponse.stdOut) != -1 ? r.cap(1).trimmed() : QString(); if (user.isEmpty()) - return QString::null; + return QString(); args.clear(); args << QLatin1String("changes") << QLatin1String("-s") << QLatin1String("pending") << QLatin1String("-u") << user; const PerforceResponse dataResponse = runP4Cmd(m_settings.topLevelSymLinkTarget(), args, RunFullySynchronous|CommandToWindow|StdErrToWindow|ErrorToWindow); - return dataResponse.error ? QString::null : dataResponse.stdOut; + return dataResponse.error ? QString() : dataResponse.stdOut; } PerforcePlugin::~PerforcePlugin() diff --git a/src/plugins/perforce/settingspage.cpp b/src/plugins/perforce/settingspage.cpp index 3981c621bf5a114bf98842c9283d2142c3aa87ee..e0d51a1a9bd03a0cb6bee951889ee053a329a8e2 100644 --- a/src/plugins/perforce/settingspage.cpp +++ b/src/plugins/perforce/settingspage.cpp @@ -101,7 +101,7 @@ void SettingsPageWidget::setSettings(const PerforceSettings &s) void SettingsPageWidget::setStatusText(const QString &t) { - m_ui.errorLabel->setStyleSheet(QString::null); + m_ui.errorLabel->setStyleSheet(QString()); m_ui.errorLabel->setText(t); } diff --git a/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp b/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp index f031a97cae088a7b6675244e7e34f98c5ec80506..3d71f14108c9970ac6ee948d76d3759cd9e6de82 100644 --- a/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp +++ b/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp @@ -398,7 +398,7 @@ QString CustomExecutableRunConfiguration::baseEnvironmentText() const } else if (m_baseEnvironmentBase == CustomExecutableRunConfiguration::BuildEnvironmentBase) { return tr("Build Environment"); } - return QString::null; + return QString(); } ProjectExplorer::Environment CustomExecutableRunConfiguration::baseEnvironment() const diff --git a/src/plugins/projectexplorer/debugginghelper.cpp b/src/plugins/projectexplorer/debugginghelper.cpp index 2cf802c41a12abd1c21cb2c0bda91d4611d01e96..2176532c80cb86f282aea5f7a714ec214b86b9f0 100644 --- a/src/plugins/projectexplorer/debugginghelper.cpp +++ b/src/plugins/projectexplorer/debugginghelper.cpp @@ -54,7 +54,7 @@ QString DebuggingHelperLibrary::findSystemQt(const Environment &env) } } } - return QString::null; + return QString(); } QStringList DebuggingHelperLibrary::debuggingHelperLibraryDirectories(const QString &qtInstallData) @@ -75,7 +75,7 @@ QString DebuggingHelperLibrary::qtInstallDataDir(const QString &qmakePath) proc.start(qmakePath, QStringList() << QLatin1String("-query") << QLatin1String("QT_INSTALL_DATA")); if (proc.waitForFinished()) return QString(proc.readAll().trimmed()); - return QString::null; + return QString(); } // Debugging Helper Library @@ -136,7 +136,7 @@ QString DebuggingHelperLibrary::buildDebuggingHelperLibrary(const QString &qmake const QString directory = copyDebuggingHelperLibrary(qtInstallDataDir(qmakePath), &errorMessage); if (directory.isEmpty()) return errorMessage; - return buildDebuggingHelperLibrary(directory, make, qmakePath, QString::null, env); + return buildDebuggingHelperLibrary(directory, make, qmakePath, QString(), env); } // Copy helper source files to a target directory, replacing older files. @@ -245,7 +245,7 @@ QString DebuggingHelperLibrary::qtVersionForQMake(const QString &qmakePath) QProcess qmake; qmake.start(qmakePath, QStringList(QLatin1String("--version"))); if (!qmake.waitForFinished()) - return QString::null; + return QString(); QString output = qmake.readAllStandardOutput(); QRegExp regexp(QLatin1String("(QMake version|QMake version:)[\\s]*([\\d.]*)"), Qt::CaseInsensitive); regexp.indexIn(output); diff --git a/src/plugins/projectexplorer/environment.cpp b/src/plugins/projectexplorer/environment.cpp index d307b8d55a3f053e86cfa9d1fa35e3739340fc0e..ac592254d723e400e72d4151ef190ffd8cb16323 100644 --- a/src/plugins/projectexplorer/environment.cpp +++ b/src/plugins/projectexplorer/environment.cpp @@ -183,7 +183,7 @@ QString Environment::searchInPath(QString executable) const { // qDebug()<<"looking for "<<executable<< "in PATH: "<<m_values.value("PATH"); if (executable.isEmpty()) - return QString::null; + return QString(); QFileInfo fi(executable); if (fi.isAbsolute() && fi.exists()) return executable; @@ -203,7 +203,7 @@ QString Environment::searchInPath(QString executable) const return fi.absoluteFilePath(); } } - return QString::null; + return QString(); } QStringList Environment::path() const diff --git a/src/plugins/projectexplorer/projectexplorer.cpp b/src/plugins/projectexplorer/projectexplorer.cpp index c61cd2512fbd62b81454e07e3d4c44a3374b4f34..de7b89d8a00015422fb4e95edbb1369e97f10248 100644 --- a/src/plugins/projectexplorer/projectexplorer.cpp +++ b/src/plugins/projectexplorer/projectexplorer.cpp @@ -1137,7 +1137,7 @@ void ProjectExplorerPlugin::determineSessionToRestoreAtStartup() // We have command line arguments, try to find a session in them QStringList arguments = ExtensionSystem::PluginManager::instance()->arguments(); // Default to no session loading - d->m_sessionToRestoreAtStartup = QString::null; + d->m_sessionToRestoreAtStartup.clear(); foreach (const QString &arg, arguments) { if (sessions.contains(arg)) { // Session argument @@ -1295,7 +1295,7 @@ void ProjectExplorerPlugin::buildQueueFinished(bool success) d->m_buildManager->showTaskWindow(); } d->m_delayedRunConfiguration = 0; - d->m_runMode = QString::null; + d->m_runMode.clear(); } void ProjectExplorerPlugin::setCurrent(Project *project, QString filePath, Node *node) @@ -1417,7 +1417,7 @@ bool ProjectExplorerPlugin::saveModifiedFiles() bool alwaysSave = false; Core::FileManager *fm = Core::ICore::instance()->fileManager(); - fm->saveModifiedFiles(filesToSave, &cancelled, QString::null, + fm->saveModifiedFiles(filesToSave, &cancelled, QString(), "Always save files before build", &alwaysSave); if (cancelled) diff --git a/src/plugins/qt4projectmanager/qt-maemo/maemorunconfiguration.cpp b/src/plugins/qt4projectmanager/qt-maemo/maemorunconfiguration.cpp index b570d4b1ceb4c1727a098d3f801aa96fa0638780..7b029adbd5a750886b2b8a01a29898ed0511b350 100644 --- a/src/plugins/qt4projectmanager/qt-maemo/maemorunconfiguration.cpp +++ b/src/plugins/qt4projectmanager/qt-maemo/maemorunconfiguration.cpp @@ -471,7 +471,7 @@ void MaemoRunConfiguration::updateTarget() if (m_cachedTargetInformationValid) return; - m_executable = QString::null; + m_executable.clear(); m_cachedTargetInformationValid = true; Qt4TargetInformation info = qt4Project()->targetInformation(qt4Project()->activeQt4BuildConfiguration(), diff --git a/src/plugins/qt4projectmanager/qt-maemo/maemoruncontrol.cpp b/src/plugins/qt4projectmanager/qt-maemo/maemoruncontrol.cpp index bac3026a13c82000a20d895dd6e932aecdb6f23c..37dc0db05e6bbe862e99150e77e17f8f990761fd 100644 --- a/src/plugins/qt4projectmanager/qt-maemo/maemoruncontrol.cpp +++ b/src/plugins/qt4projectmanager/qt-maemo/maemoruncontrol.cpp @@ -152,7 +152,8 @@ void AbstractMaemoRunControl::deploy() QStringList cmdArgs; cmdArgs << "-P" << sshPort() << options() << deployable.fileName - << (devConfig.uname + "@" + devConfig.host + ":" + remoteDir()); + << (devConfig.uname + QLatin1Char('@') + devConfig.host + + QLatin1Char(':') + remoteDir()); deployProcess.setWorkingDirectory(deployable.dir); deployProcess.start(runConfig->scpCmd(), cmdArgs); @@ -473,7 +474,7 @@ MaemoDebugRunControl::MaemoDebugRunControl(RunConfiguration *runConfiguration) startParams->startMode = Debugger::StartRemote; startParams->executable = executableOnHost(); startParams->remoteChannel - = devConfig.host + ":" + QString::number(devConfig.gdbServerPort); + = devConfig.host + QLatin1Char(':') + QString::number(devConfig.gdbServerPort); startParams->remoteArchitecture = "arm"; startParams->sysRoot = runConfig->sysRoot(); startParams->toolChainType = ToolChain::GCC_MAEMO; diff --git a/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp b/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp index 48254a66cdc88550a1387bf351a8b4b6858109a0..f75aafa3b2b0a8a3e655abe4b055d2985a01d9cb 100644 --- a/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp +++ b/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp @@ -345,10 +345,10 @@ void S60DeviceRunConfiguration::updateTarget() tr("Could not parse %1. The QtS60 Device run configuration %2 can not be started.") .arg(m_proFilePath).arg(displayName())); } - m_targetName = QString::null; - m_baseFileName = QString::null; - m_packageTemplateFileName = QString::null; - m_platform = QString::null; + m_targetName.clear(); + m_baseFileName.clear(); + m_packageTemplateFileName.clear(); + m_platform.clear(); m_cachedTargetInformationValid = true; emit targetInformationChanged(); return; diff --git a/src/plugins/qt4projectmanager/qt-s60/s60devices.cpp b/src/plugins/qt4projectmanager/qt-s60/s60devices.cpp index dda6a2265d05e5a0c30b061128ec47edf8e52849..40135181aef3234275e7b92bce9c7b4f037f7e6f 100644 --- a/src/plugins/qt4projectmanager/qt-s60/s60devices.cpp +++ b/src/plugins/qt4projectmanager/qt-s60/s60devices.cpp @@ -243,7 +243,7 @@ bool S60Devices::detectQtForDevices() continue; QFile qtDll(QString("%1/epoc32/release/winscw/udeb/QtCore.dll").arg(m_devices.at(i).epocRoot)); if (!qtDll.exists() || !qtDll.open(QIODevice::ReadOnly)) { - m_devices[i].qt = QString(); + m_devices[i].qt.clear(); continue; } QByteArray buffer; diff --git a/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.cpp b/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.cpp index c402f64f7882f71c91b07d60efa33c8f77f9dcf6..ea24942ef3bc51e4c41bc3ddf40997c933812139 100644 --- a/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.cpp +++ b/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.cpp @@ -167,7 +167,7 @@ void S60EmulatorRunConfiguration::updateTarget() tr("Could not parse %1. The Qt for Symbian emulator run configuration %2 can not be started.") .arg(m_proFilePath).arg(displayName())); } - m_executable = QString::null; + m_executable.clear(); m_cachedTargetInformationValid = true; emit targetInformationChanged(); return; diff --git a/src/plugins/qt4projectmanager/qt4buildconfiguration.cpp b/src/plugins/qt4projectmanager/qt4buildconfiguration.cpp index ca6e6e3b5492391b7bc4f8fb610567e3b9b522c9..056f24e8a15d7e654a0c1628dca30bf9d97861dc 100644 --- a/src/plugins/qt4projectmanager/qt4buildconfiguration.cpp +++ b/src/plugins/qt4projectmanager/qt4buildconfiguration.cpp @@ -139,11 +139,7 @@ Qt4Project *Qt4BuildConfiguration::qt4Project() const QString Qt4BuildConfiguration::baseEnvironmentText() const { - if (useSystemEnvironment()) - return tr("System Environment"); - else - return tr("Clean Environment"); - return QString::null; + return useSystemEnvironment() ? tr("System Environment") : tr("Clean Environment"); } ProjectExplorer::Environment Qt4BuildConfiguration::baseEnvironment() const @@ -270,7 +266,7 @@ QString Qt4BuildConfiguration::defaultMakeTarget() const { ToolChain *tc = toolChain(); if (!tc) - return QString::null; + return QString(); const QtVersion::QmakeBuildConfigs buildConfig = qmakeBuildConfiguration(); switch (tc->type()) { @@ -285,7 +281,7 @@ QString Qt4BuildConfiguration::defaultMakeTarget() const default: break; } - return QString::null; + return QString(); } QtVersion *Qt4BuildConfiguration::qtVersion() const diff --git a/src/plugins/qt4projectmanager/qt4nodes.cpp b/src/plugins/qt4projectmanager/qt4nodes.cpp index e5e1bc4656694552356de2792ed55b6485c58b2b..511ae593b5aab771879915cd0b7bc4ce66a2758c 100644 --- a/src/plugins/qt4projectmanager/qt4nodes.cpp +++ b/src/plugins/qt4projectmanager/qt4nodes.cpp @@ -101,12 +101,12 @@ QString Qt4PriFile::fileName() const QString Qt4PriFile::defaultPath() const { - return QString::null; + return QString(); } QString Qt4PriFile::suggestedFileName() const { - return QString::null; + return QString(); } QString Qt4PriFile::mimeType() const diff --git a/src/plugins/qt4projectmanager/qt4runconfiguration.cpp b/src/plugins/qt4projectmanager/qt4runconfiguration.cpp index 69af286b5a6f4e14cac9fe2da934c3521bf62f97..c96ad96a9b17b2b0513fe0405544eee528d4a888 100644 --- a/src/plugins/qt4projectmanager/qt4runconfiguration.cpp +++ b/src/plugins/qt4projectmanager/qt4runconfiguration.cpp @@ -518,7 +518,7 @@ QString Qt4RunConfiguration::baseEnvironmentText() const return tr("System Environment"); else if (m_baseEnvironmentBase == Qt4RunConfiguration::BuildEnvironmentBase) return tr("Build Environment"); - return QString::null; + return QString(); } ProjectExplorer::Environment Qt4RunConfiguration::baseEnvironment() const @@ -561,7 +561,7 @@ void Qt4RunConfiguration::setWorkingDirectory(const QString &wd) { if (wd.isEmpty()) { m_userSetWokingDirectory = false; - m_userWorkingDirectory = QString::null; + m_userWorkingDirectory.clear(); emit workingDirectoryChanged(workingDirectory()); } else { m_userSetWokingDirectory = true; @@ -610,8 +610,8 @@ void Qt4RunConfiguration::updateTarget() tr("Could not parse %1. The Qt4 run configuration %2 can not be started.") .arg(m_proFilePath).arg(displayName())); } - m_workingDir = QString::null; - m_executable = QString::null; + m_workingDir.clear(); + m_executable.clear(); m_cachedTargetInformationValid = true; emit effectiveTargetInformationChanged(); return; @@ -632,20 +632,16 @@ void Qt4RunConfiguration::invalidateCachedTargetInformation() QString Qt4RunConfiguration::dumperLibrary() const { - QtVersion *version = qt4Project()->activeQt4BuildConfiguration()->qtVersion(); - if (version) + if (const QtVersion *version = qt4Project()->activeQt4BuildConfiguration()->qtVersion()) return version->debuggingHelperLibrary(); - else - return QString::null; + return QString(); } QStringList Qt4RunConfiguration::dumperLibraryLocations() const { - QtVersion *version = qt4Project()->activeQt4BuildConfiguration()->qtVersion(); - if (version) + if (const QtVersion *version = qt4Project()->activeQt4BuildConfiguration()->qtVersion()) return version->debuggingHelperLibraryLocations(); - else - return QStringList(); + return QStringList(); } void Qt4RunConfiguration::setDefaultDisplayName() diff --git a/src/plugins/qt4projectmanager/qtversionmanager.cpp b/src/plugins/qt4projectmanager/qtversionmanager.cpp index 172c5166aa4c1546e0215495c2812c7ed3127c09..169919eccd22ada2e06817e0f2ab3f158275379a 100644 --- a/src/plugins/qt4projectmanager/qtversionmanager.cpp +++ b/src/plugins/qt4projectmanager/qtversionmanager.cpp @@ -559,8 +559,7 @@ QtVersion::QtVersion(const QString &qmakeCommand, bool isAutodetected, const QSt } QtVersion::QtVersion() - : m_displayName(QString::null), - m_id(-1), + : m_id(-1), m_isAutodetected(false), m_hasDebuggingHelper(false), m_toolChainUpToDate(false), @@ -572,7 +571,7 @@ QtVersion::QtVersion() m_hasDemos(false), m_hasDocumentation(false) { - setQMakeCommand(QString::null); + setQMakeCommand(QString()); } @@ -666,7 +665,9 @@ void QtVersion::setQMakeCommand(const QString& qmakeCommand) #ifdef Q_OS_WIN m_qmakeCommand = m_qmakeCommand.toLower(); #endif - m_designerCommand = m_linguistCommand = m_uicCommand = QString::null; + m_designerCommand.clear(); + m_linguistCommand.clear(); + m_uicCommand.clear(); m_toolChainUpToDate = false; // TODO do i need to optimize this? m_versionInfoUpToDate = false; @@ -676,7 +677,7 @@ void QtVersion::setQMakeCommand(const QString& qmakeCommand) if (qmake.exists() && qmake.isExecutable()) { m_qtVersionString = DebuggingHelperLibrary::qtVersionForQMake(qmake.absoluteFilePath()); } else { - m_qtVersionString = QString::null; + m_qtVersionString.clear(); } updateSourcePath(); } @@ -734,7 +735,7 @@ QString QtVersionManager::findQMakeBinaryFromMakefile(const QString &directory) } makefile.close(); } - return QString::null; + return QString(); } QtVersion *QtVersionManager::qtVersionForQMakeBinary(const QString &qmakePath) @@ -1037,13 +1038,13 @@ QString QtVersion::findQtBinary(const QStringList &possibleCommands) const if (QFileInfo(fullPath).isFile()) return QDir::cleanPath(fullPath); } - return QString::null; + return QString(); } QString QtVersion::uicCommand() const { if (!isValid()) - return QString::null; + return QString(); if (!m_uicCommand.isNull()) return m_uicCommand; #ifdef Q_OS_WIN @@ -1077,7 +1078,7 @@ static inline QStringList possibleGuiBinaries(const QString &name) QString QtVersion::designerCommand() const { if (!isValid()) - return QString::null; + return QString(); if (m_designerCommand.isNull()) m_designerCommand = findQtBinary(possibleGuiBinaries(QLatin1String("designer"))); return m_designerCommand; @@ -1086,7 +1087,7 @@ QString QtVersion::designerCommand() const QString QtVersion::linguistCommand() const { if (!isValid()) - return QString::null; + return QString(); if (m_linguistCommand.isNull()) m_linguistCommand = findQtBinary(possibleGuiBinaries(QLatin1String("linguist"))); return m_linguistCommand; @@ -1369,8 +1370,8 @@ bool QtVersion::isValid() const { updateVersionInfo(); return m_id != -1 - && qmakeCommand() != QString::null - && displayName() != QString::null + && !qmakeCommand().isEmpty() + && !displayName().isEmpty() && !m_notInstalled && m_versionInfo.contains("QT_INSTALL_BINS"); } @@ -1411,7 +1412,7 @@ QString QtVersion::debuggingHelperLibrary() const { QString qtInstallData = versionInfo().value("QT_INSTALL_DATA"); if (qtInstallData.isEmpty()) - return QString::null; + return QString(); return DebuggingHelperLibrary::debuggingHelperLibraryByInstallData(qtInstallData); } @@ -1484,7 +1485,7 @@ QString QtVersion::buildDebuggingHelperLibrary() { QString qtInstallData = versionInfo().value("QT_INSTALL_DATA"); if (qtInstallData.isEmpty()) - return QString::null; + return QString(); ProjectExplorer::Environment env = ProjectExplorer::Environment::systemEnvironment(); addToEnvironment(env); diff --git a/src/plugins/texteditor/icompletioncollector.cpp b/src/plugins/texteditor/icompletioncollector.cpp index dc5905c493ba148c68a2e401ee5482944065aa57..9db757a9e4929da76497cffb1dc05b925274d07a 100644 --- a/src/plugins/texteditor/icompletioncollector.cpp +++ b/src/plugins/texteditor/icompletioncollector.cpp @@ -139,7 +139,7 @@ void ICompletionCollector::filter(const QList<TextEditor::CompletionItem> &items if (c.isUpper() && !first) keyRegExp += wordContinuation; keyRegExp += QRegExp::escape(c.toUpper()); - keyRegExp += "|"; + keyRegExp += QLatin1Char('|'); keyRegExp += QRegExp::escape(c.toLower()); keyRegExp += QLatin1Char(')'); } else {