From 821a2ad665bfb4bcc02a1ed77003b4fba3343a20 Mon Sep 17 00:00:00 2001
From: Nikolai Kosjar <nikolai.kosjar@qt.io>
Date: Thu, 1 Jun 2017 13:34:08 +0200
Subject: [PATCH] Clang: Fix uninitialized values warnings

...from coverity scan.

Change-Id: Id669dd5de9a92bfec76e1aff3b8462caf9baa968
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
---
 src/libs/clangbackendipc/cmbcompletecodemessage.h           | 2 +-
 src/libs/clangbackendipc/diagnosticcontainer.h              | 2 +-
 .../dynamicastmatcherdiagnosticcontextcontainer.h           | 2 +-
 src/libs/clangbackendipc/filecontainer.h                    | 2 +-
 src/libs/clangbackendipc/highlightingmarkcontainer.h        | 6 +++---
 src/libs/clangbackendipc/sourcelocationcontainer.h          | 4 ++--
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/libs/clangbackendipc/cmbcompletecodemessage.h b/src/libs/clangbackendipc/cmbcompletecodemessage.h
index 88036da252..e7c3dc58fe 100644
--- a/src/libs/clangbackendipc/cmbcompletecodemessage.h
+++ b/src/libs/clangbackendipc/cmbcompletecodemessage.h
@@ -113,7 +113,7 @@ private:
     Utf8String filePath_;
     Utf8String projectPartId_;
     static CMBIPC_EXPORT quint64 ticketCounter;
-    quint64 ticketNumber_;
+    quint64 ticketNumber_ = 0;
     quint32 line_ = 0;
     quint32 column_ = 0;
 };
diff --git a/src/libs/clangbackendipc/diagnosticcontainer.h b/src/libs/clangbackendipc/diagnosticcontainer.h
index 677fb813d5..7645f41876 100644
--- a/src/libs/clangbackendipc/diagnosticcontainer.h
+++ b/src/libs/clangbackendipc/diagnosticcontainer.h
@@ -158,7 +158,7 @@ private:
     Utf8String disableOption_;
     QVector<DiagnosticContainer> children_;
     QVector<FixItContainer> fixIts_;
-    DiagnosticSeverity severity_;
+    DiagnosticSeverity severity_ = DiagnosticSeverity::Ignored;
 };
 
 CMBIPC_EXPORT QDebug operator<<(QDebug debug, const DiagnosticContainer &container);
diff --git a/src/libs/clangbackendipc/dynamicastmatcherdiagnosticcontextcontainer.h b/src/libs/clangbackendipc/dynamicastmatcherdiagnosticcontextcontainer.h
index cc55514396..3dbe959e67 100644
--- a/src/libs/clangbackendipc/dynamicastmatcherdiagnosticcontextcontainer.h
+++ b/src/libs/clangbackendipc/dynamicastmatcherdiagnosticcontextcontainer.h
@@ -101,7 +101,7 @@ public:
 
 private:
     V2::SourceRangeContainer sourceRange_;
-    ClangQueryDiagnosticContextType contextType_;
+    ClangQueryDiagnosticContextType contextType_ = ClangQueryDiagnosticContextType::MatcherArg;
     Utils::SmallStringVector arguments_;
 };
 
diff --git a/src/libs/clangbackendipc/filecontainer.h b/src/libs/clangbackendipc/filecontainer.h
index 054f37bf26..1c9247adc2 100644
--- a/src/libs/clangbackendipc/filecontainer.h
+++ b/src/libs/clangbackendipc/filecontainer.h
@@ -142,7 +142,7 @@ private:
     Utf8String projectPartId_;
     Utf8StringVector fileArguments_;
     Utf8String unsavedFileContent_;
-    quint32 documentRevision_;
+    quint32 documentRevision_ = 0;
     bool hasUnsavedFileContent_ = false;
 };
 
diff --git a/src/libs/clangbackendipc/highlightingmarkcontainer.h b/src/libs/clangbackendipc/highlightingmarkcontainer.h
index 7ad2dcf919..d70f36dce4 100644
--- a/src/libs/clangbackendipc/highlightingmarkcontainer.h
+++ b/src/libs/clangbackendipc/highlightingmarkcontainer.h
@@ -109,9 +109,9 @@ public:
     }
 
 private:
-    uint line_;
-    uint column_;
-    uint length_;
+    uint line_ = 0;
+    uint column_ = 0;
+    uint length_ = 0;
     HighlightingTypes types_;
 };
 
diff --git a/src/libs/clangbackendipc/sourcelocationcontainer.h b/src/libs/clangbackendipc/sourcelocationcontainer.h
index 83810cb8ac..bcad2d79f4 100644
--- a/src/libs/clangbackendipc/sourcelocationcontainer.h
+++ b/src/libs/clangbackendipc/sourcelocationcontainer.h
@@ -49,8 +49,8 @@ public:
 
 private:
     Utf8String filePath_;
-    uint line_;
-    uint column_;
+    uint line_ = 0;
+    uint column_ = 0;
 };
 
 CMBIPC_EXPORT QDataStream &operator<<(QDataStream &out, const SourceLocationContainer &container);
-- 
GitLab