Dark theme: Light icons for build step actions

For a dark background we need light icons.

Change-Id: I86714598be70bff981f94fb6c4e4afd6acfbe96a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

share/qtcreator/themes/dark.creatortheme

@@ -149,6 +149,10 @@ IconOverlayPri=:/qtsupport/images/dark_qt_project.png
 IconOverlayPro=:/qtsupport/images/dark_qt_project.png
 StandardPixmapFileIcon=:/core/images/dark_fileicon.png
 StandardPixmapDirIcon=:/core/images/dark_foldericon.png
+BuildStepDisable=:/projectexplorer/images/lightdisabledbuildstep.png
+BuildStepRemove=:/core/images/lightclose.png
+BuildStepMoveDown=:/core/images/lightarrowdown.png
+BuildStepMoveUp=:/core/images/lightarrowup.png
 
 [Style]
 WidgetStyle=StyleFlat

src/libs/utils/theme/theme.h

@@ -204,7 +204,11 @@ public:
         IconOverlayPrf,
         IconOverlayPro,
         StandardPixmapFileIcon,
-        StandardPixmapDirIcon
+        StandardPixmapDirIcon,
+        BuildStepDisable,
+        BuildStepRemove,
+        BuildStepMoveDown,
+        BuildStepMoveUp
     };
 
     enum Flag {

src/plugins/coreplugin/core.qrc

@@ -74,6 +74,12 @@
         <file>images/darkarrowup@2x.png</file>
         <file>images/darkclose.png</file>
         <file>images/darkclose@2x.png</file>
+        <file>images/lightarrowdown.png</file>
+        <file>images/lightarrowdown@2x.png</file>
+        <file>images/lightarrowup.png</file>
+        <file>images/lightarrowup@2x.png</file>
+        <file>images/lightclose.png</file>
+        <file>images/lightclose@2x.png</file>
         <file>images/arrowdown.png</file>
         <file>images/arrowdown@2x.png</file>
         <file>images/arrowup.png</file>

src/plugins/projectexplorer/buildstepspage.cpp

@@ -40,6 +40,7 @@
 #include <utils/qtcassert.h>
 #include <utils/detailswidget.h>
 #include <utils/hostosinfo.h>
+#include <utils/theme/theme.h>
 
 #include <QSignalMapper>
 
@@ -74,7 +75,8 @@ ToolWidget::ToolWidget(QWidget *parent)
     m_disableButton->setAutoRaise(true);
     m_disableButton->setToolTip(BuildStepListWidget::tr("Disable"));
     m_disableButton->setFixedSize(buttonSize);
-    m_disableButton->setIcon(QIcon(QLatin1String(":/projectexplorer/images/disabledbuildstep.png")));
+    m_disableButton->setIcon(QIcon(creatorTheme()->imageFile(Theme::BuildStepDisable,
+            QLatin1String(":/projectexplorer/images/disabledbuildstep.png"))));
     m_disableButton->setCheckable(true);
     hbox->addWidget(m_disableButton);
     layout->addWidget(m_firstWidget);
@@ -90,21 +92,24 @@ ToolWidget::ToolWidget(QWidget *parent)
     m_upButton->setAutoRaise(true);
     m_upButton->setToolTip(BuildStepListWidget::tr("Move Up"));
     m_upButton->setFixedSize(buttonSize);
-    m_upButton->setIcon(QIcon(QLatin1String(":/core/images/darkarrowup.png")));
+    m_upButton->setIcon(QIcon(creatorTheme()->imageFile(Theme::BuildStepMoveUp,
+            QLatin1String(":/core/images/darkarrowup.png"))));
     hbox->addWidget(m_upButton);
 
     m_downButton = new QToolButton(m_secondWidget);
     m_downButton->setAutoRaise(true);
     m_downButton->setToolTip(BuildStepListWidget::tr("Move Down"));
     m_downButton->setFixedSize(buttonSize);
-    m_downButton->setIcon(QIcon(QLatin1String(":/core/images/darkarrowdown.png")));
+    m_downButton->setIcon(QIcon(creatorTheme()->imageFile(Theme::BuildStepMoveDown,
+            QLatin1String(":/core/images/darkarrowdown.png"))));
     hbox->addWidget(m_downButton);
 
     m_removeButton  = new QToolButton(m_secondWidget);
     m_removeButton->setAutoRaise(true);
     m_removeButton->setToolTip(BuildStepListWidget::tr("Remove Item"));
     m_removeButton->setFixedSize(buttonSize);
-    m_removeButton->setIcon(QIcon(QLatin1String(Core::Constants::ICON_DARK_CLOSE)));
+    m_removeButton->setIcon(QIcon(creatorTheme()->imageFile(Theme::BuildStepRemove,
+            QLatin1String(Core::Constants::ICON_DARK_CLOSE))));
     hbox->addWidget(m_removeButton);
 
     layout->addWidget(m_secondWidget);

src/plugins/projectexplorer/projectexplorer.qrc

@@ -43,6 +43,8 @@
         <file>images/stop_small.png</file>
         <file>images/disabledbuildstep.png</file>
         <file>images/disabledbuildstep@2x.png</file>
+        <file>images/lightdisabledbuildstep.png</file>
+        <file>images/lightdisabledbuildstep@2x.png</file>
         <file>images/unconfigured.png</file>
         <file>images/targetleftbutton.png</file>
         <file>images/targetrightbutton.png</file>

src/tools/icons/qtcreatoricons.svg

@@ -663,6 +663,37 @@
        y1="595.09448"
        x2="28.495188"
        y2="598.53198" />
+    <filter
+       id="lightenUp"
+       x="0"
+       y="0"
+       width="1"
+       height="1"
+       inkscape:label="lighten up"
+       inkscape:menu="Color"
+       inkscape:menu-tooltip="Increase or decrease lightness and contrast"
+       color-interpolation-filters="sRGB">
+      <feFlood
+         id="feFlood3736"
+         result="result1"
+         flood-opacity="0.65000000000000002"
+         flood-color="rgb(255,255,255)" />
+      <feBlend
+         id="feBlend3738"
+         in2="SourceGraphic"
+         mode="normal"
+         result="result2" />
+      <feComposite
+         id="feComposite3740"
+         in2="SourceGraphic"
+         k2="1"
+         operator="arithmetic"
+         result="result3" />
+      <feComposite
+         id="feComposite3742"
+         in2="SourceGraphic"
+         operator="in" />
+    </filter>
   </defs>
   <sodipodi:namedview
      id="base"
@@ -1946,6 +1977,42 @@
          d="m 52,564 c 8,-8 8,-8 8,-8"
          style="fill:none;stroke:#505050;stroke-width:1.42;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none" />
     </g>
+    <use
+       x="0"
+       y="0"
+       xlink:href="#src/plugins/coreplugin/images/darkarrowdown"
+       id="src/plugins/coreplugin/images/lightarrowdown"
+       transform="translate(64,0)"
+       width="800"
+       height="600"
+       style="filter:url(#lightenUp)" />
+    <use
+       x="0"
+       y="0"
+       xlink:href="#src/plugins/coreplugin/images/darkarrowup"
+       id="src/plugins/coreplugin/images/lightarrowup"
+       transform="translate(64,0)"
+       width="800"
+       height="600"
+       style="filter:url(#lightenUp)" />
+    <use
+       x="0"
+       y="0"
+       xlink:href="#src/plugins/coreplugin/images/darkclose"
+       id="src/plugins/coreplugin/images/lightclose"
+       transform="translate(64,0)"
+       width="800"
+       height="600"
+       style="filter:url(#lightenUp)" />
+    <use
+       x="0"
+       y="0"
+       xlink:href="#src/plugins/projectexplorer/images/disabledbuildstep"
+       id="src/plugins/projectexplorer/images/lightdisabledbuildstep"
+       transform="translate(64,0)"
+       width="800"
+       height="600"
+       style="filter:url(#lightenUp)" />
   </g>
   <g
      inkscape:groupmode="layer"