diff --git a/doc/coding-style.qdoc b/doc/coding-style.qdoc index 3e20915745533f7622eb815d3baf27c54ed23d15..c2e886c85b3fb355e5b568cc741672f63725598d 100644 --- a/doc/coding-style.qdoc +++ b/doc/coding-style.qdoc @@ -108,6 +108,34 @@ in C++. \endcode +\o Using Qt's foreach is ok in non-time critical code when using a QTL + container. It is a nice way to keep line noise down and to give the + loop variable a proper name: + +\code + foreach (QWidget *widget, container) + doSomething(widget); + + -VS- + + Container::iterator end = container.end(); + for (Container::iterator it = container.begin(); it != end; ++it) + doSomething(*it); +\endcode + + If the loop variable can be made const, do so. This can prevent + unnecessary detaching of shared data in some cases. So: + +\code + foreach (const QString &name, someListOfNames) + doSomething(name); + + - NOT - + + foreach (QString name, someListOfNames) + doSomething(name); +\endcode + \section1 Formatting