From 94747f578b16feb178fd14b8962671d0f2616dc8 Mon Sep 17 00:00:00 2001
From: Tommi Asp <tommi@mowhi.com>
Date: Fri, 3 Feb 2012 16:09:44 +0200
Subject: [PATCH] C++: Fix while-loop from CppEditorWidget
Caused while to run forever when not checking
cursor.movePosition() return value.
Change-Id: Ie8211a477ab1889d4583d3b01e1a200d9905fd6d
Reviewed-by: Leandro Melo <leandro.melo@nokia.com>
---
src/plugins/cppeditor/cppeditor.cpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/plugins/cppeditor/cppeditor.cpp b/src/plugins/cppeditor/cppeditor.cpp
index 235360fe0ce..321ac4de295 100644
--- a/src/plugins/cppeditor/cppeditor.cpp
+++ b/src/plugins/cppeditor/cppeditor.cpp
@@ -2303,8 +2303,9 @@ bool CPPEditorWidget::handleDocumentationComment(QKeyEvent *e)
doxygen.setStyle(CppTools::DoxygenGenerator::JavaStyle);
// Move until we reach any possibly meaningful content.
- while (document()->characterAt(cursor.position()).isSpace())
- cursor.movePosition(QTextCursor::NextCharacter);
+ while (document()->characterAt(cursor.position()).isSpace()
+ && cursor.movePosition(QTextCursor::NextCharacter)) {
+ }
const QString &comment = doxygen.generate(cursor);
if (!comment.isEmpty()) {
--
GitLab