From 988ec82bb54d74a78c2f3d73f7ea2a54cdf329f2 Mon Sep 17 00:00:00 2001
From: Roberto Raggi <roberto.raggi@nokia.com>
Date: Mon, 7 Dec 2009 15:08:00 +0100
Subject: [PATCH] Check for unnecessary semicolons after function definitions.
---
src/shared/cplusplus/CheckSpecifier.cpp | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/shared/cplusplus/CheckSpecifier.cpp b/src/shared/cplusplus/CheckSpecifier.cpp
index 03b2d53d97d..5b32762c69d 100644
--- a/src/shared/cplusplus/CheckSpecifier.cpp
+++ b/src/shared/cplusplus/CheckSpecifier.cpp
@@ -347,8 +347,17 @@ bool CheckSpecifier::visit(ClassSpecifierAST *ast)
int previousVisibility = semantic()->switchVisibility(visibility);
int previousMethodKey = semantic()->switchMethodKey(Function::NormalMethod);
- for (DeclarationListAST *member = ast->member_specifier_list; member; member = member->next) {
- semantic()->check(member->value, klass->members());
+ DeclarationAST *previousDeclaration = 0;
+ for (DeclarationListAST *it = ast->member_specifier_list; it; it = it->next) {
+ DeclarationAST *declaration = it->value;
+ semantic()->check(declaration, klass->members());
+
+ if (previousDeclaration && declaration &&
+ declaration->asEmptyDeclaration() != 0 &&
+ previousDeclaration->asFunctionDefinition() != 0)
+ translationUnit()->warning(declaration->firstToken(), "unnecessary semicolon after function body");
+
+ previousDeclaration = declaration;
}
(void) semantic()->switchMethodKey(previousMethodKey);
--
GitLab