From 9943ec7d0fc14e9c67206c5504fd6ba88d21c0cb Mon Sep 17 00:00:00 2001 From: kh <qtc-committer@nokia.com> Date: Mon, 25 May 2009 18:21:31 +0200 Subject: [PATCH] Fix crash on shutdown. The onModeChanged gets always called, even after shutdown where we already had deleted the DebuggerManager. Don't access the 0 pointer. --- src/plugins/debugger/debuggerplugin.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/plugins/debugger/debuggerplugin.cpp b/src/plugins/debugger/debuggerplugin.cpp index 09f61b81e4b..6ca88c951fa 100644 --- a/src/plugins/debugger/debuggerplugin.cpp +++ b/src/plugins/debugger/debuggerplugin.cpp @@ -1150,11 +1150,17 @@ void DebuggerPlugin::readSettings() void DebuggerPlugin::onModeChanged(IMode *mode) { + // FIXME: This one gets always called, even if switching between modes + // different then the debugger mode. E.g. Welcome and Help mode and + // also on shutdown. + if (mode != m_debugMode) { - m_manager->modeVisibilityChanged(false); + if (m_manager) + m_manager->modeVisibilityChanged(false); return; } - m_manager->modeVisibilityChanged(true); + if (m_manager) + m_manager->modeVisibilityChanged(true); EditorManager *editorManager = EditorManager::instance(); -- GitLab