Commit a31eae4d authored by Marco Bubke's avatar Marco Bubke Committed by Tim Jenssen

Clang: Add clang query pane

We now support highlighting for an example text and for the query.

Change-Id: I88c415ff871cf3e4c2d4fc83d60a8555bf0ce08a
Reviewed-by: Tim Jenssen's avatarTim Jenssen <tim.jenssen@qt.io>
parent 8c4127eb
...@@ -79,7 +79,9 @@ SOURCES += $$PWD/clangcodemodelserverinterface.cpp \ ...@@ -79,7 +79,9 @@ SOURCES += $$PWD/clangcodemodelserverinterface.cpp \
$$PWD/pchmanagerclientproxy.cpp \ $$PWD/pchmanagerclientproxy.cpp \
$$PWD/projectpartpch.cpp \ $$PWD/projectpartpch.cpp \
$$PWD/precompiledheadersupdatedmessage.cpp \ $$PWD/precompiledheadersupdatedmessage.cpp \
$$PWD/removepchprojectpartsmessage.cpp $$PWD/removepchprojectpartsmessage.cpp \
$$PWD/sourcerangesforquerymessage.cpp \
$$PWD/requestsourcerangesforquerymessage.cpp
HEADERS += \ HEADERS += \
$$PWD/clangcodemodelserverinterface.h \ $$PWD/clangcodemodelserverinterface.h \
...@@ -159,5 +161,10 @@ HEADERS += \ ...@@ -159,5 +161,10 @@ HEADERS += \
$$PWD/removepchprojectpartsmessage.h \ $$PWD/removepchprojectpartsmessage.h \
$$PWD/clangcodemodelclientmessages.h \ $$PWD/clangcodemodelclientmessages.h \
$$PWD/clangcodemodelservermessages.h \ $$PWD/clangcodemodelservermessages.h \
$$PWD/sourcerangesforquerymessage.h \
$$PWD/clangrefactoringmessages.h \
$$PWD/clangrefactoringclientmessages.h \
$$PWD/clangrefactoringservermessages.h \
$$PWD/requestsourcerangesforquerymessage.h
contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
...@@ -128,7 +128,9 @@ enum class MessageType : quint8 { ...@@ -128,7 +128,9 @@ enum class MessageType : quint8 {
RequestSourceLocationsForRenamingMessage, RequestSourceLocationsForRenamingMessage,
RequestSourceRangesAndDiagnosticsForQueryMessage, RequestSourceRangesAndDiagnosticsForQueryMessage,
RequestSourceRangesForQueryMessage,
SourceRangesAndDiagnosticsForQueryMessage, SourceRangesAndDiagnosticsForQueryMessage,
SourceRangesForQueryMessage,
CancelMessage, CancelMessage,
UpdatePchProjectPartsMessage, UpdatePchProjectPartsMessage,
......
/****************************************************************************
**
** Copyright (C) 2017 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#pragma once
#include "sourcelocationsforrenamingmessage.h"
#include "sourcerangesanddiagnosticsforquerymessage.h"
#include "sourcerangesforquerymessage.h"
#include "cmbalivemessage.h"
/****************************************************************************
**
** Copyright (C) 2017 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#pragma once
#include "clangrefactoringclientmessages.h"
#include "clangrefactoringservermessages.h"
/****************************************************************************
**
** Copyright (C) 2017 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#pragma once
#include "cancelmessage.h"
#include "cmbendmessage.h"
#include "requestsourcelocationforrenamingmessage.h"
#include "requestsourcerangesanddiagnosticsforquerymessage.h"
#include "requestsourcerangesforquerymessage.h"
...@@ -34,19 +34,19 @@ class DynamicASTMatcherDiagnosticContainer ...@@ -34,19 +34,19 @@ class DynamicASTMatcherDiagnosticContainer
{ {
public: public:
DynamicASTMatcherDiagnosticContainer() = default; DynamicASTMatcherDiagnosticContainer() = default;
DynamicASTMatcherDiagnosticContainer(std::vector<DynamicASTMatcherDiagnosticMessageContainer> &&messages, DynamicASTMatcherDiagnosticContainer(DynamicASTMatcherDiagnosticMessageContainers &&messages,
std::vector<DynamicASTMatcherDiagnosticContextContainer> &&contexts) DynamicASTMatcherDiagnosticContextContainers &&contexts)
: m_messages(std::move(messages)), : m_messages(std::move(messages)),
m_contexts(std::move(contexts)) m_contexts(std::move(contexts))
{ {
} }
const std::vector<DynamicASTMatcherDiagnosticMessageContainer> &messages() const const DynamicASTMatcherDiagnosticMessageContainers &messages() const
{ {
return m_messages; return m_messages;
} }
const std::vector<DynamicASTMatcherDiagnosticContextContainer> &contexts() const const DynamicASTMatcherDiagnosticContextContainers &contexts() const
{ {
return m_contexts; return m_contexts;
} }
...@@ -88,15 +88,16 @@ public: ...@@ -88,15 +88,16 @@ public:
DynamicASTMatcherDiagnosticContainer clone() const DynamicASTMatcherDiagnosticContainer clone() const
{ {
return DynamicASTMatcherDiagnosticContainer(Utils::clone(m_messages), return *this;
Utils::clone(m_contexts));
} }
private: private:
std::vector<DynamicASTMatcherDiagnosticMessageContainer> m_messages; DynamicASTMatcherDiagnosticMessageContainers m_messages;
std::vector<DynamicASTMatcherDiagnosticContextContainer> m_contexts; DynamicASTMatcherDiagnosticContextContainers m_contexts;
}; };
using DynamicASTMatcherDiagnosticContainers = std::vector<DynamicASTMatcherDiagnosticContainer>;
CMBIPC_EXPORT QDebug operator<<(QDebug debug, const DynamicASTMatcherDiagnosticContainer &container); CMBIPC_EXPORT QDebug operator<<(QDebug debug, const DynamicASTMatcherDiagnosticContainer &container);
std::ostream &operator<<(std::ostream &os, const DynamicASTMatcherDiagnosticContainer &container); std::ostream &operator<<(std::ostream &os, const DynamicASTMatcherDiagnosticContainer &container);
......
...@@ -105,6 +105,8 @@ private: ...@@ -105,6 +105,8 @@ private:
Utils::SmallStringVector m_arguments; Utils::SmallStringVector m_arguments;
}; };
using DynamicASTMatcherDiagnosticContextContainers = std::vector<DynamicASTMatcherDiagnosticContextContainer>;
CMBIPC_EXPORT QDebug operator<<(QDebug debug, const DynamicASTMatcherDiagnosticContextContainer &container); CMBIPC_EXPORT QDebug operator<<(QDebug debug, const DynamicASTMatcherDiagnosticContextContainer &container);
std::ostream &operator<<(std::ostream &os, const DynamicASTMatcherDiagnosticContextContainer &container); std::ostream &operator<<(std::ostream &os, const DynamicASTMatcherDiagnosticContextContainer &container);
......
...@@ -105,6 +105,8 @@ private: ...@@ -105,6 +105,8 @@ private:
Utils::SmallStringVector m_arguments; Utils::SmallStringVector m_arguments;
}; };
using DynamicASTMatcherDiagnosticMessageContainers = std::vector<DynamicASTMatcherDiagnosticMessageContainer>;
CMBIPC_EXPORT QDebug operator<<(QDebug debug, const DynamicASTMatcherDiagnosticMessageContainer &container); CMBIPC_EXPORT QDebug operator<<(QDebug debug, const DynamicASTMatcherDiagnosticMessageContainer &container);
std::ostream &operator<<(std::ostream &os, const DynamicASTMatcherDiagnosticMessageContainer &container); std::ostream &operator<<(std::ostream &os, const DynamicASTMatcherDiagnosticMessageContainer &container);
......
...@@ -86,13 +86,19 @@ public: ...@@ -86,13 +86,19 @@ public:
friend QDataStream &operator<<(QDataStream &out, const FilePath &filePath) friend QDataStream &operator<<(QDataStream &out, const FilePath &filePath)
{ {
out << filePath.m_path; out << filePath.m_path;
out << uint(filePath.m_slashIndex);
return out; return out;
} }
friend QDataStream &operator>>(QDataStream &in, FilePath &filePath) friend QDataStream &operator>>(QDataStream &in, FilePath &filePath)
{ {
uint slashIndex;
in >> filePath.m_path; in >> filePath.m_path;
in >> slashIndex;
filePath.m_slashIndex = slashIndex;
return in; return in;
} }
...@@ -116,7 +122,7 @@ public: ...@@ -116,7 +122,7 @@ public:
FilePath clone() const FilePath clone() const
{ {
return FilePath(m_path.clone(), m_slashIndex); return *this;
} }
private: private:
......
...@@ -26,8 +26,7 @@ ...@@ -26,8 +26,7 @@
#include "refactoringclientinterface.h" #include "refactoringclientinterface.h"
#include "messageenvelop.h" #include "messageenvelop.h"
#include "sourcelocationsforrenamingmessage.h" #include "clangrefactoringclientmessages.h"
#include "sourcerangesanddiagnosticsforquerymessage.h"
#include <QDebug> #include <QDebug>
...@@ -45,6 +44,9 @@ void RefactoringClientInterface::dispatch(const MessageEnvelop &messageEnvelop) ...@@ -45,6 +44,9 @@ void RefactoringClientInterface::dispatch(const MessageEnvelop &messageEnvelop)
case MessageType::SourceRangesAndDiagnosticsForQueryMessage: case MessageType::SourceRangesAndDiagnosticsForQueryMessage:
sourceRangesAndDiagnosticsForQueryMessage(messageEnvelop.message<SourceRangesAndDiagnosticsForQueryMessage>()); sourceRangesAndDiagnosticsForQueryMessage(messageEnvelop.message<SourceRangesAndDiagnosticsForQueryMessage>());
break; break;
case MessageType::SourceRangesForQueryMessage:
sourceRangesForQueryMessage(messageEnvelop.message<SourceRangesForQueryMessage>());
break;
default: default:
qWarning() << "Unknown IpcClientMessage"; qWarning() << "Unknown IpcClientMessage";
} }
......
...@@ -33,6 +33,7 @@ namespace ClangBackEnd { ...@@ -33,6 +33,7 @@ namespace ClangBackEnd {
class SourceLocationsForRenamingMessage; class SourceLocationsForRenamingMessage;
class SourceRangesAndDiagnosticsForQueryMessage; class SourceRangesAndDiagnosticsForQueryMessage;
class SourceRangesForQueryMessage;
class SourceLocationsContainer; class SourceLocationsContainer;
class CMBIPC_EXPORT RefactoringClientInterface : public IpcClientInterface class CMBIPC_EXPORT RefactoringClientInterface : public IpcClientInterface
...@@ -47,6 +48,7 @@ public: ...@@ -47,6 +48,7 @@ public:
virtual void alive() = 0; virtual void alive() = 0;
virtual void sourceLocationsForRenamingMessage(SourceLocationsForRenamingMessage &&message) = 0; virtual void sourceLocationsForRenamingMessage(SourceLocationsForRenamingMessage &&message) = 0;
virtual void sourceRangesAndDiagnosticsForQueryMessage(SourceRangesAndDiagnosticsForQueryMessage &&message) = 0; virtual void sourceRangesAndDiagnosticsForQueryMessage(SourceRangesAndDiagnosticsForQueryMessage &&message) = 0;
virtual void sourceRangesForQueryMessage(SourceRangesForQueryMessage &&message) = 0;
virtual void setLocalRenamingCallback(RenameCallback &&localRenamingCallback) = 0; virtual void setLocalRenamingCallback(RenameCallback &&localRenamingCallback) = 0;
}; };
......
...@@ -28,8 +28,7 @@ ...@@ -28,8 +28,7 @@
#include "cmbalivemessage.h" #include "cmbalivemessage.h"
#include "messageenvelop.h" #include "messageenvelop.h"
#include "refactoringserverinterface.h" #include "refactoringserverinterface.h"
#include "sourcelocationsforrenamingmessage.h" #include "clangrefactoringclientmessages.h"
#include "sourcerangesanddiagnosticsforquerymessage.h"
#include <QDebug> #include <QDebug>
#include <QIODevice> #include <QIODevice>
...@@ -85,4 +84,9 @@ void RefactoringClientProxy::sourceRangesAndDiagnosticsForQueryMessage(SourceRan ...@@ -85,4 +84,9 @@ void RefactoringClientProxy::sourceRangesAndDiagnosticsForQueryMessage(SourceRan
writeMessageBlock.write(message); writeMessageBlock.write(message);
} }
void RefactoringClientProxy::sourceRangesForQueryMessage(SourceRangesForQueryMessage &&message)
{
writeMessageBlock.write(message);
}
} // namespace ClangBackEnd } // namespace ClangBackEnd
...@@ -51,6 +51,7 @@ public: ...@@ -51,6 +51,7 @@ public:
void alive() override; void alive() override;
void sourceLocationsForRenamingMessage(SourceLocationsForRenamingMessage &&message) override; void sourceLocationsForRenamingMessage(SourceLocationsForRenamingMessage &&message) override;
void sourceRangesAndDiagnosticsForQueryMessage(SourceRangesAndDiagnosticsForQueryMessage &&message) override; void sourceRangesAndDiagnosticsForQueryMessage(SourceRangesAndDiagnosticsForQueryMessage &&message) override;
void sourceRangesForQueryMessage(SourceRangesForQueryMessage &&message) override;
void setLocalRenamingCallback(RenameCallback &&) final {} void setLocalRenamingCallback(RenameCallback &&) final {}
......
...@@ -26,9 +26,7 @@ ...@@ -26,9 +26,7 @@
#include "refactoringserverinterface.h" #include "refactoringserverinterface.h"
#include "messageenvelop.h" #include "messageenvelop.h"
#include "requestsourcelocationforrenamingmessage.h" #include "clangrefactoringservermessages.h"
#include "requestsourcerangesanddiagnosticsforquerymessage.h"
#include "cancelmessage.h"
#include <QDebug> #include <QDebug>
...@@ -46,6 +44,9 @@ void RefactoringServerInterface::dispatch(const MessageEnvelop &messageEnvelop) ...@@ -46,6 +44,9 @@ void RefactoringServerInterface::dispatch(const MessageEnvelop &messageEnvelop)
case MessageType::RequestSourceRangesAndDiagnosticsForQueryMessage: case MessageType::RequestSourceRangesAndDiagnosticsForQueryMessage:
requestSourceRangesAndDiagnosticsForQueryMessage(messageEnvelop.message<RequestSourceRangesAndDiagnosticsForQueryMessage>()); requestSourceRangesAndDiagnosticsForQueryMessage(messageEnvelop.message<RequestSourceRangesAndDiagnosticsForQueryMessage>());
break; break;
case MessageType::RequestSourceRangesForQueryMessage:
requestSourceRangesForQueryMessage(messageEnvelop.message<RequestSourceRangesForQueryMessage>());
break;
case MessageType::CancelMessage: case MessageType::CancelMessage:
cancel(); cancel();
break; break;
......
...@@ -34,6 +34,7 @@ namespace ClangBackEnd { ...@@ -34,6 +34,7 @@ namespace ClangBackEnd {
class RefactoringClientInterface; class RefactoringClientInterface;
class RequestSourceLocationsForRenamingMessage; class RequestSourceLocationsForRenamingMessage;
class RequestSourceRangesAndDiagnosticsForQueryMessage; class RequestSourceRangesAndDiagnosticsForQueryMessage;
class RequestSourceRangesForQueryMessage;
class CancelMessage; class CancelMessage;
class CMBIPC_EXPORT RefactoringServerInterface : public IpcServerInterface<RefactoringClientInterface> class CMBIPC_EXPORT RefactoringServerInterface : public IpcServerInterface<RefactoringClientInterface>
...@@ -44,6 +45,7 @@ public: ...@@ -44,6 +45,7 @@ public:
virtual void end() = 0; virtual void end() = 0;
virtual void requestSourceLocationsForRenamingMessage(RequestSourceLocationsForRenamingMessage &&message) = 0; virtual void requestSourceLocationsForRenamingMessage(RequestSourceLocationsForRenamingMessage &&message) = 0;
virtual void requestSourceRangesAndDiagnosticsForQueryMessage(RequestSourceRangesAndDiagnosticsForQueryMessage &&message) = 0; virtual void requestSourceRangesAndDiagnosticsForQueryMessage(RequestSourceRangesAndDiagnosticsForQueryMessage &&message) = 0;
virtual void requestSourceRangesForQueryMessage(RequestSourceRangesForQueryMessage &&message) = 0;
virtual void cancel() = 0; virtual void cancel() = 0;
bool isUsable() const bool isUsable() const
......
...@@ -25,12 +25,9 @@ ...@@ -25,12 +25,9 @@
#include "refactoringserverproxy.h" #include "refactoringserverproxy.h"
#include "cancelmessage.h"
#include "cmbendmessage.h"
#include "messageenvelop.h" #include "messageenvelop.h"
#include "refactoringclientinterface.h" #include "refactoringclientinterface.h"
#include "requestsourcelocationforrenamingmessage.h" #include "clangrefactoringservermessages.h"
#include "requestsourcerangesanddiagnosticsforquerymessage.h"
#include <QIODevice> #include <QIODevice>
#include <QVector> #include <QVector>
...@@ -60,6 +57,11 @@ void RefactoringServerProxy::requestSourceRangesAndDiagnosticsForQueryMessage(Re ...@@ -60,6 +57,11 @@ void RefactoringServerProxy::requestSourceRangesAndDiagnosticsForQueryMessage(Re
writeMessageBlock.write(message); writeMessageBlock.write(message);
} }
void RefactoringServerProxy::requestSourceRangesForQueryMessage(RequestSourceRangesForQueryMessage &&message)
{
writeMessageBlock.write(message);
}
void RefactoringServerProxy::cancel() void RefactoringServerProxy::cancel()
{ {
writeMessageBlock.write(CancelMessage()); writeMessageBlock.write(CancelMessage());
......
...@@ -52,6 +52,7 @@ public: ...@@ -52,6 +52,7 @@ public:
void end() override; void end() override;
void requestSourceLocationsForRenamingMessage(RequestSourceLocationsForRenamingMessage &&message) override; void requestSourceLocationsForRenamingMessage(RequestSourceLocationsForRenamingMessage &&message) override;
void requestSourceRangesAndDiagnosticsForQueryMessage(RequestSourceRangesAndDiagnosticsForQueryMessage &&message) override; void requestSourceRangesAndDiagnosticsForQueryMessage(RequestSourceRangesAndDiagnosticsForQueryMessage &&message) override;
void requestSourceRangesForQueryMessage(RequestSourceRangesForQueryMessage &&message) override;
void cancel() override; void cancel() override;
void readMessages(); void readMessages();
......
...@@ -31,7 +31,7 @@ QDebug operator<<(QDebug debug, const RequestSourceRangesAndDiagnosticsForQueryM ...@@ -31,7 +31,7 @@ QDebug operator<<(QDebug debug, const RequestSourceRangesAndDiagnosticsForQueryM
{ {
debug.nospace() << "RequestSourceRangesAndDiagnosticsForQuery(" debug.nospace() << "RequestSourceRangesAndDiagnosticsForQuery("
<< message.query() << ", " << message.query() << ", "
<< message.sources() << ")"; << message.source() << ")";
return debug; return debug;
} }
...@@ -40,7 +40,7 @@ std::ostream &operator<<(std::ostream &os, const RequestSourceRangesAndDiagnosti ...@@ -40,7 +40,7 @@ std::ostream &operator<<(std::ostream &os, const RequestSourceRangesAndDiagnosti
{ {
os << "(" os << "("
<< message.query() << ", " << message.query() << ", "
<< message.sources() << message.source()
<< ")"; << ")";
return os; return os;
......
...@@ -34,32 +34,20 @@ class RequestSourceRangesAndDiagnosticsForQueryMessage ...@@ -34,32 +34,20 @@ class RequestSourceRangesAndDiagnosticsForQueryMessage
public: public:
RequestSourceRangesAndDiagnosticsForQueryMessage() = default; RequestSourceRangesAndDiagnosticsForQueryMessage() = default;
RequestSourceRangesAndDiagnosticsForQueryMessage(Utils::SmallString &&query, RequestSourceRangesAndDiagnosticsForQueryMessage(Utils::SmallString &&query,
std::vector<V2::FileContainer> &&sources, V2::FileContainer &&source)
std::vector<V2::FileContainer> &&unsavedContent)
: m_query(std::move(query)), : m_query(std::move(query)),
m_sources(std::move(sources)), m_source(std::move(source))
m_unsavedContent(std::move(unsavedContent))
{} {}
const std::vector<V2::FileContainer> &sources() const const V2::FileContainer &source() const
{ {
return m_sources; return m_source;
} }
std::vector<V2::FileContainer> takeSources() V2::FileContainer takeSource()
{ {
return std::move(m_sources); return std::move(m_source);
}
const std::vector<V2::FileContainer> &unsavedContent() const
{
return m_unsavedContent;
}
std::vector<V2::FileContainer> takeUnsavedContent()
{
return std::move(m_unsavedContent);
} }
const Utils::SmallString &query() const const Utils::SmallString &query() const
...@@ -75,8 +63,7 @@ public: ...@@ -75,8 +63,7 @@ public:
friend QDataStream &operator<<(QDataStream &out, const RequestSourceRangesAndDiagnosticsForQueryMessage &message) friend QDataStream &operator<<(QDataStream &out, const RequestSourceRangesAndDiagnosticsForQueryMessage &message)
{ {
out << message.m_query; out << message.m_query;
out << message.m_sources; out << message.m_source;
out << message.m_unsavedContent;
return out; return out;
} }
...@@ -84,8 +71,7 @@ public: ...@@ -84,8 +71,7 @@ public:
friend QDataStream &operator>>(QDataStream &in, RequestSourceRangesAndDiagnosticsForQueryMessage &message) friend QDataStream &operator>>(QDataStream &in, RequestSourceRangesAndDiagnosticsForQueryMessage &message)
{ {
in >> message.m_query; in >> message.m_query;
in >> message.m_sources; in >> message.m_source;
in >> message.m_unsavedContent;
return in; return in;
} }
...@@ -94,26 +80,21 @@ public: ...@@ -94,26 +80,21 @@ public:
const RequestSourceRangesAndDiagnosticsForQueryMessage &second)