From aa3270a1e6bff2874218e0bc85ac77017a5c9f08 Mon Sep 17 00:00:00 2001
From: Thomas Hartmann <thomas.hartmann@qt.io>
Date: Wed, 9 Aug 2017 15:46:20 +0200
Subject: [PATCH] QmlDesigner: Fix crash

This was introduced when adjusting the selection behaivour.

When we change to the selection tool we might delete items.
This item could be in itemlist we forward to AbstractFormEditorTool.

Therefore we change to the selection tool after calling
mouseReleaseEvent().

Change-Id: I5cab902b8560780c6ee4edc3466e7087d719f1ef
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
---
 src/plugins/qmldesigner/components/formeditor/movetool.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/plugins/qmldesigner/components/formeditor/movetool.cpp b/src/plugins/qmldesigner/components/formeditor/movetool.cpp
index 5fb29ac88d..1c7e52f9f5 100644
--- a/src/plugins/qmldesigner/components/formeditor/movetool.cpp
+++ b/src/plugins/qmldesigner/components/formeditor/movetool.cpp
@@ -246,9 +246,9 @@ void MoveTool::mouseReleaseEvent(const QList<QGraphicsItem*> &itemList,
         m_movingItems.clear();
     }
 
-    view()->changeToSelectionTool();
-
     AbstractFormEditorTool::mouseReleaseEvent(itemList, event);
+
+    view()->changeToSelectionTool();
 }
 
 void MoveTool::mouseDoubleClickEvent(const QList<QGraphicsItem*> &itemList, QGraphicsSceneMouseEvent *event)
-- 
GitLab