From abc60352fd34b816bfe53c3fbc1d0813075923bb Mon Sep 17 00:00:00 2001
From: hjk <qtc-committer@nokia.com>
Date: Thu, 14 Jul 2011 12:20:12 +0200
Subject: [PATCH] analyzer: hide Browse button for valgrind path chooser on
Windows
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Change-Id: If7bf02f5ab52f3f3330a8eea0669f619130bbe2f
Task-number: QTCREATORBUG-5441
Reviewed-on: http://codereview.qt.nokia.com/1658
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Robert Löhning <robert.loehning@nokia.com>
---
src/plugins/valgrind/valgrindconfigwidget.cpp | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/src/plugins/valgrind/valgrindconfigwidget.cpp b/src/plugins/valgrind/valgrindconfigwidget.cpp
index 3c8df75470d..337b786c833 100644
--- a/src/plugins/valgrind/valgrindconfigwidget.cpp
+++ b/src/plugins/valgrind/valgrindconfigwidget.cpp
@@ -64,6 +64,13 @@ ValgrindConfigWidget::ValgrindConfigWidget(ValgrindBaseSettings *settings,
connect(m_settings, SIGNAL(valgrindExecutableChanged(QString)),
m_ui->valgrindExeChooser, SLOT(setPath(QString)));
+#ifdef Q_OS_WIN
+ // FIXME: On Window we know that we don't have a local valgrind
+ // executable, so having the "Browse" button in the path chooser
+ // (which is needed for the remote executable) is confusing.
+ m_ui->valgrindExeChooser->buttonAtIndex(0)->hide();
+#endif
+
//
// Callgrind
//
--
GitLab