From ac1098d1b8391b8168af3a65057039b38373250c Mon Sep 17 00:00:00 2001 From: Bill King <bill.king@nokia.com> Date: Fri, 11 Jun 2010 13:41:31 +1000 Subject: [PATCH] Fixes possible buffer overflow situation. --- src/plugins/debugger/gdb/gdbengine.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/plugins/debugger/gdb/gdbengine.cpp b/src/plugins/debugger/gdb/gdbengine.cpp index f3c60768200..310b15da599 100644 --- a/src/plugins/debugger/gdb/gdbengine.cpp +++ b/src/plugins/debugger/gdb/gdbengine.cpp @@ -3432,14 +3432,14 @@ void GdbEngine::rebuildWatchModel() static QByteArray arrayFillCommand(const char *array, const QByteArray ¶ms) { - char buf[50]; - sprintf(buf, "set {char[%d]} &%s = {", params.size(), array); + QString buf; + buf.sprintf("set {char[%d]} &%s = {", params.size(), array); QByteArray encoded; - encoded.append(buf); + encoded.append(buf.toLocal8Bit()); const int size = params.size(); for (int i = 0; i != size; ++i) { - sprintf(buf, "%d,", int(params[i])); - encoded.append(buf); + buf.sprintf("%d,", int(params[i])); + encoded.append(buf.toLocal8Bit()); } encoded[encoded.size() - 1] = '}'; return encoded; -- GitLab