Commit af69f732 authored by hjk's avatar hjk
Browse files

Debugger: Hard-code version dependency of m_dissembleUsesComma



We don't support GDB in the range 7.0...7.3 anymore where the
outcome was unsure.

Change-Id: I1ce76f5c4b1febe45c4a3b6404208fed7d9c6868
Reviewed-by: default avatarhjk <hjk121@nokiamail.com>
parent 91ba674d
......@@ -1813,6 +1813,9 @@ void GdbEngine::handleShowVersion(const GdbResponse &response)
if (m_gdbVersion > 70300)
m_hasBreakpointNotifications = true;
if (m_gdbVersion > 70100)
m_disassembleUsesComma = true;
if (usesExecInterrupt())
postCommand("set target-async on", ConsoleCommand);
else
......@@ -4641,11 +4644,6 @@ void GdbEngine::reloadDisassembly()
updateLocals();
}
void GdbEngine::handleDisassemblerCheck(const GdbResponse &response)
{
m_disassembleUsesComma = response.resultClass != GdbResultDone;
}
void GdbEngine::handleFetchDisassemblerByCliPointMixed(const GdbResponse &response)
{
DisassemblerAgentCookie ac = response.cookie.value<DisassemblerAgentCookie>();
......@@ -4851,10 +4849,6 @@ void GdbEngine::startGdb(const QStringList &args)
postCommand("set remotecache on", ConsoleCommand);
//postCommand("set non-stop on", ConsoleCommand);
showMessage(_("THE FOLLOWING COMMAND CHECKS AVAILABLE FEATURES. "
"AN ERROR IS EXPECTED."));
postCommand("disassemble 0 0", ConsoleCommand, CB(handleDisassemblerCheck));
typedef GlobalDebuggerOptions::SourcePathMap SourcePathMap;
typedef SourcePathMap::const_iterator SourcePathMapIterator;
......
......@@ -514,7 +514,6 @@ private: ////////// View & Data Stuff //////////
//void handleFetchDisassemblerByMiPointPlain(const GdbResponse &response);
//void handleFetchDisassemblerByMiRangeMixed(const GdbResponse &response);
//void handleFetchDisassemblerByMiRangePlain(const GdbResponse &response);
void handleDisassemblerCheck(const GdbResponse &response);
void handleBreakOnQFatal(const GdbResponse &response);
DisassemblerLines parseDisassembler(const GdbResponse &response);
DisassemblerLines parseCliDisassembler(const QByteArray &response);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment