From af91d73a1c010d94a0dc7bbfa3d77eff8bb09be5 Mon Sep 17 00:00:00 2001
From: David Schulz <david.schulz@qt.io>
Date: Mon, 22 Aug 2016 08:27:41 +0200
Subject: [PATCH] TextEditor: Remove unnecessary hash lookup
Change-Id: I50b80ad43c7a4dc56207497e948993946d977101
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
---
src/plugins/texteditor/textmark.cpp | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/plugins/texteditor/textmark.cpp b/src/plugins/texteditor/textmark.cpp
index e764b2cfa1c..e4f68eee4ba 100644
--- a/src/plugins/texteditor/textmark.cpp
+++ b/src/plugins/texteditor/textmark.cpp
@@ -257,11 +257,12 @@ bool TextMarkRegistry::categoryHasColor(Id category)
return m_colors.contains(category);
}
-void TextMarkRegistry::setCategoryColor(Id category, Theme::Color color)
+void TextMarkRegistry::setCategoryColor(Id category, Theme::Color newColor)
{
- if (m_colors[category] == color)
+ Theme::Color &color = m_colors[category];
+ if (color == newColor)
return;
- m_colors[category] = color;
+ color = newColor;
}
QString TextMarkRegistry::defaultToolTip(Id category) const
--
GitLab