diff --git a/src/plugins/qmldesigner/components/integration/designdocumentcontroller.cpp b/src/plugins/qmldesigner/components/integration/designdocumentcontroller.cpp index c1337013c97575361101df2d2d1f8d21e6129c7a..87b65ed850689dc5e29724a3d29c6565e15acefe 100644 --- a/src/plugins/qmldesigner/components/integration/designdocumentcontroller.cpp +++ b/src/plugins/qmldesigner/components/integration/designdocumentcontroller.cpp @@ -326,7 +326,7 @@ QList<RewriterView::Error> DesignDocumentController::loadMaster(QPlainTextEdit * connect(edit, SIGNAL(modificationChanged(bool)), this, SIGNAL(dirtyStateChanged(bool))); - m_d->textModifier = new BaseTextEditModifier(m_d->textEdit.data()); + m_d->textModifier = new BaseTextEditModifier(dynamic_cast<TextEditor::BaseTextEditor*>(m_d->textEdit.data())); m_d->componentTextModifier = 0; diff --git a/src/plugins/qmldesigner/components/integration/designdocumentcontrollerview.cpp b/src/plugins/qmldesigner/components/integration/designdocumentcontrollerview.cpp index 22b0410834085a57d174481185f20e6b9d337872..c3dbddb1e91c01344b613ba1f0e5dedef81885a7 100644 --- a/src/plugins/qmldesigner/components/integration/designdocumentcontrollerview.cpp +++ b/src/plugins/qmldesigner/components/integration/designdocumentcontrollerview.cpp @@ -31,6 +31,7 @@ #include <rewriterview.h> #include <basetexteditmodifier.h> #include <metainfo.h> +#include <plaintexteditmodifier.h> #include <QApplication> #include <QPlainTextEdit> @@ -102,7 +103,7 @@ QString DesignDocumentControllerView::toText() const outputModel->setMetaInfo(model()->metaInfo()); QPlainTextEdit textEdit; textEdit.setPlainText("import Qt 4.6; Item {}"); - BaseTextEditModifier modifier(&textEdit); + NotIndentingTextEditModifier modifier(&textEdit); QScopedPointer<RewriterView> rewriterView(new RewriterView(RewriterView::Amend, 0)); rewriterView->setTextModifier(&modifier); @@ -126,7 +127,7 @@ void DesignDocumentControllerView::fromText(QString text) QPlainTextEdit textEdit; QString imports("import Qt 4.6;\n"); textEdit.setPlainText(imports + text); - BaseTextEditModifier modifier(&textEdit); + NotIndentingTextEditModifier modifier(&textEdit); QScopedPointer<RewriterView> rewriterView(new RewriterView(RewriterView::Amend, 0)); rewriterView->setTextModifier(&modifier); diff --git a/src/plugins/qmldesigner/core/include/basetexteditmodifier.h b/src/plugins/qmldesigner/core/include/basetexteditmodifier.h index 0bc9c796c236e39cb7e7389d38ffbb740dc3abd7..8115c2ebff87229da5e4df1a1e738bae8588bc24 100644 --- a/src/plugins/qmldesigner/core/include/basetexteditmodifier.h +++ b/src/plugins/qmldesigner/core/include/basetexteditmodifier.h @@ -34,12 +34,14 @@ #include "corelib_global.h" #include "plaintexteditmodifier.h" +#include <texteditor/basetexteditor.h> + namespace QmlDesigner { class CORESHARED_EXPORT BaseTextEditModifier: public PlainTextEditModifier { public: - BaseTextEditModifier(QPlainTextEdit *textEdit); + BaseTextEditModifier(TextEditor::BaseTextEditor *textEdit); virtual void indent(int offset, int length); diff --git a/src/plugins/qmldesigner/core/include/plaintexteditmodifier.h b/src/plugins/qmldesigner/core/include/plaintexteditmodifier.h index 503b89246424db5e4dcc72caa1aa7e515ef613f5..2d33931e6cf755d2eca1b08e20f0201341161b12 100644 --- a/src/plugins/qmldesigner/core/include/plaintexteditmodifier.h +++ b/src/plugins/qmldesigner/core/include/plaintexteditmodifier.h @@ -66,6 +66,8 @@ public: virtual void move(const MoveInfo &moveInfo); virtual void indent(int offset, int length) = 0; + virtual int indentDepth() const = 0; + virtual void startGroup(); virtual void flushGroup(); virtual void commitGroup(); @@ -91,6 +93,20 @@ private: bool m_ongoingTextChange; }; +class CORESHARED_EXPORT NotIndentingTextEditModifier: public PlainTextEditModifier +{ +public: + NotIndentingTextEditModifier(QPlainTextEdit *textEdit) + : PlainTextEditModifier(textEdit) + {} + + virtual void indent(int /*offset*/, int /*length*/) + {} + + virtual int indentDepth() const + { return 0; } +}; + } #endif // PLAINTEXTEDITMODIFIER_H diff --git a/src/plugins/qmldesigner/core/model/basetexteditmodifier.cpp b/src/plugins/qmldesigner/core/model/basetexteditmodifier.cpp index c6fb15d18169fb41d1d776b6592e4d644b894334..5421b87d0177a56fffc3f8bcfb45865c006bd865 100644 --- a/src/plugins/qmldesigner/core/model/basetexteditmodifier.cpp +++ b/src/plugins/qmldesigner/core/model/basetexteditmodifier.cpp @@ -29,12 +29,11 @@ #include "basetexteditmodifier.h" -#include <texteditor/basetexteditor.h> #include <texteditor/tabsettings.h> using namespace QmlDesigner; -BaseTextEditModifier::BaseTextEditModifier(QPlainTextEdit *textEdit): +BaseTextEditModifier::BaseTextEditModifier(TextEditor::BaseTextEditor *textEdit): PlainTextEditModifier(textEdit) { } @@ -44,9 +43,7 @@ void BaseTextEditModifier::indent(int offset, int length) if (length == 0 || offset < 0 || offset + length >= text().length()) return; -// qDebug() << "PlainTextEditModifier::indent(" << offset << "," << length << ")"; if (TextEditor::BaseTextEditor *bte = dynamic_cast<TextEditor::BaseTextEditor*>(plainTextEdit())) { -// qDebug() << "**** Doing indentation"; // find the applicable block: QTextDocument *doc = bte->document(); QTextCursor tc(doc); @@ -55,8 +52,6 @@ void BaseTextEditModifier::indent(int offset, int length) tc.setPosition(offset + length, QTextCursor::KeepAnchor); bte->indentInsertedText(tc); tc.endEditBlock(); - } else { -// qDebug() << "**** Skipping indentation"; } } @@ -65,7 +60,6 @@ int BaseTextEditModifier::indentDepth() const if (TextEditor::BaseTextEditor *bte = dynamic_cast<TextEditor::BaseTextEditor*>(plainTextEdit())) { return bte->tabSettings().m_indentSize; } else { - Q_ASSERT(false && "BaseTextEditModifier does not have a BaseTextEditor"); return 0; } } diff --git a/src/plugins/qmldesigner/core/model/plaintexteditmodifier.cpp b/src/plugins/qmldesigner/core/model/plaintexteditmodifier.cpp index 4eb5512da9f1f13950e9d275086e767ba52c28b1..2ef424cb45af0e31fd5bc7b5c0a96a6e7d8f89ce 100644 --- a/src/plugins/qmldesigner/core/model/plaintexteditmodifier.cpp +++ b/src/plugins/qmldesigner/core/model/plaintexteditmodifier.cpp @@ -46,6 +46,8 @@ PlainTextEditModifier::PlainTextEditModifier(QPlainTextEdit *textEdit): m_pendingChangeSignal(false), m_ongoingTextChange(false) { + Q_ASSERT(textEdit); + connect(m_textEdit, SIGNAL(textChanged()), this, SLOT(textEditChanged())); }