Commit b3814184 authored by Christian Stenger's avatar Christian Stenger

Welcome: Squish: Assign object name to fix Squish tests

Latest change of adding QScrollArea around Welcome's sidebar made
the objects lookup fragile. Using the QScrollArea inside Squish
tests helped for some but not all lookups.
Simplify the lookup by assigning an object name.

Change-Id: I5f37ee69bf20eaf02c9717cbaa5ba541d8ffbc17
Reviewed-by: Alessandro Portale's avatarAlessandro Portale <alessandro.portale@qt.io>
parent ca3b882a
...@@ -303,6 +303,7 @@ WelcomeMode::WelcomeMode() ...@@ -303,6 +303,7 @@ WelcomeMode::WelcomeMode()
divider->setPalette(themeColor(Theme::Welcome_DividerColor)); divider->setPalette(themeColor(Theme::Welcome_DividerColor));
m_pageStack = new QStackedWidget(m_modeWidget); m_pageStack = new QStackedWidget(m_modeWidget);
m_pageStack->setObjectName("WelcomeScreenStackedWidget");
m_pageStack->setAutoFillBackground(true); m_pageStack->setAutoFillBackground(true);
auto hbox = new QHBoxLayout; auto hbox = new QHBoxLayout;
......
...@@ -37,10 +37,8 @@ def getWelcomeScreenSideBarButton(buttonLabel): ...@@ -37,10 +37,8 @@ def getWelcomeScreenSideBarButton(buttonLabel):
return __getWelcomeScreenButtonHelper__(buttonLabel, sideBar) return __getWelcomeScreenButtonHelper__(buttonLabel, sideBar)
def getWelcomeScreenMainButton(buttonLabel): def getWelcomeScreenMainButton(buttonLabel):
stackedWidget = waitForObject("{type='QWidget' unnamed='1' visible='1' " stackedWidget = waitForObject("{type='QStackedWidget' name='WelcomeScreenStackedWidget' "
"leftWidget={type='QWidget' unnamed='1' visible='1' " "window=':Qt Creator_Core::Internal::MainWindow'}")
"leftWidget={type='Welcome::Internal::SideBar' unnamed='1' "
"window=':Qt Creator_Core::Internal::MainWindow'}}}")
currentStackWidget = stackedWidget.currentWidget() currentStackWidget = stackedWidget.currentWidget()
return __getWelcomeScreenButtonHelper__(buttonLabel, currentStackWidget) return __getWelcomeScreenButtonHelper__(buttonLabel, currentStackWidget)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment