diff --git a/src/plugins/texteditor/behaviorsettingspage.cpp b/src/plugins/texteditor/behaviorsettingspage.cpp index 57a911a8debac4ecabd2279737bc739b17a928c8..e86d64e1d35583bb3b0d2e1691e39601569ae3ce 100644 --- a/src/plugins/texteditor/behaviorsettingspage.cpp +++ b/src/plugins/texteditor/behaviorsettingspage.cpp @@ -158,7 +158,7 @@ void BehaviorSettingsPage::settingsFromUI(TabSettings &tabSettings, tabSettings.m_doubleIndentBlocks = m_d->m_page.indentBlocksBehavior->currentIndex() >= 2; tabSettings.m_tabKeyBehavior = (TabSettings::TabKeyBehavior)m_d->m_page.tabKeyBehavior->currentIndex(); - tabSettings.m_paddingMode = (TabSettings::PaddingMode)m_d->m_page.paddingMode->currentIndex(); + tabSettings.m_continuationAlignBehavior = (TabSettings::ContinuationAlignBehavior)m_d->m_page.continuationAlignBehavior->currentIndex(); storageSettings.m_cleanWhitespace = m_d->m_page.cleanWhitespace->isChecked(); storageSettings.m_inEntireDocument = m_d->m_page.inEntireDocument->isChecked(); @@ -182,7 +182,7 @@ void BehaviorSettingsPage::settingsToUI() (tabSettings.m_doubleIndentBlocks ? 2 : 1) : 0); m_d->m_page.tabKeyBehavior->setCurrentIndex(tabSettings.m_tabKeyBehavior); - m_d->m_page.paddingMode->setCurrentIndex(tabSettings.m_paddingMode); + m_d->m_page.continuationAlignBehavior->setCurrentIndex(tabSettings.m_continuationAlignBehavior); const StorageSettings &storageSettings = m_d->m_storageSettings; m_d->m_page.cleanWhitespace->setChecked(storageSettings.m_cleanWhitespace); diff --git a/src/plugins/texteditor/behaviorsettingspage.ui b/src/plugins/texteditor/behaviorsettingspage.ui index 2b5d2bd7959b69903e60748ef47c9af3b5027b6f..1f4a5c183825c6e448ec6f216392f49b38d32697 100644 --- a/src/plugins/texteditor/behaviorsettingspage.ui +++ b/src/plugins/texteditor/behaviorsettingspage.ui @@ -206,36 +206,54 @@ </widget> </item> <item row="1" column="0"> - <widget class="QLabel" name="paddingStyleLabel"> + <widget class="QLabel" name="continuationAlignLabel"> <property name="text"> - <string>Padding style:</string> + <string>Align continuation lines:</string> </property> </widget> </item> <item row="1" column="1"> - <widget class="QComboBox" name="paddingMode"> + <widget class="QComboBox" name="continuationAlignBehavior"> <property name="toolTip"> - <string>Padding is the part of indentation exceeding logical indentation and is usually used to align consecutive lines of code. + <string><html><head/><body> +Influences the indentation of continuation lines. -Disable Padding: Do not pad at all. Lines will only be indented to the current logical indentation depth. +<ul> +<li>Not At All: Do not align at all. Lines will only be indented to the current logical indentation depth. +<pre> +(tab)int i = foo(a, b +(tab)c, d); +</pre> +</li> -Pad With Spaces: Always use spaces for padding, regardless of the choice between tabs and spaces above. +<li>With Spaces: Always use spaces for alignment, regardless of the other indentation settings. +<pre> +(tab)int i = foo(a, b +(tab) c, d); +</pre> +</li> -Pad With Indentation: Padding will be part of the indentation and follow the settings above.</string> +<li>With Regular Indent: Use tabs and/or spaces for alignment, as configured above. +<pre> +(tab)int i = foo(a, b +(tab)(tab)(tab) c, d); +</pre> +</li> +</ul></body></html></string> </property> <item> <property name="text"> - <string>Disable Padding</string> + <string>Not At All</string> </property> </item> <item> <property name="text"> - <string>Pad With Spaces</string> + <string>With Spaces</string> </property> </item> <item> <property name="text"> - <string>Pad With Indentation</string> + <string>With Regular Indent</string> </property> </item> </widget> diff --git a/src/plugins/texteditor/tabsettings.cpp b/src/plugins/texteditor/tabsettings.cpp index 6277030eb19dcb6c98c3fc412eb4cf9421fc2386..001b13093fee00aa88320951e03aca0f88f82611 100644 --- a/src/plugins/texteditor/tabsettings.cpp +++ b/src/plugins/texteditor/tabsettings.cpp @@ -59,7 +59,7 @@ TabSettings::TabSettings() : m_indentBraces(false), m_doubleIndentBlocks(false), m_tabKeyBehavior(TabNeverIndents), - m_paddingMode(PadWithSpaces) + m_continuationAlignBehavior(ContinuationAlignWithSpaces) { } @@ -78,7 +78,7 @@ void TabSettings::toSettings(const QString &category, QSettings *s) const s->setValue(QLatin1String(indentBracesKey), m_indentBraces); s->setValue(QLatin1String(doubleIndentBlocksKey), m_doubleIndentBlocks); s->setValue(QLatin1String(tabKeyBehaviorKey), m_tabKeyBehavior); - s->setValue(QLatin1String(paddingModeKey), m_paddingMode); + s->setValue(QLatin1String(paddingModeKey), m_continuationAlignBehavior); s->endGroup(); } @@ -102,7 +102,7 @@ void TabSettings::fromSettings(const QString &category, const QSettings *s) = s->value(group + QLatin1String(doubleIndentBlocksKey), m_doubleIndentBlocks).toBool(); m_tabKeyBehavior = (TabKeyBehavior)s->value(group + QLatin1String(tabKeyBehaviorKey), m_tabKeyBehavior).toInt(); - m_paddingMode = (PaddingMode)s->value(group + QLatin1String(paddingModeKey), m_paddingMode).toInt(); + m_continuationAlignBehavior = (ContinuationAlignBehavior)s->value(group + QLatin1String(paddingModeKey), m_continuationAlignBehavior).toInt(); } @@ -323,10 +323,10 @@ void TabSettings::indentLine(QTextBlock block, int newIndent, int padding) const const QString text = block.text(); const int oldBlockLength = text.size(); - if (m_paddingMode == DisablePadding) { + if (m_continuationAlignBehavior == NoContinuationAlign) { newIndent -= padding; padding = 0; - } else if (m_paddingMode == PadWithIndent) { + } else if (m_continuationAlignBehavior == ContinuationAlignWithIndent) { padding = 0; } @@ -400,7 +400,7 @@ bool TabSettings::equals(const TabSettings &ts) const && m_indentBraces == ts.m_indentBraces && m_doubleIndentBlocks == ts.m_doubleIndentBlocks && m_tabKeyBehavior == ts.m_tabKeyBehavior - && m_paddingMode == ts.m_paddingMode; + && m_continuationAlignBehavior == ts.m_continuationAlignBehavior; } } // namespace TextEditor diff --git a/src/plugins/texteditor/tabsettings.h b/src/plugins/texteditor/tabsettings.h index 66c7fa0e6aa9c59dc6ab00bad88247ecfb868085..e5b9d453429211375d3444f1250ffd67d35fd2e3 100644 --- a/src/plugins/texteditor/tabsettings.h +++ b/src/plugins/texteditor/tabsettings.h @@ -52,11 +52,11 @@ public: TabLeadingWhitespaceIndents = 2 }; - // This enum must match the indexes of paddingMode widget - enum PaddingMode { - DisablePadding = 0, - PadWithSpaces = 1, - PadWithIndent = 2 + // This enum must match the indexes of continuationAlignBehavior widget + enum ContinuationAlignBehavior { + NoContinuationAlign = 0, + ContinuationAlignWithSpaces = 1, + ContinuationAlignWithIndent = 2 }; TabSettings(); @@ -96,7 +96,7 @@ public: bool m_indentBraces; bool m_doubleIndentBlocks; TabKeyBehavior m_tabKeyBehavior; - PaddingMode m_paddingMode; + ContinuationAlignBehavior m_continuationAlignBehavior; bool equals(const TabSettings &ts) const; };