TextEditor: Replace in-class connection by virtual function

Change-Id: Ifb51606f71100223631d086318c230a478d70712
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

src/plugins/cppeditor/cppeditor.cpp

@@ -199,9 +199,6 @@ CppEditorWidget::CppEditorWidget(TextEditor::BaseTextDocumentPtr doc)
                 this, SLOT(highlighterStarted(QFuture<TextEditor::HighlightingResult>*,uint)));
     }
 
-    connect(this, SIGNAL(refactorMarkerClicked(TextEditor::RefactorMarker)),
-            this, SLOT(onRefactorMarkerClicked(TextEditor::RefactorMarker)));
-
     connect(d->m_declDefLinkFinder, SIGNAL(foundLink(QSharedPointer<FunctionDeclDefLink>)),
             this, SLOT(onFunctionDeclDefLinkFound(QSharedPointer<FunctionDeclDefLink>)));
 

src/plugins/qmljseditor/qmljseditor.cpp

@@ -156,9 +156,6 @@ QmlJSTextEditorWidget::QmlJSTextEditorWidget(BaseTextDocumentPtr doc)
     connect(m_qmlJsEditorDocument, SIGNAL(semanticInfoUpdated(QmlJSTools::SemanticInfo)),
             this, SLOT(semanticInfoUpdated(QmlJSTools::SemanticInfo)));
 
-    connect(this, SIGNAL(refactorMarkerClicked(TextEditor::RefactorMarker)),
-            SLOT(onRefactorMarkerClicked(TextEditor::RefactorMarker)));
-
     setRequestMarkEnabled(true);
     createToolBar();
 }

src/plugins/texteditor/basetexteditor.cpp

@@ -4767,7 +4767,7 @@ void BaseTextEditorWidget::mousePressEvent(QMouseEvent *e)
 
             RefactorMarker refactorMarker = d->m_refactorOverlay->markerAt(e->pos());
             if (refactorMarker.isValid()) {
-                emit refactorMarkerClicked(refactorMarker);
+                onRefactorMarkerClicked(refactorMarker);
             } else {
                 d->updateLink(e);
 

src/plugins/texteditor/basetexteditor.h

@@ -490,7 +490,6 @@ public slots:
 signals:
     void assistFinished();
     void readOnlyChanged();
-    void refactorMarkerClicked(const TextEditor::RefactorMarker &marker);
 
     void requestFontZoom(int zoom);
     void requestZoomReset();
@@ -536,6 +535,8 @@ protected:
     virtual void triggerPendingUpdates();
     virtual void applyFontSettings();
 
+    virtual void onRefactorMarkerClicked(const RefactorMarker &) {}
+
     void showDefaultContextMenu(QContextMenuEvent *e, Core::Id menuContextId);
 
 public: