Commit d58f0e7c authored by Friedemann Kleint's avatar Friedemann Kleint
Browse files

Debugger[CDB]: Move breakpoint back from corrected location.

Make it fully work.

Task-number: QTCREATORBUG-4842
parent b6e373bc
......@@ -781,6 +781,15 @@ static bool isAllowedTransition(BreakpointState from, BreakpointState to)
return false;
bool BreakHandler::isEngineRunning(BreakpointId id) const
if (const DebuggerEngine *e = engine(id)) {
const DebuggerState state = e->state();
return state != DebuggerFinished && state != DebuggerNotReady;
return false;
void BreakHandler::setState(BreakpointId id, BreakpointState state)
Iterator it = m_storage.find(id);
......@@ -1028,10 +1037,8 @@ void BreakHandler::updateLineNumberFromMarker(BreakpointId id, int lineNumber)
// Ignore updates to the "real" line number while the debugger is
// running, as this can be triggered by moving the breakpoint to
// the next line that generated code.
if (it->response.number == 0) {
// FIXME: Do we need yet another data member?
if (!isEngineRunning(id))
it->data.lineNumber = lineNumber;
emit layoutChanged();
......@@ -168,6 +168,7 @@ private:
QVariant headerData(int section, Qt::Orientation orientation, int role) const;
Qt::ItemFlags flags(const QModelIndex &index) const;
bool isEngineRunning(BreakpointId id) const;
void setState(BreakpointId id, BreakpointState state);
void loadBreakpoints();
void saveBreakpoints();
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment