Commit da855409 authored by Christian Kandeler's avatar Christian Kandeler
Browse files

LinuxDeviceProcess: Quote environment variable values.



The current code breaks for values that contain spaces.

Change-Id: Ia2a318dcac09a8d1c1ce368378a33c633f28bf49
Reviewed-by: default avatarhjk <hjk121@nokiamail.com>
parent f1cfb5c5
...@@ -61,7 +61,13 @@ QString LinuxDeviceProcess::fullCommandLine() const ...@@ -61,7 +61,13 @@ QString LinuxDeviceProcess::fullCommandLine() const
fullCommandLine.append(QLatin1String("cd ")).append(quote(m_workingDir)) fullCommandLine.append(QLatin1String("cd ")).append(quote(m_workingDir))
.append(QLatin1String(" && ")); .append(QLatin1String(" && "));
} }
const QString envString = environment().toStringList().join(QLatin1String(" ")); QString envString;
for (auto it = environment().constBegin(); it != environment().constEnd(); ++it) {
if (!envString.isEmpty())
envString += QLatin1Char(' ');
envString.append(it.key()).append(QLatin1String("='")).append(it.value())
.append(QLatin1Char('\''));
}
if (!envString.isEmpty()) if (!envString.isEmpty())
fullCommandLine.append(QLatin1Char(' ')).append(envString); fullCommandLine.append(QLatin1Char(' ')).append(envString);
if (!fullCommandLine.isEmpty()) if (!fullCommandLine.isEmpty())
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment