From de0fcfaa0a6d707b15f50e5db0328bb4cd6a8c37 Mon Sep 17 00:00:00 2001
From: Francois Ferrand <thetypz@gmail.com>
Date: Mon, 12 Mar 2012 17:34:07 +0100
Subject: [PATCH] TextEditor: Avoid duplicates in circular clipboard.
When data is added to the circular, first check if it is already
present. In that case, the item is moved to the beginning of the
circular clipboard.
This avoids dropping old data prematurly, and traversing the same data
multiple times when pasting.
Change-Id: Iecaf8d2f5a05d08e6f5faa8555d24f4d7a1d33ab
Reviewed-by: Leandro Melo <leandro.melo@nokia.com>
---
src/plugins/texteditor/circularclipboard.cpp | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/src/plugins/texteditor/circularclipboard.cpp b/src/plugins/texteditor/circularclipboard.cpp
index 32c20ab5395..bba248a84a3 100644
--- a/src/plugins/texteditor/circularclipboard.cpp
+++ b/src/plugins/texteditor/circularclipboard.cpp
@@ -53,6 +53,16 @@ CircularClipboard *CircularClipboard::instance()
void CircularClipboard::collect(const QMimeData *mimeData)
{
+ //Avoid duplicates
+ const QString text = mimeData->text();
+ for (QList<const QMimeData *>::iterator i = m_items.begin(); i != m_items.end(); ++i) {
+ if (mimeData == *i || text == (*i)->text()) {
+ if (mimeData != *i)
+ delete *i;
+ m_items.erase(i);
+ break;
+ }
+ }
if (m_items.size() > kMaxSize) {
delete m_items.last();
m_items.removeLast();
--
GitLab