From df8fc5a9d1973902b29fc77560d97f8cf78fba55 Mon Sep 17 00:00:00 2001
From: hjk <qtc-committer@nokia.com>
Date: Thu, 2 Sep 2010 18:32:37 +0200
Subject: [PATCH] debugger: restrict accepted expressions in automatci tooltips
to simple identifiers.
---
src/plugins/debugger/gdb/gdbengine.cpp | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/src/plugins/debugger/gdb/gdbengine.cpp b/src/plugins/debugger/gdb/gdbengine.cpp
index 10e780ee226..942ccf713b9 100644
--- a/src/plugins/debugger/gdb/gdbengine.cpp
+++ b/src/plugins/debugger/gdb/gdbengine.cpp
@@ -3179,6 +3179,25 @@ void GdbEngine::setToolTipExpression(const QPoint &mousePos,
m_toolTipPos = mousePos;
int line, column;
QString exp = cppExpressionAt(editor, cursorPos, &line, &column);
+
+ // Extract the first identifier, everything else is considered
+ // too dangerous.
+ int pos1 = 0, pos2 = exp.size();
+ bool inId = false;
+ for (int i = 0; i != exp.size(); ++i) {
+ const QChar c = exp.at(i);
+ const bool isIdChar = c.isLetterOrNumber() || c.unicode() == '_';
+ if (inId && !isIdChar) {
+ pos2 = i;
+ break;
+ }
+ if (!inId && isIdChar) {
+ inId = true;
+ pos1 = i;
+ }
+ }
+ exp = exp.mid(pos1, pos2 - pos1);
+
if (!exp.isEmpty() && exp == m_toolTipExpression) {
showToolTip();
return;
--
GitLab