From e08f1763b7534173fcb540c6ac981aae74d902c6 Mon Sep 17 00:00:00 2001
From: dt <qtc-committer@nokia.com>
Date: Mon, 2 Feb 2009 18:06:26 +0100
Subject: [PATCH] Fixes: Workaround a bug in kde 4.2.0.
Task: Reported on irc.
Details: We did regiser all plugins but didn't initialize them. Leading
to the kde plugins installing a kde file dialog, but not initializing a
KComponentData, which leads to a crash when trying to open a file
dialog. So we aren't lazy anymore with the designer plugins.
And initialize them right away. We should reenable lazy initializing
once kde 4.2.1 has been released. (And probably has replaced kde 4.2.0
on most systems.)
---
src/plugins/designer/formeditorplugin.cpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/plugins/designer/formeditorplugin.cpp b/src/plugins/designer/formeditorplugin.cpp
index 823efb590d1..862b29cb46e 100644
--- a/src/plugins/designer/formeditorplugin.cpp
+++ b/src/plugins/designer/formeditorplugin.cpp
@@ -108,7 +108,11 @@ bool FormEditorPlugin::initialize(const QStringList &arguments, QString *error)
addObject(m_factory);
// Make sure settings pages and action shortcuts are registered
- FormEditorW::ensureInitStage(FormEditorW::RegisterPlugins);
+ // TODO we don't want to do a full initialization here,
+ // we actually want to call ensureInitStage(FormEditorW::RegisterPlugins)
+ // But due to a bug in kde 4.2.0 this crashes then when opening the file dialog
+ // This should be removed after 4.2.1 is out
+ FormEditorW::ensureInitStage(FormEditorW::FullyInitialized);
error->clear();
return true;
--
GitLab