From e71912b45b18bd9aa2b8f967ce4a651030bf9a4b Mon Sep 17 00:00:00 2001
From: Joerg Bornemann <joerg.bornemann@qt.io>
Date: Thu, 19 Oct 2017 14:02:12 +0200
Subject: [PATCH] QbsProjectManager: Avoid allocations in string comparisons
Use case-insensitive comparisons instead of converting toLower() first.
Found by clazy.
Change-Id: I0d32b0ba7ccb5493d1c86d41044b09c8baed3dc8
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
---
.../qbsprojectmanager/defaultpropertyprovider.cpp | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/plugins/qbsprojectmanager/defaultpropertyprovider.cpp b/src/plugins/qbsprojectmanager/defaultpropertyprovider.cpp
index 66201cb98bc..1de167bdbb2 100644
--- a/src/plugins/qbsprojectmanager/defaultpropertyprovider.cpp
+++ b/src/plugins/qbsprojectmanager/defaultpropertyprovider.cpp
@@ -341,12 +341,14 @@ QVariantMap DefaultPropertyProvider::autoGeneratedProperties(const ProjectExplor
canonicalName.chop(version.size());
if (!canonicalName.isEmpty() && !version.isEmpty()
&& sysrootAbs.startsWith(developerPath)) {
- if (sysrootAbs.toLower().endsWith(QStringLiteral("/%1.sdk")
- .arg(canonicalName + version)))
+ if (sysrootAbs.endsWith(QStringLiteral("/%1.sdk").arg(canonicalName + version),
+ Qt::CaseInsensitive)) {
data.insert(QLatin1String(XCODE_SDK), QString(canonicalName + version));
- if (sysrootAbs.toLower().endsWith(QStringLiteral("/%1.sdk")
- .arg(canonicalName)))
+ }
+ if (sysrootAbs.endsWith(QStringLiteral("/%1.sdk").arg(canonicalName),
+ Qt::CaseInsensitive)) {
data.insert(QLatin1String(XCODE_SDK), canonicalName);
+ }
}
}
}
--
GitLab