Commit e7a7c02b authored by Orgad Shaneh's avatar Orgad Shaneh Committed by Orgad Shaneh
Browse files

DiffEditor: Pass const lists and string by reference

Change-Id: I6acdc4db61aeed1353bed2207736268dfabf3f17
Reviewed-by: default avatarJarek Kobus <>
parent fb82943e
......@@ -590,7 +590,7 @@ static QString encodeExpandedWhitespace(const QString &leftEquality,
* The input argument contains version encoded with codeMap,
* the returned value contains decoded diff list.
static QList<Diff> decodeExpandedWhitespace(const QList<Diff> input,
static QList<Diff> decodeExpandedWhitespace(const QList<Diff> &input,
const QMap<int, QPair<int, QString> > &codeMap,
bool *ok)
......@@ -1125,7 +1125,7 @@ QList<Diff> Differ::diffMyersSplit(
return diffList1 + diffList2;
QList<Diff> Differ::diffNonCharMode(const QString text1, const QString text2)
QList<Diff> Differ::diffNonCharMode(const QString &text1, const QString &text2)
QString encodedText1;
QString encodedText2;
......@@ -99,7 +99,7 @@ private:
QList<Diff> diffMyers(const QString &text1, const QString &text2);
QList<Diff> diffMyersSplit(const QString &text1, int x,
const QString &text2, int y);
QList<Diff> diffNonCharMode(const QString text1, const QString text2);
QList<Diff> diffNonCharMode(const QString &text1, const QString &text2);
QStringList encode(const QString &text1,
const QString &text2,
QString *encodedText1,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment