Commit ec28a4b0 authored by Ulf Hermann's avatar Ulf Hermann
Browse files

QmlProfiler: Work around QProcess not emitting errorOccurred

When given an empty string as executable and some non-empty arguments
QProcess might emit error() but not errorOccurred(). This was fixed by
2f0ffba638bdb868a810bc0349c240b6b6e172cd in qtbase, but we cannot rely
on that being present, yet. Thus, avoid passing empty strings as

Change-Id: Ia1bb5ebceb6edeca1e54489d12b838f3cea8851e
Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <>
Reviewed-by: Christian Kandeler's avatarChristian Kandeler <>
parent 51e074b0
...@@ -41,6 +41,7 @@ void LocalQmlProfilerRunnerTest::testRunner() ...@@ -41,6 +41,7 @@ void LocalQmlProfilerRunnerTest::testRunner()
{ {
Debugger::AnalyzerConnection connection; Debugger::AnalyzerConnection connection;
LocalQmlProfilerRunner::Configuration configuration; LocalQmlProfilerRunner::Configuration configuration;
configuration.debuggee.executable = "\\-/|\\-/";
configuration.debuggee.environment = Utils::Environment::systemEnvironment(); configuration.debuggee.environment = Utils::Environment::systemEnvironment();
// should not be used anywhere but cannot be empty // should not be used anywhere but cannot be empty
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment