From ed4118628d1e5e00729338f461367bb79a3029c7 Mon Sep 17 00:00:00 2001
From: Erik Verbruggen <erik.verbruggen@nokia.com>
Date: Mon, 18 Jan 2010 14:12:04 +0100
Subject: [PATCH] Changed the QScriptHighlighter & QScriptIndenter namespaces.

---
 src/libs/qmljs/qmljs-lib.pri                 | 13 ++++++++++---
 src/libs/qmljs/qscripthighlighter.cpp        |  4 ++--
 src/libs/qmljs/qscripthighlighter.h          |  8 ++++----
 src/libs/qmljs/qscripthighlighter.pri        | 11 -----------
 src/libs/qmljs/qscriptincrementalscanner.cpp |  4 ++--
 src/libs/qmljs/qscriptincrementalscanner.h   |  8 +++++---
 src/libs/qmljs/qscriptindenter.cpp           |  7 ++++---
 src/libs/qmljs/qscriptindenter.h             | 10 ++++++----
 src/plugins/qmljseditor/qmlhighlighter.cpp   |  2 +-
 src/plugins/qmljseditor/qmlhighlighter.h     |  4 ++--
 src/plugins/qmljseditor/qmljseditor.cpp      |  5 ++---
 src/plugins/qmljseditor/qmljseditor.h        |  4 ++--
 src/plugins/qmljseditor/qmljseditor.pro      |  4 ----
 13 files changed, 40 insertions(+), 44 deletions(-)
 delete mode 100644 src/libs/qmljs/qscripthighlighter.pri

diff --git a/src/libs/qmljs/qmljs-lib.pri b/src/libs/qmljs/qmljs-lib.pri
index 439eb889eb3..ea0cb7bc520 100644
--- a/src/libs/qmljs/qmljs-lib.pri
+++ b/src/libs/qmljs/qmljs-lib.pri
@@ -5,7 +5,8 @@ contains(CONFIG, dll) {
 }
 
 include(parser/parser.pri)
-include($$PWD/qscripthighlighter.pri)
+
+DEFINES += QSCRIPTHIGHLIGHTER_BUILD_LIB
 
 DEPENDPATH += $$PWD
 INCLUDEPATH += $$PWD/..
@@ -17,7 +18,8 @@ HEADERS += \
     $$PWD/qmlpackageinfo.h \
     $$PWD/qmlsymbol.h \
     $$PWD/qmlmetatypebackend.h \
-    $$PWD/qmltypesystem.h
+    $$PWD/qmltypesystem.h \
+    $$PWD/qscriptincrementalscanner.h
 
 SOURCES += \
     $$PWD/qmlidcollector.cpp \
@@ -25,7 +27,8 @@ SOURCES += \
     $$PWD/qmlsymbol.cpp \
     $$PWD/qmlpackageinfo.cpp \
     $$PWD/qmlmetatypebackend.cpp \
-    $$PWD/qmltypesystem.cpp
+    $$PWD/qmltypesystem.cpp \
+    $$PWD/qscriptincrementalscanner.cpp
 
 contains(QT_CONFIG, declarative) {
     QT += declarative
@@ -39,3 +42,7 @@ contains(QT_CONFIG, declarative) {
         $$PWD/qtdeclarativemetatypebackend.cpp
 }
 
+contains(QT, gui) {
+    SOURCES += $$PWD/qscripthighlighter.cpp $$PWD/qscriptindenter.cpp
+    HEADERS += $$PWD/qscripthighlighter.h $$PWD/qscriptindenter.h
+}
diff --git a/src/libs/qmljs/qscripthighlighter.cpp b/src/libs/qmljs/qscripthighlighter.cpp
index 61a9aa8ef41..7a42d4b1613 100644
--- a/src/libs/qmljs/qscripthighlighter.cpp
+++ b/src/libs/qmljs/qscripthighlighter.cpp
@@ -27,12 +27,12 @@
 **
 **************************************************************************/
 
-#include "qscripthighlighter.h"
+#include <qmljs/qscripthighlighter.h>
 
 #include <QtCore/QSet>
 #include <QtCore/QtAlgorithms>
 
-using namespace SharedTools;
+using namespace QmlJS;
 
 QScriptHighlighter::QScriptHighlighter(bool duiEnabled, QTextDocument *parent):
         QSyntaxHighlighter(parent),
diff --git a/src/libs/qmljs/qscripthighlighter.h b/src/libs/qmljs/qscripthighlighter.h
index cc5f9c7dd08..321a609f92d 100644
--- a/src/libs/qmljs/qscripthighlighter.h
+++ b/src/libs/qmljs/qscripthighlighter.h
@@ -30,15 +30,15 @@
 #ifndef QSCRIPTSYNTAXHIGHLIGHTER_H
 #define QSCRIPTSYNTAXHIGHLIGHTER_H
 
-#include <qscripthighlighter/qscriptincrementalscanner.h>
+#include <qmljs/qscriptincrementalscanner.h>
 
 #include <QtCore/QVector>
 #include <QtCore/QSet>
 #include <QtGui/QSyntaxHighlighter>
 
-namespace SharedTools {
+namespace QmlJS {
 
-class QScriptHighlighter : public QSyntaxHighlighter
+class QML_EXPORT QScriptHighlighter : public QSyntaxHighlighter
 {
     Q_OBJECT
 public:
@@ -79,6 +79,6 @@ private:
     QTextCharFormat m_formats[NumFormats];
 };
 
-} // namespace SharedTools
+} // namespace QmlJS
 
 #endif // QSCRIPTSYNTAXHIGHLIGHTER_H
diff --git a/src/libs/qmljs/qscripthighlighter.pri b/src/libs/qmljs/qscripthighlighter.pri
deleted file mode 100644
index 97f8917113c..00000000000
--- a/src/libs/qmljs/qscripthighlighter.pri
+++ /dev/null
@@ -1,11 +0,0 @@
-INCLUDEPATH *= $$PWD $$PWD/..
-
-DEFINES += QSCRIPTHIGHLIGHTER_BUILD_LIB
-
-SOURCES += $$PWD/qscriptincrementalscanner.cpp
-HEADERS += $$PWD/qscriptincrementalscanner.h
-
-contains(QT, gui) {
-    SOURCES += $$PWD/qscripthighlighter.cpp $$PWD/qscriptindenter.cpp
-    HEADERS += $$PWD/qscripthighlighter.h $$PWD/qscriptindenter.h
-}
diff --git a/src/libs/qmljs/qscriptincrementalscanner.cpp b/src/libs/qmljs/qscriptincrementalscanner.cpp
index 0e5a2978bcb..41d3573bf10 100644
--- a/src/libs/qmljs/qscriptincrementalscanner.cpp
+++ b/src/libs/qmljs/qscriptincrementalscanner.cpp
@@ -27,11 +27,11 @@
 **
 **************************************************************************/
 
-#include "qscriptincrementalscanner.h"
+#include <qmljs/qscriptincrementalscanner.h>
 
 #include <QTextCharFormat>
 
-using namespace SharedTools;
+using namespace QmlJS;
 
 QScriptIncrementalScanner::QScriptIncrementalScanner()
 {
diff --git a/src/libs/qmljs/qscriptincrementalscanner.h b/src/libs/qmljs/qscriptincrementalscanner.h
index 403a174a474..590bd6395e0 100644
--- a/src/libs/qmljs/qscriptincrementalscanner.h
+++ b/src/libs/qmljs/qscriptincrementalscanner.h
@@ -30,13 +30,15 @@
 #ifndef QSCRIPTINCREMENTALSCANNER_H
 #define QSCRIPTINCREMENTALSCANNER_H
 
+#include <qmljs/qml_global.h>
+
 #include <QtCore/QList>
 #include <QtCore/QSet>
 #include <QtCore/QString>
 
-namespace SharedTools {
+namespace QmlJS {
 
-class QScriptIncrementalScanner
+class QML_EXPORT QScriptIncrementalScanner
 {
 public:
 
@@ -111,6 +113,6 @@ private:
     QList<QScriptIncrementalScanner::Token> m_tokens;
 };
 
-} // namespace SharedTools
+} // namespace QmlJS
 
 #endif // QSCRIPTINCREMENTALSCANNER_H
diff --git a/src/libs/qmljs/qscriptindenter.cpp b/src/libs/qmljs/qscriptindenter.cpp
index 0abaf574dc9..7a7ff2eb17a 100644
--- a/src/libs/qmljs/qscriptindenter.cpp
+++ b/src/libs/qmljs/qscriptindenter.cpp
@@ -65,11 +65,12 @@
     as comments and string literals are removed beforehand.
 */
 
-#include "qscriptindenter.h"
-#include "qscriptincrementalscanner.h"
+#include <qmljs/qscriptindenter.h>
+#include <qmljs/qscriptincrementalscanner.h>
+
 #include <QtDebug>
 
-using namespace SharedTools;
+using namespace QmlJS;
 
 /*
     The indenter avoids getting stuck in almost infinite loops by
diff --git a/src/libs/qmljs/qscriptindenter.h b/src/libs/qmljs/qscriptindenter.h
index 6bb0296c5a4..d338c511731 100644
--- a/src/libs/qmljs/qscriptindenter.h
+++ b/src/libs/qmljs/qscriptindenter.h
@@ -30,14 +30,16 @@
 #ifndef QTSCRIPTINDENTER_H
 #define QTSCRIPTINDENTER_H
 
-#include <qscripthighlighter/qscriptincrementalscanner.h>
+#include <qmljs/qml_global.h>
+#include <qmljs/qscriptincrementalscanner.h>
+
 #include <QtCore/QRegExp>
 #include <QtCore/QStringList>
 #include <QtGui/QTextBlock>
 
-namespace SharedTools {
+namespace QmlJS {
 
-class QScriptIndenter
+class QML_EXPORT QScriptIndenter
 {
     Q_DISABLE_COPY(QScriptIndenter)
 
@@ -132,7 +134,7 @@ private:
     QRegExp iflikeKeyword;
 };
 
-} // namespace SharedTools
+} // namespace QmlJS
 
 #endif // QTSCRIPTINDENTER_H
 
diff --git a/src/plugins/qmljseditor/qmlhighlighter.cpp b/src/plugins/qmljseditor/qmlhighlighter.cpp
index b074ca2b17c..e13d7b68ae0 100644
--- a/src/plugins/qmljseditor/qmlhighlighter.cpp
+++ b/src/plugins/qmljseditor/qmlhighlighter.cpp
@@ -35,7 +35,7 @@ using namespace QmlJSEditor;
 using namespace QmlJSEditor::Internal;
 
 QmlHighlighter::QmlHighlighter(QTextDocument *parent) :
-     SharedTools::QScriptHighlighter(true, parent)
+     QmlJS::QScriptHighlighter(true, parent)
 {
     m_currentBlockParentheses.reserve(20);
     m_braceDepth = 0;
diff --git a/src/plugins/qmljseditor/qmlhighlighter.h b/src/plugins/qmljseditor/qmlhighlighter.h
index 0ffad660c3c..f051d243363 100644
--- a/src/plugins/qmljseditor/qmlhighlighter.h
+++ b/src/plugins/qmljseditor/qmlhighlighter.h
@@ -30,7 +30,7 @@
 #ifndef QMLSYNTAXHIGHLIGHTER_H
 #define QMLSYNTAXHIGHLIGHTER_H
 
-#include <qscripthighlighter/qscripthighlighter.h>
+#include <qmljs/qscripthighlighter.h>
 #include <texteditor/basetexteditor.h>
 
 namespace QmlJSEditor {
@@ -40,7 +40,7 @@ namespace Internal {
 // the parentheses encountered in the block data
 // for parentheses matching to work.
 
-class QmlHighlighter : public SharedTools::QScriptHighlighter
+class QmlHighlighter : public QmlJS::QScriptHighlighter
 {
     Q_OBJECT
 public:
diff --git a/src/plugins/qmljseditor/qmljseditor.cpp b/src/plugins/qmljseditor/qmljseditor.cpp
index ee738429f5a..d41aee2b642 100644
--- a/src/plugins/qmljseditor/qmljseditor.cpp
+++ b/src/plugins/qmljseditor/qmljseditor.cpp
@@ -37,7 +37,7 @@
 #include "qmllookupcontext.h"
 #include "qmlresolveexpression.h"
 
-#include <qscripthighlighter/qscriptindenter.h>
+#include <qmljs/qscriptindenter.h>
 
 #include <qmljs/qmltypesystem.h>
 #include <qmljs/parser/qmljsastvisitor_p.h>
@@ -77,7 +77,6 @@ enum {
 using namespace Qml;
 using namespace QmlJS;
 using namespace QmlJS::AST;
-using namespace SharedTools;
 
 namespace {
 int blockBraceDepth(const QTextBlock &block)
@@ -633,7 +632,7 @@ bool QmlJSTextEditor::isClosingBrace(const QList<QScriptIncrementalScanner::Toke
 void QmlJSTextEditor::indentBlock(QTextDocument *doc, QTextBlock block, QChar typedChar)
 {
     TextEditor::TabSettings ts = tabSettings();
-    SharedTools::QScriptIndenter indenter;
+    QScriptIndenter indenter;
     indenter.setTabSize(ts.m_tabSize);
     indenter.setIndentSize(ts.m_indentSize);
 
diff --git a/src/plugins/qmljseditor/qmljseditor.h b/src/plugins/qmljseditor/qmljseditor.h
index a99826834ce..fdcf5da92be 100644
--- a/src/plugins/qmljseditor/qmljseditor.h
+++ b/src/plugins/qmljseditor/qmljseditor.h
@@ -31,7 +31,7 @@
 #define QMLJSEDITOR_H
 
 #include <qmljs/qmldocument.h>
-#include <qscripthighlighter/qscriptincrementalscanner.h>
+#include <qmljs/qscriptincrementalscanner.h>
 #include <texteditor/basetexteditor.h>
 
 QT_BEGIN_NAMESPACE
@@ -145,7 +145,7 @@ protected:
 private:
     virtual bool isElectricCharacter(const QChar &ch) const;
     virtual void indentBlock(QTextDocument *doc, QTextBlock block, QChar typedChar);
-    bool isClosingBrace(const QList<SharedTools::QScriptIncrementalScanner::Token> &tokens) const;
+    bool isClosingBrace(const QList<QmlJS::QScriptIncrementalScanner::Token> &tokens) const;
 
     QString wordUnderCursor() const;
 
diff --git a/src/plugins/qmljseditor/qmljseditor.pro b/src/plugins/qmljseditor/qmljseditor.pro
index 01ebebda2b8..350a284581e 100644
--- a/src/plugins/qmljseditor/qmljseditor.pro
+++ b/src/plugins/qmljseditor/qmljseditor.pro
@@ -3,10 +3,6 @@ TARGET = QmlJSEditor
 include(../../qtcreatorplugin.pri)
 include(qmljseditor_dependencies.pri)
 
-include(../../shared/qscripthighlighter/qscripthighlighter.pri)
-DEPENDPATH += ../../shared/qscripthighlighter
-
-
 CONFIG += help
 DEFINES += \
     QMLJSEDITOR_LIBRARY \
-- 
GitLab