diff --git a/src/plugins/coreplugin/editormanager/editormanager.cpp b/src/plugins/coreplugin/editormanager/editormanager.cpp index 359bdb1c0f14130eed8235da071959c0b0a86b6c..97380484c3e688850331a7eaed002a9738041b28 100644 --- a/src/plugins/coreplugin/editormanager/editormanager.cpp +++ b/src/plugins/coreplugin/editormanager/editormanager.cpp @@ -750,12 +750,12 @@ void EditorManager::activateEditor(IEditor *editor, OpenEditorFlags flags) if (splitterOrView && splitterOrView->splitter()) splitterOrView = 0; // safety if currentView gets out of sync setCurrentView(0); + if (!editor) + return; - if (editor && (flags & ActivateInPlace)) { - SplitterOrView *place = m_d->m_splitter->findView(editor); - if (place && !place->isSplitter()) { - splitterOrView = place; - } + SplitterOrView *place = m_d->m_splitter->findView(editor); + if (place && !place->isSplitter()) { + splitterOrView = place; } diff --git a/src/plugins/coreplugin/editormanager/editormanager.h b/src/plugins/coreplugin/editormanager/editormanager.h index 761bde24696aa76ecb068336ddef05f6f218d61f..2d02512b2dfb3326bf294d3333d5cddd9ff4ccc9 100644 --- a/src/plugins/coreplugin/editormanager/editormanager.h +++ b/src/plugins/coreplugin/editormanager/editormanager.h @@ -104,9 +104,7 @@ public: enum OpenEditorFlag { NoActivate = 1, - IgnoreNavigationHistory = 2, - ActivateInPlace = 4 - + IgnoreNavigationHistory = 2 }; Q_DECLARE_FLAGS(OpenEditorFlags, OpenEditorFlag) diff --git a/src/plugins/coreplugin/editormanager/openeditorswindow.cpp b/src/plugins/coreplugin/editormanager/openeditorswindow.cpp index 42d0e551b780da4bf5a29c9efea04180053ab5f6..c1c7f18bb2573198cb567cbd0a35bc57e3a077e8 100644 --- a/src/plugins/coreplugin/editormanager/openeditorswindow.cpp +++ b/src/plugins/coreplugin/editormanager/openeditorswindow.cpp @@ -235,7 +235,7 @@ void OpenEditorsWindow::selectEditor(QTreeWidgetItem *item) if (item) editor = item->data(0, Qt::UserRole).value<IEditor*>(); if (editor) - EditorManager::instance()->activateEditor(editor, EditorManager::ActivateInPlace); + EditorManager::instance()->activateEditor(editor); } void OpenEditorsWindow::editorClicked(QTreeWidgetItem *item)