From fc90ea3c10e84e078daf1bf28768a01ce7bfe7d9 Mon Sep 17 00:00:00 2001
From: dt_ <qtc-committer@nokia.com>
Date: Thu, 26 May 2011 15:33:24 +0200
Subject: [PATCH] Remove BuildConfiguration parameter from
RunConfiguration::isEnabled
Noone used it anyway, makes the code easier to refactor later.
Change-Id: I367c3f15ec5034740760dfe1becd3063b2e19dc1
Reviewed-on: http://codereview.qt.nokia.com/187
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
---
.../cmakerunconfiguration.cpp | 4 ++--
.../cmakerunconfiguration.h | 3 +--
.../projectexplorer/projectexplorer.cpp | 1 -
.../projectexplorer/runconfiguration.cpp | 18 ++----------------
src/plugins/projectexplorer/runconfiguration.h | 3 +--
.../qmlprojectrunconfiguration.cpp | 4 +---
.../qmlprojectrunconfiguration.h | 2 +-
.../qt-desktop/qt4runconfiguration.cpp | 6 ++----
.../qt-desktop/qt4runconfiguration.h | 3 +--
.../qt-s60/s60devicerunconfiguration.cpp | 11 ++---------
.../qt-s60/s60devicerunconfiguration.h | 3 +--
.../qt-s60/s60emulatorrunconfiguration.cpp | 10 ++--------
.../qt-s60/s60emulatorrunconfiguration.h | 3 +--
.../remotelinux/maemorunconfiguration.cpp | 6 ++----
.../remotelinux/maemorunconfiguration.h | 3 +--
15 files changed, 20 insertions(+), 60 deletions(-)
diff --git a/src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp b/src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp
index b8b7a9bcb64..b51748f33fa 100644
--- a/src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp
@@ -319,9 +319,9 @@ void CMakeRunConfiguration::setEnabled(bool b)
setDefaultDisplayName(defaultDisplayName());
}
-bool CMakeRunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration *bc) const
+bool CMakeRunConfiguration::isEnabled() const
{
- return m_enabled && LocalApplicationRunConfiguration::isEnabled(bc);
+ return m_enabled;
}
// Configuration widget
diff --git a/src/plugins/cmakeprojectmanager/cmakerunconfiguration.h b/src/plugins/cmakeprojectmanager/cmakerunconfiguration.h
index fd003d10897..7e4413d069f 100644
--- a/src/plugins/cmakeprojectmanager/cmakerunconfiguration.h
+++ b/src/plugins/cmakeprojectmanager/cmakerunconfiguration.h
@@ -90,8 +90,7 @@ public:
void setEnabled(bool b);
- bool isEnabled(ProjectExplorer::BuildConfiguration *bc) const;
- using LocalApplicationRunConfiguration::isEnabled;
+ bool isEnabled() const;
signals:
void baseEnvironmentChanged();
diff --git a/src/plugins/projectexplorer/projectexplorer.cpp b/src/plugins/projectexplorer/projectexplorer.cpp
index 5ab9f62fc40..f33c8e5566c 100644
--- a/src/plugins/projectexplorer/projectexplorer.cpp
+++ b/src/plugins/projectexplorer/projectexplorer.cpp
@@ -2262,7 +2262,6 @@ QString ProjectExplorerPlugin::pathFor(Node *node)
return pathOrDirectoryFor(node, false);
}
-
QString ProjectExplorerPlugin::directoryFor(Node *node)
{
return pathOrDirectoryFor(node, true);
diff --git a/src/plugins/projectexplorer/runconfiguration.cpp b/src/plugins/projectexplorer/runconfiguration.cpp
index 41580a619dd..6e56f6ac02d 100644
--- a/src/plugins/projectexplorer/runconfiguration.cpp
+++ b/src/plugins/projectexplorer/runconfiguration.cpp
@@ -198,13 +198,11 @@ void RunConfiguration::addExtraAspects()
}
/*!
- \brief Used to find out whether a runconfiguration works with the given buildconfiguration.
- \note bc may be 0!
+ \brief Used to find out whether a runconfiguration is enabled
*/
-bool RunConfiguration::isEnabled(BuildConfiguration *bc) const
+bool RunConfiguration::isEnabled() const
{
- Q_UNUSED(bc);
return true;
}
@@ -214,18 +212,6 @@ bool RunConfiguration::isEnabled(BuildConfiguration *bc) const
\brief Returns the widget used to configure this run configuration. Ownership is transferred to the caller
*/
-/*!
- \brief Used to find out whether a runconfiguration works with the active buildconfiguration.
-*/
-
-bool RunConfiguration::isEnabled() const
-{
- if (target()->project()->hasActiveBuildSettings()
- && !activeBuildConfiguration())
- return false;
- return isEnabled(activeBuildConfiguration());
-}
-
BuildConfiguration *RunConfiguration::activeBuildConfiguration() const
{
if (!target())
diff --git a/src/plugins/projectexplorer/runconfiguration.h b/src/plugins/projectexplorer/runconfiguration.h
index 5fa5c95a401..94095fa6051 100644
--- a/src/plugins/projectexplorer/runconfiguration.h
+++ b/src/plugins/projectexplorer/runconfiguration.h
@@ -59,8 +59,7 @@ class PROJECTEXPLORER_EXPORT RunConfiguration : public ProjectConfiguration
public:
virtual ~RunConfiguration();
- virtual bool isEnabled(BuildConfiguration *bc) const;
- bool isEnabled() const;
+ virtual bool isEnabled() const;
virtual QWidget *createConfigurationWidget() = 0;
Target *target() const;
diff --git a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp
index 7bd9f526e16..07d6ac1f073 100644
--- a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp
+++ b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp
@@ -86,10 +86,8 @@ QmlProjectRunConfiguration::QmlProjectRunConfiguration(QmlProjectTarget *parent,
updateQtVersions();
}
-bool QmlProjectRunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration *bc) const
+bool QmlProjectRunConfiguration::isEnabled() const
{
- Q_UNUSED(bc);
-
return m_isEnabled;
}
diff --git a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h
index 53462d57b7c..247692b6bcf 100644
--- a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h
+++ b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h
@@ -97,7 +97,7 @@ public:
Utils::Environment environment() const;
// RunConfiguration
- bool isEnabled(ProjectExplorer::BuildConfiguration *bc) const;
+ bool isEnabled() const;
virtual QWidget *createConfigurationWidget();
Utils::OutputFormatter *createOutputFormatter() const;
QVariantMap toMap() const;
diff --git a/src/plugins/qt4projectmanager/qt-desktop/qt4runconfiguration.cpp b/src/plugins/qt4projectmanager/qt-desktop/qt4runconfiguration.cpp
index bc1b879b41d..80174fa2791 100644
--- a/src/plugins/qt4projectmanager/qt-desktop/qt4runconfiguration.cpp
+++ b/src/plugins/qt4projectmanager/qt-desktop/qt4runconfiguration.cpp
@@ -138,11 +138,9 @@ Qt4DesktopTarget *Qt4RunConfiguration::qt4Target() const
return static_cast<Qt4DesktopTarget *>(target());
}
-bool Qt4RunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration * /* configuration */) const
+bool Qt4RunConfiguration::isEnabled() const
{
- if (!m_parseSuccess)
- return false;
- return true;
+ return m_parseSuccess;
}
void Qt4RunConfiguration::handleParseState(bool success)
diff --git a/src/plugins/qt4projectmanager/qt-desktop/qt4runconfiguration.h b/src/plugins/qt4projectmanager/qt-desktop/qt4runconfiguration.h
index f68c0d6d770..645c287ddf8 100644
--- a/src/plugins/qt4projectmanager/qt-desktop/qt4runconfiguration.h
+++ b/src/plugins/qt4projectmanager/qt-desktop/qt4runconfiguration.h
@@ -82,8 +82,7 @@ public:
Qt4DesktopTarget *qt4Target() const;
- virtual bool isEnabled(ProjectExplorer::BuildConfiguration *configuration) const;
- using ProjectExplorer::LocalApplicationRunConfiguration::isEnabled;
+ virtual bool isEnabled() const;
virtual QWidget *createConfigurationWidget();
virtual QString executable() const;
diff --git a/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp b/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp
index 1c62ea7a457..39ce10b1b10 100644
--- a/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp
+++ b/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp
@@ -156,16 +156,9 @@ Qt4SymbianTarget *S60DeviceRunConfiguration::qt4Target() const
return static_cast<Qt4SymbianTarget *>(target());
}
-bool S60DeviceRunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration *configuration) const
+bool S60DeviceRunConfiguration::isEnabled() const
{
- if (!m_validParse)
- return false;
-
- Q_ASSERT(configuration->target() == target());
- Q_ASSERT(target()->id() == Constants::S60_DEVICE_TARGET_ID);
-
- const Qt4BuildConfiguration *qt4bc = qobject_cast<const Qt4BuildConfiguration *>(configuration);
- return qt4bc && qt4bc->toolChain();
+ return m_validParse;
}
QWidget *S60DeviceRunConfiguration::createConfigurationWidget()
diff --git a/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.h b/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.h
index 0b72c5a8fac..28131ddec19 100644
--- a/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.h
+++ b/src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.h
@@ -67,8 +67,7 @@ public:
Qt4SymbianTarget *qt4Target() const;
SymbianQtVersion *qtVersion() const;
- using ProjectExplorer::RunConfiguration::isEnabled;
- bool isEnabled(ProjectExplorer::BuildConfiguration *configuration) const;
+ bool isEnabled() const;
QWidget *createConfigurationWidget();
Utils::OutputFormatter *createOutputFormatter() const;
diff --git a/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.cpp b/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.cpp
index 888b5f5524e..ebe575706e9 100644
--- a/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.cpp
+++ b/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.cpp
@@ -140,15 +140,9 @@ Qt4SymbianTarget *S60EmulatorRunConfiguration::qt4Target() const
return static_cast<Qt4SymbianTarget *>(target());
}
-bool S60EmulatorRunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration *configuration) const
+bool S60EmulatorRunConfiguration::isEnabled() const
{
- if (!m_validParse)
- return false;
- Q_ASSERT(configuration->target() == target());
- Q_ASSERT(target()->id() == Constants::S60_EMULATOR_TARGET_ID);
-
- const Qt4BuildConfiguration *qt4bc = qobject_cast<const Qt4BuildConfiguration *>(configuration);
- return qt4bc && qt4bc->toolChain();
+ return m_validParse;
}
QWidget *S60EmulatorRunConfiguration::createConfigurationWidget()
diff --git a/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.h b/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.h
index 616462d1259..e9d285cabd5 100644
--- a/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.h
+++ b/src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.h
@@ -68,8 +68,7 @@ public:
Qt4SymbianTarget *qt4Target() const;
- using ProjectExplorer::RunConfiguration::isEnabled;
- bool isEnabled(ProjectExplorer::BuildConfiguration *configuration) const;
+ bool isEnabled() const;
QWidget *createConfigurationWidget();
Utils::OutputFormatter *createOutputFormatter() const;
diff --git a/src/plugins/remotelinux/maemorunconfiguration.cpp b/src/plugins/remotelinux/maemorunconfiguration.cpp
index 7b993b84907..23699041cbe 100644
--- a/src/plugins/remotelinux/maemorunconfiguration.cpp
+++ b/src/plugins/remotelinux/maemorunconfiguration.cpp
@@ -129,11 +129,9 @@ Qt4BuildConfiguration *MaemoRunConfiguration::activeQt4BuildConfiguration() cons
return static_cast<Qt4BuildConfiguration *>(activeBuildConfiguration());
}
-bool MaemoRunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration * /* config */) const
+bool MaemoRunConfiguration::isEnabled() const
{
- if (!m_validParse)
- return false;
- return true;
+ return m_validParse;
}
QWidget *MaemoRunConfiguration::createConfigurationWidget()
diff --git a/src/plugins/remotelinux/maemorunconfiguration.h b/src/plugins/remotelinux/maemorunconfiguration.h
index 232cb9905e7..064555a3ec5 100644
--- a/src/plugins/remotelinux/maemorunconfiguration.h
+++ b/src/plugins/remotelinux/maemorunconfiguration.h
@@ -80,8 +80,7 @@ public:
const QString &proFilePath);
virtual ~MaemoRunConfiguration();
- using ProjectExplorer::RunConfiguration::isEnabled;
- bool isEnabled(ProjectExplorer::BuildConfiguration *config) const;
+ bool isEnabled() const;
QWidget *createConfigurationWidget();
Utils::OutputFormatter *createOutputFormatter() const;
Qt4ProjectManager::Qt4BaseTarget *qt4Target() const;
--
GitLab