GitLab

Fixes insert-definition-from-declaration when the source file was not
yet opened in an editor.

Change-Id: I4263113390ae4fbe9d4641104b5cb43373ddc5a4
Reviewed-on: http://codereview.qt-project.org/4394

Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>

Change-Id: I1bef659084727d7fe69670c991ee5efe2be66497
Reviewed-on: http://codereview.qt.nokia.com/3713

Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>

Previously RefactoringFiles were usually passed around by value.
However, since a RefactoringFile may sometimes own a QTextDocument
(when it was read from a file), that's not great and caused the
file to be reread after every copy.

With this change RefactoringFile becomes noncopyable and is always
owned by a shared pointer.

This change also allowed having const RefactoringFiles which is
useful because they can be safely used from other threads. See
CppRefactoringChanges::fileNoEditor.

Change-Id: I9045921d6d0f6349f9558ff2a3d8317ea172193b
Reviewed-on: http://codereview.qt.nokia.com/3084

Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>

Change-Id: I16b273cc792bfd2035d35e7c67675f039cd387b9
Reviewed-on: http://codereview.qt.nokia.com/3185

Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>

Change-Id: Ic424ae7ed4ac6dcda5d96353071ba0415c1815da
Reviewed-on: http://codereview.qt.nokia.com/2732

Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>

Saves a symbol.

Change-Id: Id949799852560a3e22da9c0a858b399c6ab3d6e1
Reviewed-on: http://codereview.qt.nokia.com/1295

Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>

Change-Id: I8b73d583be1ee7183f4074bce49d5390e38631a2

Reviewed-by: hjk

Reviewed-by: Christian Kamm

Reviewed-by: Christian Kamm

(cherry picked from commit b049937ae013b47e9b86aacd60325dbd382319ed)

(cherry picked from commit 519f1d11947ff3109850e559fae868c4a55deb43)

Reviewed-by: Erik Verbruggen

Still need to change it to use RefactoringChanges, and to do better definition
generation.

For answers to questions about where to insert a snippet/chunk of C++ code. Ok,
currently it will only find the One And Only place to insert method
declarations in classes, and it will need some tuning.