GitLab

We need a general purpose TimelineModel and a specialized
QmlProfilerTimelineModel.

Change-Id: I2da02d65efa11e160cab5fa9f8a21075beb0e2bf
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

Change-Id: Ibe5e7638eb7f3d88ed02e6de12b81c9b2aba3e7d
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

We use double quotes instead of single ones.

Change-Id: Ieb0024aec2053bea2a03e5ae09fb576089663ff1
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I5aa8162d18fad46601198fe71fe87591737c30ff
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

Change-Id: Ifbc42208d3a34051fbf87cff7e9179f7dcdd7bf9
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

The view should check if it needs the labels before requesting them.

Change-Id: I935259e91337202224af7890d0617e1b12dd922a
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

This relieves us of the headaches created by figuring out what should
happen if the model manager is changed later. Extension models can be
safely created through a factory.

Change-Id: I8cf8fd6d639e4e6c9da66351ea44cfc35fd614a5
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

The selectionIds are an integral part of the timeline and have to be
given for each event. The typeIds are optional. Thus it makes more
sense to store the selectionIds in the basic Range classes and have the
derived models handle the typeIds instead of doing it the other way
around.

Change-Id: I824224b6f58e8d45311134887482586283fbff41
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

The event view deals in type ids and the timeline view has to handle
selection by type id. Using the coincidence that typeId == selectionId
in the cases we're interested in is ugly.

Change-Id: I6f94ccd2c3945d5901d0a225deee7de077bfce58
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

We can easily implement all specialized models with only the public
interface.

Change-Id: I2fc75ad4a4270d9dd40068e78f9364f3963805e0
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

Remove things we don't need and add some more methods to allow
specialized models to operate without access to private class.

Change-Id: I1f42c4299825f581361a79dd0a0e00c1c08b79e7
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

In order to provide a stable interface we need most of
SortedTimelineModel to be private. There is no real benefit in keeping
a distinction between AbstractTimelineModel and SortedTimelineModel as
SortedTimelineModel isn't very useful on its own.

Change-Id: Ibc6945e2740320f430f2634f95c7807d6b460123
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

The ones we'll refactor into the timeline library should be called
timeline* and the others should be called qmlprofiler*.

Change-Id: I6ecccbe4ef523681ca0baeef140368e2c1839964
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

Avoid keeping multiple, potentially diverging copies of the same time
information and make sure all the times are consistent with each other.

Stating the times as properties allows us to use bindings in more
places, too.

Change-Id: I9cdd4f561ac22ad795939594ba340b1fbc070e9a
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

Detected by valgrind

Change-Id: If182eaa67141ce30479a6fe1ffea9e417d0edf5c
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I4137b709be718603cdc221ac938e139326c88835
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: Ida1e796637ad37cbb3c2f403151d01af1f3b2ade
Reviewed-by: hjk <hjk121@nokiamail.com>

Recent change (QTimer for waiting on input) broke this behavior.

If using ":inoremap jj <ESC>" pressing only "j" in input mode should
timeout and insert the letter.

Change-Id: Ic5a1961143e1847ef02d5063c5da9eeb63714893
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I5d57f95e98e8fb4de063b7cbe2875f11023dd1a9
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I1407b188e72ccb7ca7b47d48f9bb3041df009b8a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: I1afdbb8c88f8af06c0759b18bac5e22eb8095ede
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Add an action to copy path:<line number> to the clipboard, allowing
to conveniently copy code locations to bug reports.

Change-Id: Ia8337289d7fc8a6dd8edcd5e418a2042e8798119
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I756d07a0e59cadd8557f7a2fd00d434470000f3c
Reviewed-by: hjk <hjk121@nokiamail.com>

QMessageBox::warning is executing it's own event loop which leads to
crashes. Better is to use a message box which is using the main event
loop.

Change-Id: Ie05985dffcf505b25113755eece9b5e2256cd289
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: hjk <hjk121@nokiamail.com>

Task-number: QTCREATORBUG-13443
Change-Id: I2f8ecb92599c59e31fc931557d4bc7a6b7e306af
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I5ab80ada2d2c5a7812538c4a91b5aca8aee1a5e3
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: Ic13596d4bbfd901846575fe441607c036aba3cd5
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I25fd0d76cf69fa144112de96cc677d6f316da736
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@theqtcompany.com>

Keep the rectangles in the row they belong to and use MiterJoin to get
sharp corners.

Change-Id: I0dc9106975ccb550bfb5b5645865d0ea9318d577
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>

In situation:

    void f() {
    // Cursor is HERE.
    }

the code after ">i{" command is indented as (with shiftwidth=4):

    void f() {
        // Cursor is HERE.
    }

Change-Id: I48283c91c32fc407bbdb24349f2491461e401ee9
Reviewed-by: hjk <hjk121@nokiamail.com>

Task-number: QTCREATORBUG-12809
Change-Id: I2b2e5cdbd8ab332e1bd05fb5c7857409318b736f
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I9798adeec3b92f093a275d0af885a4546b4c545c
Reviewed-by: hjk <hjk121@nokiamail.com>

Command "<C-V>...D" deletes characters inside and behind
block selection.

Change-Id: I2589bc560306a9a5a893f810c8c8037f44517af7
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I6996d82a0a3b0e0a7bb5ddc9732297bebd368a2d
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I55ef1765c103b41b67583169718b899a8d44cac3
Reviewed-by: hjk <hjk121@nokiamail.com>

Return when the check fails, so there won't be a nullptr deref 2 lines
down.

Change-Id: I4dd1ba13798a57700c486e4b1f24b45afb2837ad
Reviewed-by: Lorenz Haas <lykurg@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>

Change-Id: I304fb125810f0857cc013e9617460d4827e9b238
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I6f5c310bcb56749c71db74b882632070166ef68b
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I8c335e5a79699d9ae1eefdb2cd60840eea1bb300
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: Ibd669a8ac75734b18b41066255a43ee8bda19743
Reviewed-by: hjk <hjk121@nokiamail.com>