GitLab

Ensuring that there's always a current index is hard work since the
data comes in asynchronously and is unsorted at first.

Task-number: QTCREATORBUG-10250
Change-Id: I2cd1420bb447ad7257f6200bcffc454a214932aa
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

They are a hassle for translators and reviewers alike.

Change-Id: I363138212b692cf75fe1605df8af3721315d37e1
Reviewed-by: hjk <hjk121@nokiamail.com>

Denoise usages

get{Short|Long}PathName are now static. They're not used anywhere except
in normalizePathName.

Change-Id: Ief277b6d828faadd98ec7faa39dd682bfaa8805f
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I0b8afe05b12123117959eec6f7465ebd4950e197
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

They are a hassle for translators and reviewers alike.

Change-Id: I07c1b61e8b6719e54fdc1f69cf63f573119a6776
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Robert Loehning <robert.loehning@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I7ab801761d88c4dde45fe1fb9f6731b65ac3d0f0
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I956b5796a67792f826ddc72e7681609372a9c029
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Remove timeout check (part of DeviceProcess now), react to the
DeviceProcess' error() signal, remove unneeded members, improve
messages.
What's left is a light-weight wrapper around DeviceProcess suitable for
run controls. Removal would result in identical boiler-plate code in
several places.

Change-Id: Ib306369df8dbf72dddb8ca305d256870a121dd63
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

... use the current kit name instead (in case it was renamed since
saving the project).

Task-number: QTCREATORBUG-10401
Change-Id: If329d3441eb27a4322cb346849e4b73296d5bf88
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change the preprocessor popup to a dialog.
Save the additional preprocessor directives to the session instead of the
.pro.user file.

Change-Id: I0d08c5684cfb21e822cde0a965c9cf14e5d6d47d
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

Do not trust kits with an invalid id, as there is no way those
could have ended up being saved out by creator. Safe all other kits
that were constructed using Kit(const QVariantMap &).

This new constructor uses the code that used to be in fromMap(...),
with some simplifications.

Remove fromMap(...) method from kit as it is no longer used.

Change-Id: Iac28ea9b85670e03088a4b7c5283af6b4b70c0fc
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

We cannot technically enforce a remote process to actually terminate,
but we don't want the associated DeviceProcess to "hang" forever.
Therefore, we now
    a) check whether the kill operation reports an error and
    b) start a timer after starting the kill operation.
If the kill operation either "officially" fails or does not have the
desired effect of actually terminating the process within a given time
frame, we set the DeviceProcess to "finished" manually. This is the same
thing that already happens when the connection gets lost, where we also
report the DeviceProcess as finished, even though the remote process
might still be running.

Change-Id: I5620f90453463c64d3a84abd30f1ec7eec9d492d
Reviewed-by: David Schulz <david.schulz@digia.com>

This avoids useless validation runs during construction.

Also reorder member variables to save a couple of bytes
in the structure.

Change-Id: Ibc33b89f12c306852af02d387ee2d177f732bb83
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

This fixes the rendering of the AbiWidget if no ABIs are deteceted.

Change-Id: I9ef4aec70e88add498fd60f29014d6bf91e0ee61
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I4ef40fd76b65f6504c8dee71bf8b5d76e1d23cbe
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Stay below the radar during construction/fromMap. This avoids some
signals from the KitManager about unmanaged kits having been updated.

This signal is used in three places only and always connected only
after the the construction happend. So this should be safe.

Change-Id: If6cc29b6bb98fa161776a9a79f48f88173db04b8
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I15cc54883cd49b49373b556e7155706f10475408
Reviewed-by: hjk <hjk121@nokiamail.com>

The SessionManager is disconnected at that point already, so we were
never told that projects were destructed already and were happily
calling into those.

This fixes the crash described in QTCREATORBUG-10354.

Task-number: QTCREATORBUG-10354
Change-Id: Ib8ce07d6db38dbff9154b127f5fb620a9961c742
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

First step towards plugin renaming.

Change-Id: I8ac017660a7aa2bda0d7bb7d72ab0cfceaf6cfd2
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Task-number: QTCREATORBUG-10370

Change-Id: If512ea8cbbd77a9c39696093153455ca9e2bb83f
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

The whole class can be removed easily now. But I was promised further
refactorings in that area anyway.

Change-Id: I20d200c6acc52604cd2c273f336374ef22626323
Reviewed-by: hjk <hjk121@nokiamail.com>

They were only used by the Madde plugin

Change-Id: I6733a3d95714f64d4fe091b8a9d4b0814134eb11
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

Cleanup overlooked in Madde removal patch.

Change-Id: I150e33a5b4602b7943f3a48e2b2076fae9f34a9e
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

With Nokia's decision to stop support for Harmattan applications
in their app store, the last remains of a use case have disappeared.

Change-Id: Ia036112de01c8c3a866da3529b4a941db11c7358
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Show the import widget if we have set a importer and hide it
otherwise.

Change-Id: Ia0a97d58a998478a9247767ace0dc6fab8ba92c2
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Another brokenness of the target setup page refactoring.

Task-number: QTCREATORBUG-10315
Change-Id: I8d35251006f409db0bd1fdb2835712028498929a
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Do not keep the name unique at KitModel level while applying changes.

We create temporary kits at that time which have conflicting names if
you added kits with the default name "Unnamed" before.

Task-number: QTCREATORBUG-10267
Change-Id: I42ba1299c938e1a2c1638d2669fc85ff5b6d88b5
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

While those do not hurt they are just unnecessary.

Change-Id: Ic2a971637fe6b0441c6fffa0d3c5161aea36e924
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Task-number: QTCREATORBUG-10352

Change-Id: If3912863b9a3fedefc6ebc2169e3a70f9c946f75
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

This seems to be a better abstraction than the "pseudo dynamic cast"
in the QmlProfilerTool and the DebuggerPlugin itself.

Change-Id: If7dea70e1353852ebb6d3ce43220c0b03ccb4b00
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

Change-Id: Iffe13621f276623c1e67f30947597ee5d624c775
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

Only methods as programming functions are affected. Besides renaming
some actions like "Switch Between Function Declaration/Definition" this
mostly touches (api) code comments.

This is a follow-up patch to commit 872bfb70.

Change-Id: Icb65e8d73b59a022f8885b14df497169543a3b92
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I44b1955c3da43f4c27ef1ed82200a14c5e1afc93
Reviewed-by: David Schulz <david.schulz@digia.com>

Change-Id: I396d970fafea1fd0b4c4d73883796662a1d0064b
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

Fix "Qt Creator" product name. Fix minor language issues.

Change-Id: I403e10e7de60b7cf3433efa2cce5647383995da7
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

QTBUG-28385 is biting us over and over (QWizard doesn't have close
button nor cancel button on Mac in Qt 5), and actually there's no reason
for us having a wizard without the features from Utils::Wizard.

Task-number: QTCREATORBUG-10346
Task-number: QTBUG-28385
Change-Id: I80c0d82fe6738496c2ac03c31a1c2757ade8e266
Reviewed-by: Jarek Kobus <jaroslaw.kobus@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Iec777d4fcf86f1807e17a5be777698b64ce15555
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Task-number: QTCREATORBUG-10235

Instead of rely on ICodeStylePreferences::destroyed() signal,
when all other objects might be in destruction phase,
clear project code style settings explicitly, when project
closes.

Change-Id: I0dd6675d54c5495d4006acbc9ad12c95f1d0a00c
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@digia.com>

Task-number: QTCREATORBUG-10235

Instead of rely on ICodeStylePreferences::destroyed() signal,
when all other objects might be in destruction phase,
clear project code style settings explicitly, when project
closes.

Change-Id: I0dd6675d54c5495d4006acbc9ad12c95f1d0a00c
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@digia.com>

Fix connection to signal activated in analyzerbase plugin,
StartRemoteDialog ctor. Related to
https://codereview.qt-project.org/#change,65357

Change-Id: I23272c41898293390f64d4b6847992b83ad5d93c
Reviewed-by: hjk <hjk121@nokiamail.com>