1. 26 May, 2015 1 commit
    • Tobias Hunger's avatar
      IWizardFactory: Create wizards with factoryCreators · 25f2f8e1
      Tobias Hunger authored
      
      
      Do not use the object pool to hold potential wizards. Register
      FactoryCreator functions with IWizardFactory instead and use
      those to create the wizards when necessary.
      
      This saves us a couple of cycles during startup since we can now
      delay construction of all wizards and it makes us more flexible
      wrt. managing the lifecycle of the wizard factories.
      
      Change-Id: I95d6a6dfcdf0fd995e1934a9fefcd96c6a676753
      Reviewed-by: default avatarEike Ziller <eike.ziller@theqtcompany.com>
      25f2f8e1
  2. 21 May, 2015 1 commit
  3. 16 Jan, 2015 1 commit
  4. 09 Oct, 2014 1 commit
  5. 26 Sep, 2014 1 commit
  6. 03 Sep, 2014 1 commit
  7. 12 Jun, 2014 6 commits
    • Tobias Hunger's avatar
      Make private class internal · e684143a
      Tobias Hunger authored
      
      
      Get rid of a couple of useless Internal:: namespace prefixes
      
      Change-Id: I99f44082a2ba0ec39b51d3f89db6697834414a99
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      e684143a
    • Tobias Hunger's avatar
      Rename ICustomWizardFactory to ICustomWizardMetaFactory · 0511ac5c
      Tobias Hunger authored
      
      
      Also rename CustomWizardFactory to CustomWizardMetaFactory. These factories
      are used to generate the actual factories that are visible in File->New, so
      they are kind of Meta:-)
      
      CustomWizardClassFactory was my first attempt, but since there are project-
      and classwizards that are generated by this meta-factory that is not a good
      name.
      
      Get rid of a useless typedef while at it.
      
      Change-Id: I3dc2cce3f52999af7e59d5f2ad5509153056ea49
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      0511ac5c
    • Tobias Hunger's avatar
      Remove IWizardFactory::Data · 0888390b
      Tobias Hunger authored
      
      
      It makes the code more complicated in one place just to make it harder
      to follow in another...
      
      Remove CustomWizardParameters::toString() while at it: It would need some
      extending to work with this change and I do not think it is worth it, considering
      that it is only used when the CustomWizard is set to verbose.
      
      Change-Id: Ice14b197ed2fe98c54bc9c1c55ece3ed2222fbbf
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      0888390b
    • Tobias Hunger's avatar
      BaseFileWizard: Get rid of addWizardPage. · 4b00a2bf
      Tobias Hunger authored
      
      
      Removing the addWizardPage function makes the code easier to follow.
      
      The old implementation did always name the CustomWizardPage as "Details",
      which is just wrong. Getting rid of this makes the page use its title as
      the progress text, which is what we want in general anyway.
      
      Change-Id: Iaf44f467c45952ad881154f31f62521f4f562658
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      4b00a2bf
    • Tobias Hunger's avatar
      CustomWizardPage: Set page title in constructor · 4a72355b
      Tobias Hunger authored
      
      
      That avoids having to do it whenever the page is created.
      
      Change-Id: Ie58288a66af79301295d74c3c9f892dc20a832af
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      4a72355b
    • Tobias Hunger's avatar
      BaseFileWizard: Get rid of applyExtensionPageShortTitle(...) · ce37f052
      Tobias Hunger authored
      
      
      That method was used to set a title in the progress view of the wizard
      that is different from the page title. That is used exactly once and
      there it adds more confusion than it helps. So get rid of the whole
      thing.
      
      Consistently set the "shortTitle" property instead for all wizards
      that want to have a separate short title.
      
      Change-Id: Ia4881e9c00891058629491f9e9de4ac421c59727
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      ce37f052
  8. 06 Jun, 2014 3 commits
  9. 05 Jun, 2014 1 commit
  10. 26 May, 2014 1 commit
    • Tobias Hunger's avatar
      IWizard->IWizardFactory · a8e89101
      Tobias Hunger authored
      
      
      Start at splitting up the wizard functionality a bit. Currently
      it is a factory but also contains a lot of logic that is invoked by
      the real wizard dialogs.
      
      This change renames/moves a couple of things only.
      
      Change-Id: I1fa114ee3ee262f7c0690841f361bbf09e674725
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      a8e89101
  11. 12 May, 2014 1 commit
  12. 06 May, 2014 1 commit
  13. 22 Apr, 2014 1 commit
  14. 17 Feb, 2014 1 commit
  15. 13 Feb, 2014 1 commit
  16. 08 Jan, 2014 1 commit
  17. 09 Oct, 2013 1 commit
  18. 24 Sep, 2013 1 commit
  19. 09 Sep, 2013 1 commit
  20. 05 Sep, 2013 1 commit
  21. 02 Sep, 2013 1 commit
    • Christian Kandeler's avatar
      Remove superfluous include paths from project files. · 72d17382
      Christian Kandeler authored
      
      
      A lot of our build system files specify unneeded include
      paths. These roughly fall into the following categories:
          a) Paths that are already set in more general files
             such as qtcreator.pri.
          b) Paths that serve no purpose at all, possibly
             left over from earlier versions of the project.
          c) Paths that act as workarounds for wrong include
             statements of the form '#include "xyz.h"', where
             xyz.h is not in the same directory as the including
            file.
      This patch removes such path specifications and fixes the offending
      include statements from case c).
      Tested on Linux, Windows and OSX with qmake and qbs.
      
      Change-Id: I039a8449f8a65df0d616b4c08081145c18ae4b15
      Reviewed-by: default avatarOswald Buddenhagen <oswald.buddenhagen@digia.com>
      Reviewed-by: default avatarJoerg Bornemann <joerg.bornemann@digia.com>
      72d17382
  22. 30 Aug, 2013 1 commit
  23. 26 Jul, 2013 1 commit
  24. 20 Jun, 2013 1 commit
  25. 26 Mar, 2013 1 commit
  26. 22 Mar, 2013 1 commit
  27. 29 Jan, 2013 1 commit
  28. 08 Jan, 2013 1 commit
    • Orgad Shaneh's avatar
      Remove braces for single lines of conditions · 29a93998
      Orgad Shaneh authored
      
      
      #!/usr/bin/env ruby
      
      Dir.glob('**/*.cpp') { |file|
        # skip ast (excluding paste, astpath, and canv'ast'imer)
        next if file =~ /ast[^eip]|keywords\.|qualifiers|preprocessor|names.cpp/i
        s = File.read(file)
        next if s.include?('qlalr')
        orig = s.dup
        s.gsub!(/\n *if [^\n]*{\n[^\n]*\n\s+}(\s+else if [^\n]* {\n[^\n]*\n\s+})*(\s+else {\n[^\n]*\n\s+})?\n/m) { |m|
          res = $&
          if res =~ /^\s*(\/\/|[A-Z_]{3,})/ # C++ comment or macro (Q_UNUSED, SDEBUG), do not touch braces
            res
          else
            res.gsub!('} else', 'else')
            res.gsub!(/\n +} *\n/m, "\n")
            res.gsub(/ *{$/, '')
          end
        }
        s.gsub!(/ *$/, '')
        File.open(file, 'wb').write(s) if s != orig
      }
      
      Change-Id: I3b30ee60df0986f66c02132c65fc38a3fbb6bbdc
      Reviewed-by: default avatarhjk <qthjk@ovi.com>
      29a93998
  29. 28 Nov, 2012 1 commit
  30. 05 Oct, 2012 1 commit
  31. 19 Jul, 2012 1 commit
  32. 17 Apr, 2012 1 commit
  33. 15 Feb, 2012 1 commit