GitLab

There's no use synchronizing the same model twice.

Reviewed-by: Roberto Raggi

A mostly mechanical change.

Reviewed-By: con

In comments and strings, electric characters have no syntactical
significance and the unnecessary automatic reindent can be annoying.

Reviewed-by: Erik Verbruggen

Reviewed-by: ogoffart

Also removed TokenUnderCursor as it's functionality is in the token cache.

Reviewed-by: ckamm

Reviewed-by: mae

This reverts commit c2393df0.

This should speed things up a bit, because before, the line was tokenized at
least 3 times.

Both for CppEditor::Internal::SemanticInfo and QmlJSEditor::Internal::
SemanticInfo.

Reviewed-by: Roberto Raggi

  * Use id() for methods returning a string used to represent
    some type of object.
  * Use displayName() for strings that are meant to be user
    visible.
  * Quieten some warnings while touching the files anyway.
  * Move Factories to their products in the plugins where that
    was not done before.

Reviewed-by: dt

Reviewed-by: Erik Verbruggen

Encapsulate the details.

the new approach makes it possible to use more edit features
inside the rename selection like cut/copy/paste. Furthermore
it compresses rename operations better on the undo stack.

Don't show the warning message (about the dangerous world of code refactoring) if the user pressed the "Yes, I know I am doing" button.

It was not working for files opened while indexing the project.