GitLab

Change-Id: Id54ceb09ada16ef41ebd568f5e8fe0559cc52e76
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

We use NavigatorModelInterface to encapsulate different models.

Change-Id: Ia7bcdfffea18942cb07ca3495e078a97ca51d97c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>

Change-Id: I949a5e96c0a0ac0e2b88860c191095543de417f5
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

We have to avoid to use the model directly, since
we will have two different models in the future.

Change-Id: I3bffc897c2c15bdd37da42df701a0e6995ba6c6f
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

This code has been moved to the delegates.

Change-Id: I3e44a3eb2038299d3b0a7de1e86ed92c3d835bd4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

NameItemDelegate does not require internals of the model anymore.
The delegates are now agnostic about the model.

Change-Id: Ibf19674b765353f1f55a361a76ab4002534b73b6
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

IconCheckboxItemDelegate does not require internals of the model anymore.

Change-Id: Ia4d2787cf34c56e8b2a3b82184b9d5f2378ce607
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

We introduce a role for the model node.
This way we do not have to access the model directly.

Change-Id: If3eb006894e1d227ec9c58bbd99cdcd500cd62d7
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Change-Id: Id35a743377d77882c7fc5e33e2a69a01c0fde140
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Change-Id: I5c74437bf2ba9dad06b452c58286a5168e6f392e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

This was just some reference/leftover. It is now used
in the WIP implementation of the new/alternate model.

Change-Id: I2909f3b7c24121277b1b05b03716d0a2dbdbcd73
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Change-Id: I8abd54b20371ffaec37c044e8cdefe4010c520dd
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

In the complex model we will not always have icons.
We keep 4 pixels for indentation.

Change-Id: I07b66d3846a36a73a2dcbe4910f2da895756ef07
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Since there will be two models we have to decouple things
in the delegates.

Change-Id: If20b7ca1ab211bbf953968fb0994679b588e8b4a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Change-Id: If1e73d218c2647074ecb198749b176b4618111b0
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

This allows to share functionality with an alternative tree model.

Change-Id: I2737ce2e7d93cc92695a6b888afda9da411c9fa4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

This allows to use the icon in other places.

Change-Id: I3c67351273f3be3c0fbe19eb58984cf54d057a3d
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

The rectangle that indicates selection has now the selection color.

Change-Id: I59bcd070bfb8b16f297e648ff53d83c8953b4896
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

This patch gets rid of of QStandardItemModel.
Instead we implement a simple tree model without
any explicit structure. The model simply maps
the generic Model to a tree.

The advantage of the new model is that is does not use
a shadow data structure (QStandardItemModel) anymore.
The original model is always directly mapped to the tree model.
This makes initialization a lot faster and and there cannot
be any synchronization issues anymore.

Change-Id: I0e71ff2d4067f29a4c25c78ad3d626a5daf206a4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

The QML minor version does not always match the
QtQuick.Item minor version. The wrong version
leads to warnings/error messages later.

Change-Id: I5d38c17da079d8309db4fd4044eb0be4e9093dae
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

This improves the signals present in "Go To Component"
or "Add Signal Handler".
For some controls we have to offer property changed signal
handler as first options.
We simply hard code properties which are likely to be handled.

Change-Id: Ide26589534d6d058f1b60afcc6353c4f0340cb22
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

We set the same minimum width the item library has.
This avoids overlapping icons, depending on the depth of the tree.
Since we are rewriting the tree view anyway this should be good
enough for now.

Task-number: QTCREATORBUG-18131
Change-Id: Id5f018c118499a8a47785282a25a29d40e0685b3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Task-number: QTCREATORBUG-17965
Change-Id: Id2a3bef8d4becdecc9f358021a18feb2353743b5
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>

Change-Id: I3a1ef67d8af255604494695807331576540b8afa
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>

Change-Id: Ibdc46d30ad3f2b703d4cbdd796a1032030bd17cd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>

 - use const and static where it is possible
 - use arg() to merge the file name string (shorter)
 - introduce  possiblePaths list to get it while debugging

Change-Id: I64858540c5d9d9cfde3094de8e07dda744d0f43d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>

 - improve existing superClasses() via using transform (internal it uses
   reserve, shorter, ...)
 - remove unused superClassNames() if necessary it can be done by a
   simple transform call
 - introduce and use classHierarchy() and fix foreach loop which was using
   wrong "modelNode" instead of "superClass"

Change-Id: Ia52bcbd322f3a047a020faf4a67aca2a1b8fd19a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>

Those are not used and will not be used by the designer
and user reconfigure them e.g. on macOS.

Task-number: QTCREATORBUG-17968
Change-Id: I39d679cbce60de4c6951a82fa12d3c7c4fc630f3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

With Qt 5.9 we have to first anchor the TabBar.
Otherwise the tab buttons are not layouted properly.

Change-Id: Ia20f2f6bbe8659f3b0be36ae3b56e8ce07b2dca1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

If the document has an error (e.g. incomplete type information),
then it is required to update the item library if this error is fixed.

Change-Id: Iee9629879a0d3ee4bbc76dc0701f023e3c12f394
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

I had this a couple of times and this does not seem fatal.

Change-Id: Id6d2101a5dc1bdc652e6ca8557c7dd8450399be4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Was broken since 6f1d2371 which sets
css only at widgets where it is necessary.

Change-Id: Ia60672136ad8c73791806c920051918dbb23748c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>

This is a nasty one. The text item that
triggers the crash is part of a delegate and therefore,
does not have an item in the scene.
The rewriter is now setting the id again, when reading the file after
the Rectangle is removed. we get a crash.
Since delegates are currently not shown in the navigator, this crash
could not happen before we introduced the integrated text editor.


Task-number: QTCREATORBUG-17970
Change-Id: Ica16dec5bb2f852324de179c4a2b4d43dcf27aa9
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Change-Id: Ic7cb2dd1e6d1bfb7c21722cd42ab6443b9ee5fc3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Change-Id: Iecc75dab66077d43fe22e15f28876c4d3cf6a322
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Change-Id: Idc9fc90fc63d3154ed893dab85c9806ece485825
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

We store generic error messages in the root node.
Those have to be reset.
Also we have to reset the type icon if there is no error anymore.

Change-Id: Ibe6274f651113f26aef6240bb9efa005862378f4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Applying a .css style overrides the text editor background color
from the theme.
To avoid this we cannot apply any .css on the integrated text editor or
its parents:

 * Only apply the center widget .css to the tab bar.
 * Apply the scrollbar.css only to the scrollbars.

Change-Id: Id9b009a208ea2830c64be8174dbb548ada692560
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

For some themes this is done anyway, but not for the default themes.
We have to do this to ensure the "base style" plays well with the applied
.css.
Otherwise the combo box might sound out in weird ways and the colors
might have usablity issues.

Task-number: QTCREATORBUG-17933
Change-Id: I4319ed9b965f4b4b3e975f2348fb89ffd9987bc3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

The release mouse event does not come through if we start a drag.
There was already a workaround that stopped working with 5.8 and
did rely on private API.
I removed all usage of private API and added a simple workaround
that synthesises a mouse release event.

The actual execution of the drag is now asynchronous to
ensure the release event is delivered properly.

I removed all dependencies on private API in the designer.

In Qt 5.9 the issue seems to be fixed in Qt.
The workaround does not seem to get in the way of the fix.
Eventually, the workaround can be removed.

Change-Id: I9b45b255da5e44c26aba2acf4a42f88537126f75
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>