GitLab

Checking the string for validity is not enough, actually bailing out if
it is invalid is better...

Rubber-stamped-by: Tobias Hunger <tobias.hunger@nokia.com>
Rubber-stamped-by: hjk

Task-Nr: QTCREATORBUG-3778

Make sure we pick up the debugger version of qmljsdebugger library.

Reviewed-By: con

Convenient since you'll usually move the tool box next to the
application window.

Reviewed-by: Kai Koehne

This makes sure it gets deleted together with the QmlApplicationViewer,
rather than probably not at all when no parent is specified for the
viewer (which is the default).

Reviewed-by: Alessandro Portale
Reviewed-by: Christiaan Janssen

Now in a tool window so that it generally doesn't interfere with the
application.

Qt 4.8 behaves differently.

Task-Nr: QTCREATORBUG-3849

Task-number: QTCREATORBUG-3828

Reviewed-by: Christian Kandeler

The user probably wants to have just his builds.

Rewrite the target setup page to look and baheve better.
Noteable better at:
- Disabling shadow building
- Deselecting whole targets
- Adding import directories

Api-wise, Targets derived from Qt4BaseTarget have two ways to customize
the targetsetuppage.

a) Reimplement availableBuildConfigurations
b) Leave createTargetSetupWidget and create(... Qt4TargetSetupWidget)
   in their default implementation. (Or only slightly customize like
   the desktop target does.)

Or:
a) Make a dummy implementation for availableBuildConfiguration
b) Replace createTargetSetupWidget and return your own widget
   (It should match the look and feel from the other widgets.)
   It needs to be derived from Qt4TargetSetupWidget
c) Also replace the create create(... Qt4TargetSetupWidget) function
   and set up the target anyway you want.

to be used on the new target setup page

loadProject did mostly the same as openProject. So it can be removed.
(Also the error handling was wrong too.)

In that mode the lineedit is readonly and the browse button is
disabled. To be used in the new targetsetuppage

Existing Directory checks for whether the directory exists, which
Directory does not. Also changes all existing PathChoosers from
Directory to ExistingDirectory as that does not change behaviour.

Make the internal data structure a map from id to Version, simplfing a few
functions. Return sorted lists, with newer versions in front for various
functions, e.g. validVersions(), versionsForTargetId.

To be used on the new targetsetuppage

Reviewed-by: Christian Kandeler

Reviewed-by: Christian Kandeler