GitLab

Change-Id: I2a051304de8f6aba3b37a0d572e96f35dd9d259b
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Change-Id: Ida47885f58aa0a219ad9eef5aa670a643c58744e
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I8cf154434ed757861bf43de68ea9b6625cd6db4c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

Change-Id: Idaa794204b87b5a139203a6d183935425ecfd67e
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Also give a 1x1 pixmap back to avoid paint engine error messages.

Change-Id: Ibd7793d133952c4c3169796432b42572af0ace21
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>

The UI text guidelines advice against this.

Change-Id: Ib8f9cb291f0217de10853412b133173f1d11e7b7
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Change-Id: I20d2266b2f40dc19b367e7704b72977a84814c3c
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>

Change-Id: If1ac4ac557790b4919637c77222c4a49c4366170
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>

Change-Id: I744022ca4441880995f9b965bf7092d6ec985886
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

If there is only one view, it should show the "close to the right" icon,
not "close to the left".

Change-Id: Ifb7c4261cb74e35310dc3d634720d9daa20df3f1
Reviewed-by: André Hartmann <aha_1980@gmx.de>

Update and add screenshots.

Change-Id: I3fb8b8193a6f83449dd121c32778ec22a156288f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: I0dea28ceec2ed3261a1a5b25c7b4b2c8f58f7be8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: Ifbbc42069951c6cd41e33df4324ff6cbeabea79f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I9aeef5758c6291f19efc3d72d5d985adad4c13ab
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>

When using locator in the external help window, open help pages or show
the topic chooser in the external help window, not the main window.

Change-Id: I792223147f1eb00addafb2618017536c126c71dd
Reviewed-by: David Schulz <david.schulz@qt.io>

Change-Id: I566e54e8cb539227019fd9cf94113924d1ac9822
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>

This function is used in some of the plugin unit tests of
QC.

Change-Id: I8e5f5b734a78a207f139b676aa6616abcc9ce7c0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

This also removes an additional line when the cursor is on a line start.

Change-Id: Iaec6f60b8e33d98c3a3ed0555ee4ff01991ad7fb
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Change-Id: I0edf0fd32077a06102aec5951860c28723e46178
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: I1f1f2c8dee1afc768633af074af650bdfd200a2a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: I2f7f92b028dcb60491d813b88bfe881c305c66ad
Reviewed-by: David Schulz <david.schulz@qt.io>

Change-Id: Ife169124f9fcd885774cd39698281e9a64e4545b
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

The definite article "the" should be "an", but I would like
to rewrite the notice to use simpler language.

Change-Id: Ic611343724f32b3b1f22a5c768c387cafceb0890
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>

...by adapting to recent mime type changes:

    commit e8e46ab5
    Plugins: Fix that mimetype definition was not valid JSON

Change-Id: Iac416ab481814e4488fac4d818c51c647c1ec349
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

Utils::matchCaseReplacement searches for common prefix and suffix
between old and new file name und leaves them unchanged. This leads
to unexpected new file names.

E.g. when renaming MainWindow to MyMainWindow, this function computes
the prefix "m", the suffix "ainwindow.h" and only considers "yM" as
the middle part that is actually renamed.

Use a better algorithm to determine the new base name, and for
unclear cases fall back to the "Lower case file names" option
from Tools -> Options -> C++ -> File Naming.

Task-number: QTCREATORBUG-18592
Change-Id: I818f7d372102eb6e266123b2b4b6355f6fa28d64
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

Change-Id: Iaa6476be9285d814e4357b861c8fd00f1c9adc1c
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

... that do not define their own completion assist provider

Change-Id: I8edb65647a55178d4388b26c95cdeb301ff9f3fa
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

If attaching to the current's project running executable fails due
crashing inferior the run tool is cleaned up already when trying to
fetch its run parameters.
Circumvent by checking whether run tool is still accessible.

Change-Id: I56f3d841d77d0513806a2b91357841f160f74ed3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I9c8fbe14d238b2c2526598d4cbca561c7e9a5d0e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: I486c690f848a15ac4675077e786a05fbd65e6a0c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>

Fix recursion for QVariant printers.

Change-Id: I1473a94102d0f4446e8033f4c1828735614cdfa3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

The replacement of string defines in the .rc file that was introduced
in commit b5703bcd029fd does not work with windres. Here the string
literals have to be explicitly quoted by STRINGIFY. Also, we need to
replace literal spaces with \x20.

Task-number: QTCREATORBUG-18635
Change-Id: Ie01886ea680c3c07c4e0a031f12b6fe60e896263
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

Change-Id: I7d78ce4ed70a14cfea95cfac4a852ba715e64fb1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

/src/plugins/qmldesigner/components/formeditor/selectiontool.cpp:145:
warning: suggest parentheses around '&&' within '||' [-Wparentheses]
                 || selectedItemCursorInMovableArea(event->scenePos())
                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                 && !event->modifiers().testFlag(Qt::ControlModifier)
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                 && !event->modifiers().testFlag(Qt::ShiftModifier)) {
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: Iea6018d885b9bad13363a39e2aee0e6e229f93c4
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Change-Id: Ib86e09d6d516b175e715725fa9b60d7ae2626ff8
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>

Nokia's license header was removed in
b342ad8c, but these files didn't have the
second license header that was supposed to remain.

Change-Id: Ib9977a3127fd48197a1a02982e7563c486bfca3a
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>

Change-Id: Icce9d191cc6cae89baf973e949dc0757d318d6ea
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>

To draw the result items with highlighted parts, we split the text to
draw into "before highlight", "highlight" and "after highlight", and
painted them separately. This had several issues:

It breaks the text layout. Characters within a text are often started at
subpixels, which was not so visible in the static search results, but
lead to ugly artifacts while typing in Locator (enter a search term, and
then continue adding characters that still match the first found item,
and watch the effect in the "after highlight" part).

It needs a lot of custom painting code. Properly supporting text elide
modes is hard, scaling to more than one highlight as well. Reusing parts
of the QItemDelegate base functions also has its issues, e.g. that
clipping doesn't work well.

Instead, QItemDelegate::drawDisplay should make it possible to set
format ranges for the text it draws. This patch copies part of
QItemDelegate to be able to add this parameter. Unfortunately Qt
currently has a bug (QTBUG-62019) that character backgrounds are not
painted far enough (1 pixel to the right has the wrong background), which
looks very ugly in selected items in the search results. So we use the
new delegate only for Locator for now, to be used later for the search
results too, when that bug is fixed.

Task-number: QTCREATORBUG-18532
Change-Id: Idf59b2c2bcfa6b188a810f7a3128a81e7e6fffb1
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: David Schulz <david.schulz@qt.io>

Mostly whitespace cleanup.

Change-Id: Ife5831b23d5ee7406ece839f2c1061c9364ac4ad
Reviewed-by: David Schulz <david.schulz@qt.io>

Change-Id: I8ba0e8451772eff605961e0d9aff15f535c12566
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>