GitLab

The string cache is only very seldom written but very often read. To
improve thread scaling it is faster to lock it only for write operations.
So we use a shared mutex which is locked in shared mode for read
operations and locked exclusively for write operations.

Change-Id: I7dfd4a02c5484683e4d0becd39269c0146126a96
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Right now, the qmake project manager offers a "Build" context menu entry
for .ui.qml files and various other things are off because the mime
types are different.

Change-Id: Icc966e56513b9c5aed05f929dc8cb728ed408723
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>

Change-Id: Ibcdd1230b40d1ca7a414843ee0f9ae4cddb29f6f

This got broken with the introduction of the grouping.

Task-number: QTCREATORBUG-15814
Change-Id: Ic9908d01a1ecb636db0c8f4b7f1db926ccaedd4e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

Change-Id: I3808e973671849c6014780ee99896cb2d139dc18
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

Task-number: QTCREATORBUG-19112
Change-Id: I17893c3e15e9cabc09bf5ebb6746a5d76d9cc0bd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

De-virtualize requestInterruptInferior() and let always
the master engine react to the request. interruptInferior()
diverts to the active slave in case of the combined engine.

Change-Id: I5d62cf9379c8a452132827897a9ac51e4027f595
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Make model manager able to select the most functional
refactoring engine from the available ones.

Change-Id: I74031c910706fd694a0a7def022531501f1ea005
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>

Change-Id: I8ac1ff2bbe2c16b080dcfced489c1c932dbd102a
Reviewed-by: hjk <hjk@qt.io>

Change-Id: I4573c26df5d41d6fdab4ddeb1d70ee5d2bc10c11
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>

Change-Id: Iec13f7002816db54279507250a6b5050f41b45f2
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Change-Id: Ie7d3db989b48a605fad4642c339940d67e505e1e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Width is not zero-based.

Task-number: QTCREATORBUG-19091
Change-Id: I32134727bed204f6bb10748cd067a775f673b89b
Reviewed-by: David Schulz <david.schulz@qt.io>

This removes the setupSlaveInferior() synchronization point which
wasn't really needed anymore as it was always triggered in
response to a notifyEngineSetupOk() of the master engine.

Change-Id: I24faec36b180fa961e10dfd88fe4d874f7310140
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Having each source/header/form file on its own line
makes further moving around (e.g. sorting) much easier.

Also bring indentation for source/header sections to
the same level.

Amends commit cf40d98d

Change-Id: I95ad9c9298ae01e548a595b29d7f7651220adadd
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Enable Build File for source or header files only and
de-duplicate the corresponding code.

Before, the menus were incorrectly enabled for e.g. .pro
and .ui files also: While the menu was already hidden for
these  non-source files in updateContextActions(), the
following  call to updateBuildFileAction() did enable it
again.

Task-number: QTCREATORBUG-19098
Change-Id: I87f40e64ab044b33be9c465d1c5dfa36c3cf1260
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Change-Id: I22aced21a8c951c746c6617d20d95fd81f5cef63
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

The quotes are stripped when the string is presented for editing, so
they have to be added back when we're done editing.

This is what we already did if we were talking to the inspector rather
than the V4 debugger.

In order for this to work, JS numbers need to be identified as numbers,
rather than strings. So, we have to add "number" to the types recognized
as float.

Change-Id: I2054f4ad36ec1d14fb2dfee3705a80c8ec84d5ac
Task-number: QTCREATORBUG-19032
Reviewed-by: hjk <hjk@qt.io>

Change-Id: Ia78fd000a4836fa54567bc57ef401eedb3dcc7b4
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Otherwise we get a soft assert there.

Change-Id: I701672d1f479f2281c85fa1bc77fa2216b0b0d98
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

A private change[1] is only visible to the uploader and reviewers (like
draft in older Gerrit).

A WIP change[2] does not generate notifications until it becomes ready.

[1] https://gerrit-review.googlesource.com/Documentation/intro-user.html#private-changes
[2] https://gerrit-review.googlesource.com/Documentation/user-upload.html#wip

Change-Id: I4905461c529e93e86be934c60eab218ff7474fcd
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

.. in MiniProjectTargetSelector::addedDeployConfiguration. Similar
was already present in  MiniProjectTargetSelector::addedRunConfiguration

Change-Id: Ie1c86a8e12bdbfd5c0beea58a1a41a2cbf3d52f2
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

On the other platforms and in the sources, the wizards can be found
in share/qtcreator/templates/wizards.

Task-number: QTCREATORBUG-19103
Change-Id: Ic8c67e3b45f294c6e5bc175938de6182364dd584
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

GdbEngine::m_startMode should be always the same as in the RunParameters.

Change-Id: Iceac9b28b8273847f7ee518572d93e796fffeb14
Reviewed-by: David Schulz <david.schulz@qt.io>

Remove unneeded include and declaration.

Change-Id: Ib0aca8a6b76a58f0231c507298ed91c659c2e74b
Reviewed-by: David Schulz <david.schulz@qt.io>

The exectuable path in the user output was always converted to native
separators, even for non-Desktop targets.

Change-Id: I5b43b2da8a2b791472a1fd58940b179dcbaa28d0
Reviewed-by: hjk <hjk@qt.io>

 - when puppet is restarted
 - when the view is attached (switching document, switching mode)

Change-Id: I06a4acf78a18b893bca9f7cd3d2bae74dc3459aa
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>

Change-Id: I649323e3c2cc51ea69dd7e216f30eeb653f3873b
Reviewed-by: hjk <hjk@qt.io>

Fix soft assert when accessing the lone project file node in a project
that failed to parse.

Change-Id: I73d9b0012292dd5516a0a9c81cdc4003eebf2a92
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Use a better way to retrieve the project from a containernode.

Change-Id: I8b0a0aa86e823ef3b9cab512a1374f7fb77f1aa3
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Change-Id: Iaeca64c025a870ce83f9d806fdd3e086599046d5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Make sure to create the active target first when reading a project
for the user data. This implicitly sets this target to the active one,
avoiding one spurious activeTargetChanged signal.

Change-Id: Iff9b19ed25bac9809ae75489ae159ffb66e71cb4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Change-Id: I2c5bf237cc29eb42f26b357eb31922323639bf71
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

Do not add inferior command line arguments to the cdb process if we are
attaching to an already running process.

Task-number: QTCREATORBUG-19034
Change-Id: I7b9a98b790e819fc76ff4ec75769785741bfde83
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

A customer had trouble launching debugger on a Wacom Tablet
when other processes were running. After all processes were
stopped, the debugger could be launched.

Change-Id: Ifd3da7904e9ff8e7af958e6abc7b21c1a88fa2e2
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Mika Salmela <mika.salmela@qt.io>

Change-Id: I2d02aec89bf5d7afe1d173fb5054f92f9bf1c3bf
Reviewed-by: André Hartmann <aha_1980@gmx.de>

If we failed to find a project part for the respective file
it is most likely that we had a header with declarations only
but we can still find depending targets for this file.

Task-number: QTCREATORBUG-18922
Change-Id: I80d0af569bbd6c2a41bf498fb55283704f16439c
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>

Change-Id: I1131fdfdb1599bf470db502c222792d4419fa13e
Reviewed-by: hjk <hjk@qt.io>

Change-Id: I5e52706817f4345ea707b5e8c07923c8c836ca0e
Reviewed-by: hjk <hjk@qt.io>

Especially when the code editor is used types can be invalid.

Task-number: QTCREATORBUG-19079
Change-Id: I4c832c3ce10b7ed10c99ae53470fc79d6a23bfb9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>